makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-11 05:48:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11508] Allow equal sign in parameter value.

Browse source 
PHPBB3-11508
This commit is contained in:
Cesar G 2014-04-15 13:13:37 -07:00
parent 9e605b1338
commit e287eea2c6
2 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
phpBB/phpbb/path_helper.php
View file

@ -254,16 +254,18 @@ class path_helper
foreach ($args as $argument) foreach ($args as $argument)
{ {
$arguments = explode('=', $argument); if (empty($argument))
$key = $arguments[0]; {
unset($arguments[0]); continue;
}
list($key, $value) = explode('=', $argument, 2);
if ($key === '') if ($key === '')
{ {
continue; continue;
} }
$params[$key] = $arguments[1]; $params[$key] = $value;
} }
} }
else else

15
tests/path_helper/path_helper_test.php
View file

@ -226,6 +226,21 @@ class phpbb_path_helper_test extends phpbb_test_case
true, true,
array('base' => 'https://phpbb.com/community/viewtopic.php', 'params' => array('t' => '5', 'f' => '6')), array('base' => 'https://phpbb.com/community/viewtopic.php', 'params' => array('t' => '5', 'f' => '6')),
), ),
array(
'test.php?topic=post=5&f=3',
true,
array('base' => 'test.php', 'params' => array('topic' => 'post=5', 'f' => '3')),
),
array(
'mcp.php?&t=4&f=3',
true,
array('base' => 'mcp.php', 'params' => array('t' => '4', 'f' => '3')),
),
array(
'mcp.php?=4&f=3',
true,
array('base' => 'mcp.php', 'params' => array('f' => '3')),
),
); );
} }