From e8493f915931f60d46d0efffee7b6ae23b1c01c8 Mon Sep 17 00:00:00 2001 From: hanakin Date: Sat, 2 May 2020 18:43:55 -1000 Subject: [PATCH] [ticket/16237] use icon function title when poss PHPBB3-16237 --- .../all/template/macros/icons/font.twig | 3 +- .../all/template/macros/icons/iconify.twig | 3 +- .../styles/all/template/macros/icons/png.twig | 2 +- .../styles/all/template/macros/icons/svg.twig | 2 +- phpBB/styles/prosilver/template/faq_body.html | 2 +- .../prosilver/template/forumlist_body.html | 9 ++-- phpBB/styles/prosilver/template/jumpbox.html | 8 ++-- .../styles/prosilver/template/mcp_forum.html | 6 +-- phpBB/styles/prosilver/template/mcp_post.html | 12 +++--- .../styles/prosilver/template/mcp_topic.html | 4 +- .../styles/prosilver/template/mcp_whois.html | 4 +- .../prosilver/template/memberlist_view.html | 2 +- .../prosilver/template/message_body.html | 2 +- .../prosilver/template/navbar_footer.html | 12 +++--- .../prosilver/template/navbar_header.html | 42 +++++++++---------- .../template/notification_dropdown.html | 2 +- .../prosilver/template/overall_header.html | 4 +- .../styles/prosilver/template/pagination.html | 6 +-- .../prosilver/template/posting_review.html | 4 +- .../template/posting_topic_review.html | 8 ++-- .../prosilver/template/search_results.html | 20 ++++----- .../template/ucp_main_bookmarks.html | 8 ++-- .../prosilver/template/ucp_main_front.html | 4 +- .../template/ucp_main_subscribed.html | 10 ++--- .../prosilver/template/ucp_pm_history.html | 4 +- .../template/ucp_pm_message_header.html | 4 +- .../prosilver/template/ucp_pm_viewfolder.html | 2 +- .../template/ucp_pm_viewmessage.html | 20 ++++----- .../prosilver/template/viewforum_body.html | 14 +++---- .../prosilver/template/viewtopic_body.html | 14 +++---- 30 files changed, 117 insertions(+), 120 deletions(-) diff --git a/phpBB/styles/all/template/macros/icons/font.twig b/phpBB/styles/all/template/macros/icons/font.twig index a882a25c40..f20bcc3a36 100644 --- a/phpBB/styles/all/template/macros/icons/font.twig +++ b/phpBB/styles/all/template/macros/icons/font.twig @@ -1,4 +1,3 @@ {% spaceless %} - - {% if TITLE %}{{ lang(TITLE) }}{% endif %} + {% if TITLE %}{{ lang(TITLE) }}{% endif %} {% endspaceless %} diff --git a/phpBB/styles/all/template/macros/icons/iconify.twig b/phpBB/styles/all/template/macros/icons/iconify.twig index 43b8b88948..8ffcf7a4d3 100644 --- a/phpBB/styles/all/template/macros/icons/iconify.twig +++ b/phpBB/styles/all/template/macros/icons/iconify.twig @@ -1,4 +1,3 @@ {% spaceless %} - - {% if TITLE %}{{ lang(TITLE) }}{% endif %} + {% if TITLE %}{{ lang(TITLE) }}{% endif %} {% endspaceless %} diff --git a/phpBB/styles/all/template/macros/icons/png.twig b/phpBB/styles/all/template/macros/icons/png.twig index 426f7a3a5e..f171d591b7 100644 --- a/phpBB/styles/all/template/macros/icons/png.twig +++ b/phpBB/styles/all/template/macros/icons/png.twig @@ -1,3 +1,3 @@ {% spaceless %} - {{ lang(TITLE) }} + {{ TITLE }} {% endspaceless %} diff --git a/phpBB/styles/all/template/macros/icons/svg.twig b/phpBB/styles/all/template/macros/icons/svg.twig index e24777272e..601661dc35 100644 --- a/phpBB/styles/all/template/macros/icons/svg.twig +++ b/phpBB/styles/all/template/macros/icons/svg.twig @@ -2,7 +2,7 @@ {% set TITLE_ID = TITLE ? TITLE|lower|replace({' ': '_'}) ~ '-' ~ random() %} diff --git a/phpBB/styles/prosilver/template/faq_body.html b/phpBB/styles/prosilver/template/faq_body.html index f556fe7099..44d2767c69 100644 --- a/phpBB/styles/prosilver/template/faq_body.html +++ b/phpBB/styles/prosilver/template/faq_body.html @@ -36,7 +36,7 @@
{faq_block.faq_row.FAQ_ANSWER}
- {{ Icon('iconify', 'fa:chevron-circle-up', '', true) }}{L_BACK_TO_TOP} + {{ Icon('iconify', 'fa:chevron-circle-up', lang('BACK_TO_TOP'), false) }}
diff --git a/phpBB/styles/prosilver/template/forumlist_body.html b/phpBB/styles/prosilver/template/forumlist_body.html index eaac5afa5d..72ae4de0b7 100644 --- a/phpBB/styles/prosilver/template/forumlist_body.html +++ b/phpBB/styles/prosilver/template/forumlist_body.html @@ -69,8 +69,7 @@ {{ Icon('iconify', { 'fa:external-link' : forumrow.subforum.IS_LINK , 'fa:file-o' : true, - }, '', true, 'c-subforum-icon') }} - {forumrow.subforum.SUBFORUM_NAME} + }, forumrow.subforum.SUBFORUM_NAME, false, 'c-subforum-icon') }} {% if not forumrow.subforum.S_LAST_ROW %}{L_COMMA_SEPARATOR}{% endif %} @@ -98,11 +97,11 @@ - {{ Icon('iconify', 'mdi:alert-decagram', '', true, 'c-unapproved-icon') }}{L_TOPICS_UNAPPROVED} + {{ Icon('iconify', 'mdi:alert-decagram', lang('TOPICS_UNAPPROVED'), true, 'c-unapproved-icon') }} - {{ Icon('iconify', 'mdi:alert-decagram', '', true, 'c-unapproved-icon') }}{L_TOPICS_UNAPPROVED} + {{ Icon('iconify', 'mdi:alert-decagram', lang('TOPICS_UNAPPROVED'), true, 'c-unapproved-icon') }} @@ -114,7 +113,7 @@ {L_POST_BY_AUTHOR} {forumrow.LAST_POSTER_FULL} - {{ Icon('iconify', 'fa:external-link-square', '', true, 'c-last-post-icon') }}{L_TOPICS_UNAPPROVED} + {{ Icon('iconify', 'fa:external-link-square', lang('TOPICS_UNAPPROVED'), true, 'c-last-post-icon') }}
diff --git a/phpBB/styles/prosilver/template/jumpbox.html b/phpBB/styles/prosilver/template/jumpbox.html index 86afd6e8a2..41185a7876 100644 --- a/phpBB/styles/prosilver/template/jumpbox.html +++ b/phpBB/styles/prosilver/template/jumpbox.html @@ -3,25 +3,25 @@

- {{ Icon('iconify', 'fa:angle-' ~ S_CONTENT_FLOW_BEGIN, '', true, 'c-return-arrow-icon') }}{L_RETURN_TO_FORUM} + {{ Icon('iconify', 'fa:angle-' ~ S_CONTENT_FLOW_BEGIN, lang('RETURN_TO_FORUM'), false, 'c-return-arrow-icon') }}

- {{ Icon('iconify', 'fa:angle-' ~ S_CONTENT_FLOW_BEGIN, '', true, 'c-return-arrow-icon') }}{L_RETURN_TO_INDEX} + {{ Icon('iconify', 'fa:angle-' ~ S_CONTENT_FLOW_BEGIN, lang('RETURN_TO_INDEX'), false, 'c-return-arrow-icon') }}

- {{ Icon('iconify', 'fa:angle-' ~ S_CONTENT_FLOW_BEGIN, '', true, 'c-return-arrow-icon') }}{L_RETURN_TO_TOPIC} + {{ Icon('iconify', 'fa:angle-' ~ S_CONTENT_FLOW_BEGIN, lang('RETURN_TO_TOPIC'), false, 'c-return-arrow-icon') }}

- {{ Icon('iconify', 'fa:angle-' ~ S_CONTENT_FLOW_BEGIN, '', true, 'c-return-arrow-icon') }}{L_GO_TO_SEARCH_ADV} + {{ Icon('iconify', 'fa:angle-' ~ S_CONTENT_FLOW_BEGIN, lang('GO_TO_SEARCH_ADV'), false, 'c-return-arrow-icon') }}

diff --git a/phpBB/styles/prosilver/template/mcp_forum.html b/phpBB/styles/prosilver/template/mcp_forum.html index 8455ad4270..a87dbc05d4 100644 --- a/phpBB/styles/prosilver/template/mcp_forum.html +++ b/phpBB/styles/prosilver/template/mcp_forum.html @@ -63,17 +63,17 @@ - {{ Icon('iconify', 'fa:question', '', true, 'c-unapproved-icon') }}{L_TOPIC_UNAPPROVED} + {{ Icon('iconify', 'fa:question', lang('TOPIC_UNAPPROVED'), true, 'c-unapproved-icon') }} - {{ Icon('iconify', 'fa:recycle', '', true, 'c-topic-deleted-icon') }}{L_TOPIC_DELETED} + {{ Icon('iconify', 'fa:recycle', lang('TOPIC_DELETED'), true, 'c-topic-deleted-icon') }} - {{ Icon('iconify', 'fa:exclamation', '', true, 'c-topic-reported-icon') }}{L_TOPIC_REPORTED} + {{ Icon('iconify', 'fa:exclamation', lang('TOPIC_REPORTED'), true, 'c-topic-reported-icon') }}  [ {L_DELETE_SHADOW_TOPIC} ] diff --git a/phpBB/styles/prosilver/template/mcp_post.html b/phpBB/styles/prosilver/template/mcp_post.html index 96bb0a2852..0a37c151ed 100644 --- a/phpBB/styles/prosilver/template/mcp_post.html +++ b/phpBB/styles/prosilver/template/mcp_post.html @@ -61,7 +61,7 @@
  • - {{ Icon('iconify', 'fa:pencil', '', true, 'c-button-icon') }}{L_EDIT_POST} + {{ Icon('iconify', 'fa:pencil', lang('EDIT_POST'), true, 'c-button-icon') }}
  • @@ -75,7 +75,7 @@
    {L_BCC}{L_COLON} {bcc_recipient.NAME_FULL} style="color:{bcc_recipient.COLOUR};">{bcc_recipient.NAME} 

    -

    {{ Icon('iconify', 'fa:file', '', true, 'c-topic-icon') }}{MINI_POST_IMG} {L_POSTED} {L_POST_BY_AUTHOR} {POST_AUTHOR_FULL} » {POST_DATE}

    +

    {{ Icon('iconify', 'fa:file', MINI_POST_IMG, true, 'c-topic-icon') }} {L_POSTED} {L_POST_BY_AUTHOR} {POST_AUTHOR_FULL} » {POST_DATE}

    @@ -104,8 +104,8 @@ {% if S_POST_REPORTED and not S_MCP_REPORT %}

    - {{ Icon('iconify', 'fa:exclamation', '', true, 'c-topic-reported-icon') }} - {L_TOPIC_REPORTED} {L_MESSAGE_REPORTED} + {{ Icon('iconify', 'fa:exclamation', lang('TOPIC_REPORTED'), true, 'c-topic-reported-icon') }} + {L_MESSAGE_REPORTED}

    {% endif %} @@ -340,13 +340,13 @@