makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/13713] Load all data for users in a single SQL query

Browse source 
PHPBB3-13713
This commit is contained in:
lavigor 2018-07-22 01:37:00 +03:00 • committed by Marc Alexander
parent 0269d53c5d
commit e874ce9898
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
1 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
phpBB/phpbb/mention/source/base_user.php
View file

@ -81,6 +81,8 @@ abstract class base_user implements source_interface
$result = $this->db->sql_query($this->query($keyword, $topic_id), 300); $result = $this->db->sql_query($this->query($keyword, $topic_id), 300);
$i = 0; $i = 0;
$users = [];
$user_ids = [];
while ($i < self::NAMES_BATCH_SIZE) while ($i < self::NAMES_BATCH_SIZE)
{ {
$row = $this->db->sql_fetchrow($result); $row = $this->db->sql_fetchrow($result);
@ -96,18 +98,26 @@ abstract class base_user implements source_interface
} }
$i++; $i++;
$users[] = $row;
$user_ids[] = $row['user_id'];
}
$user_rank = $this->user_loader->get_rank($row['user_id'], true); // Load all user data with a single SQL query, needed for ranks and avatars
$this->user_loader->load_users($user_ids);
foreach ($users as $user)
{
$user_rank = $this->user_loader->get_rank($user['user_id'], true);
array_push($names, [ array_push($names, [
'name' => $row['username'], 'name' => $user['username'],
'type' => 'u', 'type' => 'u',
'id' => $row['user_id'], 'id' => $user['user_id'],
'avatar' => [ 'avatar' => [
'type' => 'user', 'type' => 'user',
'img' => $this->user_loader->get_avatar($row['user_id'], true), 'img' => $this->user_loader->get_avatar($user['user_id'], true),
], ],
'rank' => (isset($user_rank['rank_title'])) ? $user_rank['rank_title'] : '', 'rank' => (isset($user_rank['rank_title'])) ? $user_rank['rank_title'] : '',
'priority' => $this->get_priority($row), 'priority' => $this->get_priority($user),
]); ]);
} }