makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11995] Remove exceptions and split reverse into different tests

Browse source 
PHPBB3-11995
This commit is contained in:
Joas Schilling 2013-11-02 19:26:45 +01:00
parent 414a4d587e
commit e8a3028ea6
1 changed files with 24 additions and 75 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

99
tests/dbal/migrator_tool_config_test.php
View file

@ -20,35 +20,24 @@ class phpbb_dbal_migrator_tool_config_test extends phpbb_test_case
public function test_add() public function test_add()
{ {
try $this->tool->add('foo', 'bar');
{ $this->assertEquals('bar', $this->config['foo']);
$this->tool->add('foo', 'bar'); }
}
catch (Exception $e) public function test_add_twice()
{ {
$this->fail($e); $this->tool->add('foo', 'bar');
}
$this->assertEquals('bar', $this->config['foo']); $this->assertEquals('bar', $this->config['foo']);
try $this->tool->add('foo', 'bar2');
{ $this->assertEquals('bar', $this->config['foo']);
$this->tool->add('foo', 'bar');
$this->fail('Exception not thrown');
}
catch (Exception $e) {}
} }
public function test_update() public function test_update()
{ {
$this->config->set('foo', 'bar'); $this->config->set('foo', 'bar');
try
{ $this->tool->update('foo', 'bar2');
$this->tool->update('foo', 'bar2');
}
catch (Exception $e)
{
$this->fail($e);
}
$this->assertEquals('bar2', $this->config['foo']); $this->assertEquals('bar2', $this->config['foo']);
} }
@ -56,24 +45,10 @@ class phpbb_dbal_migrator_tool_config_test extends phpbb_test_case
{ {
$this->config->set('foo', 'bar'); $this->config->set('foo', 'bar');
try $this->tool->update_if_equals('', 'foo', 'bar2');
{
$this->tool->update_if_equals('', 'foo', 'bar2');
}
catch (Exception $e)
{
$this->fail($e);
}
$this->assertEquals('bar', $this->config['foo']); $this->assertEquals('bar', $this->config['foo']);
try $this->tool->update_if_equals('bar', 'foo', 'bar2');
{
$this->tool->update_if_equals('bar', 'foo', 'bar2');
}
catch (Exception $e)
{
$this->fail($e);
}
$this->assertEquals('bar2', $this->config['foo']); $this->assertEquals('bar2', $this->config['foo']);
} }
@ -81,57 +56,31 @@ class phpbb_dbal_migrator_tool_config_test extends phpbb_test_case
{ {
$this->config->set('foo', 'bar'); $this->config->set('foo', 'bar');
try $this->tool->remove('foo');
{
$this->tool->remove('foo');
}
catch (Exception $e)
{
$this->fail($e);
}
$this->assertFalse(isset($this->config['foo'])); $this->assertFalse(isset($this->config['foo']));
} }
public function test_reverse() public function test_reverse_add()
{ {
// add
$this->config->set('foo', 'bar'); $this->config->set('foo', 'bar');
try $this->tool->reverse('add', 'foo');
{
$this->tool->reverse('add', 'foo');
}
catch (Exception $e)
{
$this->fail($e);
}
$this->assertFalse(isset($this->config['foo'])); $this->assertFalse(isset($this->config['foo']));
}
// remove public function test_reverse_remove()
{
$this->config->delete('foo'); $this->config->delete('foo');
try $this->tool->reverse('remove', 'foo');
{
$this->tool->reverse('remove', 'foo');
}
catch (Exception $e)
{
$this->fail($e);
}
$this->assertTrue(isset($this->config['foo']));
$this->assertEquals('', $this->config['foo']); $this->assertEquals('', $this->config['foo']);
}
// update_if_equals public function test_reverse_update_if_equals()
{
$this->config->set('foo', 'bar'); $this->config->set('foo', 'bar');
try $this->tool->reverse('update_if_equals', 'test', 'foo', 'bar');
{
$this->tool->reverse('update_if_equals', 'test', 'foo', 'bar');
}
catch (Exception $e)
{
$this->fail($e);
}
$this->assertEquals('test', $this->config['foo']); $this->assertEquals('test', $this->config['foo']);
} }
} }