[feature/avatars] Improve testing to also check for enabled drivers

PHPBB3-10018
This commit is contained in:
Marc Alexander 2012-12-27 20:39:02 +01:00
parent c9338b38b3
commit ea6bf00977

View file

@ -31,6 +31,7 @@ class phpbb_avatar_manager_test extends PHPUnit_Framework_TestCase
->method('get_name') ->method('get_name')
->will($this->returnValue('avatar.driver.foobar')); ->will($this->returnValue('avatar.driver.foobar'));
$avatar_drivers = array($this->avatar_foobar); $avatar_drivers = array($this->avatar_foobar);
$config['allow_avatar_' . get_class($this->avatar_foobar)] = true;
// Set up avatar manager // Set up avatar manager
$this->manager = new phpbb_avatar_manager($config, $avatar_drivers, $this->phpbb_container); $this->manager = new phpbb_avatar_manager($config, $avatar_drivers, $this->phpbb_container);
@ -45,14 +46,24 @@ class phpbb_avatar_manager_test extends PHPUnit_Framework_TestCase
$this->assertNull($driver); $this->assertNull($driver);
$driver = $this->manager->get_driver('avatar.driver.foobar'); $driver = $this->manager->get_driver('avatar.driver.foobar');
$this->assertEquals('avatar.driver.foobar', $driver);
$driver = $this->manager->get_driver('avatar.driver.foo_wrong');
$this->assertNull($driver); $this->assertNull($driver);
} }
public function test_get_valid_drivers() public function test_get_all_drivers()
{ {
$valid_drivers = $this->manager->get_all_drivers(); $drivers = $this->manager->get_all_drivers();
$this->assertArrayHasKey('avatar.driver.foobar', $valid_drivers); $this->assertArrayHasKey('avatar.driver.foobar', $drivers);
$this->assertEquals('avatar.driver.foobar', $valid_drivers['avatar.driver.foobar']); $this->assertEquals('avatar.driver.foobar', $drivers['avatar.driver.foobar']);
}
public function test_get_enabled_drivers()
{
$drivers = $this->manager->get_enabled_drivers();
$this->assertArrayHasKey('avatar.driver.foobar', $drivers);
$this->assertEquals('avatar.driver.foobar', $drivers['avatar.driver.foobar']);
} }
public function test_get_avatar_settings() public function test_get_avatar_settings()