makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-12 14:28:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/8996] Also fix the BBCode bug in subsilver2 and acp

Browse source
This commit is contained in:
Joas Schilling 2011-11-12 14:59:11 +01:00
parent 219bdbaf70
commit eb1f15bc8b
3 changed files with 117 additions and 108 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

68
phpBB/adm/style/editor.js
View file

@ -28,8 +28,8 @@ function helpline(help)
/** /**
* Fix a bug involving the TextRange object. From * Fix a bug involving the TextRange object. From
* http://www.frostjedi.com/terra/scripts/demo/caretBug.html * http://www.frostjedi.com/terra/scripts/demo/caretBug.html
*/ */
function initInsertions() function initInsertions()
{ {
var doc; var doc;
if(document.forms[form_name]) if(document.forms[form_name])
@ -66,7 +66,7 @@ function bbstyle(bbnumber)
else else
{ {
insert_text('[*]'); insert_text('[*]');
document.forms[form_name].elements[text_name].focus(); document.forms[form_name].elements[text_name].focus();
} }
} }
@ -76,7 +76,7 @@ function bbstyle(bbnumber)
function bbfontstyle(bbopen, bbclose) function bbfontstyle(bbopen, bbclose)
{ {
theSelection = false; theSelection = false;
var textarea = document.forms[form_name].elements[text_name]; var textarea = document.forms[form_name].elements[text_name];
textarea.focus(); textarea.focus();
@ -84,14 +84,10 @@ function bbfontstyle(bbopen, bbclose)
if ((clientVer >= 4) && is_ie && is_win) if ((clientVer >= 4) && is_ie && is_win)
{ {
// Get text selection // Get text selection
theSelection = document.selection.createRange().text; if (textarea.createTextRange && textarea.caretPos)
if (theSelection)
{ {
// Add tags around selection textarea.caretPos.text = bbopen + textarea.caretPos.text + bbclose;
document.selection.createRange().text = bbopen + theSelection + bbclose; textarea.focus();
document.forms[form_name].elements[text_name].focus();
theSelection = '';
return; return;
} }
} }
@ -102,10 +98,10 @@ function bbfontstyle(bbopen, bbclose)
theSelection = ''; theSelection = '';
return; return;
} }
//The new position for the cursor after adding the bbcode //The new position for the cursor after adding the bbcode
var caret_pos = getCaretPosition(textarea).start; var caret_pos = getCaretPosition(textarea).start;
var new_pos = caret_pos + bbopen.length; var new_pos = caret_pos + bbopen.length;
// Open tag // Open tag
insert_text(bbopen + bbclose); insert_text(bbopen + bbclose);
@ -116,12 +112,12 @@ function bbfontstyle(bbopen, bbclose)
{ {
textarea.selectionStart = new_pos; textarea.selectionStart = new_pos;
textarea.selectionEnd = new_pos; textarea.selectionEnd = new_pos;
} }
// IE // IE
else if (document.selection) else if (document.selection)
{ {
var range = textarea.createTextRange(); var range = textarea.createTextRange();
range.move("character", new_pos); range.move("character", bbopen.length);
range.select(); range.select();
storeCaret(textarea); storeCaret(textarea);
} }
@ -136,7 +132,7 @@ function bbfontstyle(bbopen, bbclose)
function insert_text(text, spaces, popup) function insert_text(text, spaces, popup)
{ {
var textarea; var textarea;
if (!popup) if (!popup)
{ {
textarea = document.forms[form_name].elements[text_name]; textarea = document.forms[form_name].elements[text_name];
@ -159,18 +155,18 @@ function insert_text(text, spaces, popup)
mozWrap(textarea, text, ''); mozWrap(textarea, text, '');
textarea.selectionStart = sel_start + text.length; textarea.selectionStart = sel_start + text.length;
textarea.selectionEnd = sel_end + text.length; textarea.selectionEnd = sel_end + text.length;
} }
else if (textarea.createTextRange && textarea.caretPos) else if (textarea.createTextRange && textarea.caretPos)
{ {
if (baseHeight != textarea.caretPos.boundingHeight) if (baseHeight != textarea.caretPos.boundingHeight)
{ {
textarea.focus(); textarea.focus();
storeCaret(textarea); storeCaret(textarea);
} }
var caret_pos = textarea.caretPos; var caret_pos = textarea.caretPos;
caret_pos.text = caret_pos.text.charAt(caret_pos.text.length - 1) == ' ' ? caret_pos.text + text + ' ' : caret_pos.text + text; caret_pos.text = caret_pos.text.charAt(caret_pos.text.length - 1) == ' ' ? caret_pos.text + text + ' ' : caret_pos.text + text;
} }
else else
{ {
@ -233,7 +229,7 @@ function addquote(post_id, username)
theSelection = theSelection.replace(/<br\/>/ig, '\n'); theSelection = theSelection.replace(/<br\/>/ig, '\n');
theSelection = theSelection.replace(/&lt\;/ig, '<'); theSelection = theSelection.replace(/&lt\;/ig, '<');
theSelection = theSelection.replace(/&gt\;/ig, '>'); theSelection = theSelection.replace(/&gt\;/ig, '>');
theSelection = theSelection.replace(/&amp\;/ig, '&'); theSelection = theSelection.replace(/&amp\;/ig, '&');
theSelection = theSelection.replace(/&nbsp\;/ig, ' '); theSelection = theSelection.replace(/&nbsp\;/ig, ' ');
} }
else if (document.all) else if (document.all)
@ -268,7 +264,7 @@ function mozWrap(txtarea, open, close)
var selEnd = txtarea.selectionEnd; var selEnd = txtarea.selectionEnd;
var scrollTop = txtarea.scrollTop; var scrollTop = txtarea.scrollTop;
if (selEnd == 1 || selEnd == 2) if (selEnd == 1 || selEnd == 2)
{ {
selEnd = selLength; selEnd = selLength;
} }
@ -292,7 +288,17 @@ function mozWrap(txtarea, open, close)
*/ */
function storeCaret(textEl) function storeCaret(textEl)
{ {
if (textEl.createTextRange) var keyCode = false;
if (is_ie)
{
keyCode = (event.keyCode) ? event.keyCode : event.charCode;
}
// Did the user press Shift (16), Ctrl (17) or Alt (18)?
// If so, we do not update the caretPos, so BBCodes can still be applied correctly.
var is_control_key = (keyCode == 16 || keyCode == 17 || keyCode == 18);
if ((!is_ie || !is_control_key) && (textEl.createTextRange))
{ {
textEl.caretPos = document.selection.createRange().duplicate(); textEl.caretPos = document.selection.createRange().duplicate();
} }
@ -328,7 +334,7 @@ function colorPalette(dir, width, height)
{ {
document.writeln('<tr>'); document.writeln('<tr>');
} }
for (b = 0; b < 5; b++) for (b = 0; b < 5; b++)
{ {
color = String(numberList[r]) + String(numberList[g]) + String(numberList[b]); color = String(numberList[r]) + String(numberList[g]) + String(numberList[b]);
@ -368,9 +374,9 @@ function caretPosition()
function getCaretPosition(txtarea) function getCaretPosition(txtarea)
{ {
var caretPos = new caretPosition(); var caretPos = new caretPosition();
// simple Gecko/Opera way // simple Gecko/Opera way
if (txtarea.selectionStart || txtarea.selectionStart == 0) if (!is_ie && (txtarea.selectionStart || txtarea.selectionStart == 0))
{ {
caretPos.start = txtarea.selectionStart; caretPos.start = txtarea.selectionStart;
caretPos.end = txtarea.selectionEnd; caretPos.end = txtarea.selectionEnd;
@ -384,19 +390,19 @@ function getCaretPosition(txtarea)
// a new selection of the whole textarea // a new selection of the whole textarea
var range_all = document.body.createTextRange(); var range_all = document.body.createTextRange();
range_all.moveToElementText(txtarea); range_all.moveToElementText(txtarea);
// calculate selection start point by moving beginning of range_all to beginning of range // calculate selection start point by moving beginning of range_all to beginning of range
var sel_start; var sel_start;
for (sel_start = 0; range_all.compareEndPoints('StartToStart', range) < 0; sel_start++) for (sel_start = 0; range_all.compareEndPoints('StartToStart', range) < 0; sel_start++)
{ {
range_all.moveStart('character', 1); range_all.moveStart('character', 1);
} }
txtarea.sel_start = sel_start; txtarea.sel_start = sel_start;
// we ignore the end value for IE, this is already dirty enough and we don't need it // we ignore the end value for IE, this is already dirty enough and we don't need it
caretPos.start = txtarea.sel_start; caretPos.start = txtarea.sel_start;
caretPos.end = txtarea.sel_start; caretPos.end = txtarea.sel_start;
} }
return caretPos; return caretPos;

61
phpBB/styles/prosilver/template/editor.js
View file

@ -28,8 +28,8 @@ function helpline(help)
/** /**
* Fix a bug involving the TextRange object. From * Fix a bug involving the TextRange object. From
* http://www.frostjedi.com/terra/scripts/demo/caretBug.html * http://www.frostjedi.com/terra/scripts/demo/caretBug.html
*/ */
function initInsertions() function initInsertions()
{ {
var doc; var doc;
@ -37,7 +37,7 @@ function initInsertions()
{ {
doc = document; doc = document;
} }
else else
{ {
doc = opener.document; doc = opener.document;
} }
@ -60,12 +60,12 @@ function initInsertions()
* bbstyle * bbstyle
*/ */
function bbstyle(bbnumber) function bbstyle(bbnumber)
{ {
if (bbnumber != -1) if (bbnumber != -1)
{ {
bbfontstyle(bbtags[bbnumber], bbtags[bbnumber+1]); bbfontstyle(bbtags[bbnumber], bbtags[bbnumber+1]);
} }
else else
{ {
insert_text('[*]'); insert_text('[*]');
document.forms[form_name].elements[text_name].focus(); document.forms[form_name].elements[text_name].focus();
@ -86,10 +86,10 @@ function bbfontstyle(bbopen, bbclose)
if ((clientVer >= 4) && is_ie && is_win) if ((clientVer >= 4) && is_ie && is_win)
{ {
// Get text selection // Get text selection
textarea = document.forms[form_name].elements[text_name];
if (textarea.createTextRange && textarea.caretPos) if (textarea.createTextRange && textarea.caretPos)
{ {
textarea.caretPos.text = bbopen + textarea.caretPos.text + bbclose; textarea.caretPos.text = bbopen + textarea.caretPos.text + bbclose;
textarea.focus();
return; return;
} }
} }
@ -100,7 +100,7 @@ function bbfontstyle(bbopen, bbclose)
theSelection = ''; theSelection = '';
return; return;
} }
//The new position for the cursor after adding the bbcode //The new position for the cursor after adding the bbcode
var caret_pos = getCaretPosition(textarea).start; var caret_pos = getCaretPosition(textarea).start;
var new_pos = caret_pos + bbopen.length; var new_pos = caret_pos + bbopen.length;
@ -114,12 +114,12 @@ function bbfontstyle(bbopen, bbclose)
{ {
textarea.selectionStart = new_pos; textarea.selectionStart = new_pos;
textarea.selectionEnd = new_pos; textarea.selectionEnd = new_pos;
} }
// IE // IE
else if (document.selection) else if (document.selection)
{ {
var range = textarea.createTextRange(); var range = textarea.createTextRange();
range.move("character", new_pos); range.move("character", new_pos);
range.select(); range.select();
storeCaret(textarea); storeCaret(textarea);
} }
@ -134,16 +134,16 @@ function bbfontstyle(bbopen, bbclose)
function insert_text(text, spaces, popup) function insert_text(text, spaces, popup)
{ {
var textarea; var textarea;
if (!popup) if (!popup)
{ {
textarea = document.forms[form_name].elements[text_name]; textarea = document.forms[form_name].elements[text_name];
} }
else else
{ {
textarea = opener.document.forms[form_name].elements[text_name]; textarea = opener.document.forms[form_name].elements[text_name];
} }
if (spaces) if (spaces)
{ {
text = ' ' + text + ' '; text = ' ' + text + ' ';
} }
@ -161,7 +161,7 @@ function insert_text(text, spaces, popup)
} }
else if (textarea.createTextRange && textarea.caretPos) else if (textarea.createTextRange && textarea.caretPos)
{ {
if (baseHeight != textarea.caretPos.boundingHeight) if (baseHeight != textarea.caretPos.boundingHeight)
{ {
textarea.focus(); textarea.focus();
storeCaret(textarea); storeCaret(textarea);
@ -174,7 +174,7 @@ function insert_text(text, spaces, popup)
{ {
textarea.value = textarea.value + text; textarea.value = textarea.value + text;
} }
if (!popup) if (!popup)
{ {
textarea.focus(); textarea.focus();
} }
@ -291,7 +291,7 @@ function split_lines(text)
do do
{ {
var splitAt = line.indexOf(' ', 80); var splitAt = line.indexOf(' ', 80);
if (splitAt == -1) if (splitAt == -1)
{ {
splitLines[j] = line; splitLines[j] = line;
@ -319,7 +319,7 @@ function mozWrap(txtarea, open, close)
var selEnd = txtarea.selectionEnd; var selEnd = txtarea.selectionEnd;
var scrollTop = txtarea.scrollTop; var scrollTop = txtarea.scrollTop;
if (selEnd == 1 || selEnd == 2) if (selEnd == 1 || selEnd == 2)
{ {
selEnd = selLength; selEnd = selLength;
} }
@ -351,7 +351,9 @@ function storeCaret(textEl)
// Did the user press Shift (16), Ctrl (17) or Alt (18)? // Did the user press Shift (16), Ctrl (17) or Alt (18)?
// If so, we do not update the caretPos, so BBCodes can still be applied correctly. // If so, we do not update the caretPos, so BBCodes can still be applied correctly.
if ((!is_ie || (keyCode != 16 && keyCode != 17 && keyCode != 18)) && (textEl.createTextRange)) var is_control_key = (keyCode == 16 || keyCode == 17 || keyCode == 18);
if ((!is_ie || !is_control_key) && (textEl.createTextRange))
{ {
textEl.caretPos = document.selection.createRange().duplicate(); textEl.caretPos = document.selection.createRange().duplicate();
} }
@ -387,7 +389,7 @@ function colorPalette(dir, width, height)
{ {
document.writeln('<tr>'); document.writeln('<tr>');
} }
for (b = 0; b < 5; b++) for (b = 0; b < 5; b++)
{ {
color = String(numberList[r]) + String(numberList[g]) + String(numberList[b]); color = String(numberList[r]) + String(numberList[g]) + String(numberList[b]);
@ -427,33 +429,32 @@ function caretPosition()
function getCaretPosition(txtarea) function getCaretPosition(txtarea)
{ {
var caretPos = new caretPosition(); var caretPos = new caretPosition();
// simple Gecko/Opera way // simple Gecko/Opera way
if(!is_ie && (txtarea.selectionStart || txtarea.selectionStart == 0)) if (!is_ie && (txtarea.selectionStart || txtarea.selectionStart == 0))
{ {
caretPos.start = txtarea.selectionStart; caretPos.start = txtarea.selectionStart;
caretPos.end = txtarea.selectionEnd; caretPos.end = txtarea.selectionEnd;
} }
// dirty and slow IE way // dirty and slow IE way
else if(document.selection) else if (document.selection)
{ {
// get current selection // get current selection
var range = document.selection.createRange(); var range = document.selection.createRange();
// a new selection of the whole textarea // a new selection of the whole textarea
var range_all = document.body.createTextRange(); var range_all = document.body.createTextRange();
range_all.moveToElementText(txtarea); range_all.moveToElementText(txtarea);
// calculate selection start point by moving beginning of range_all to beginning of range // calculate selection start point by moving beginning of range_all to beginning of range
var sel_start; var sel_start;
for (sel_start = 0; range_all.compareEndPoints('StartToStart', range) < 0; sel_start++) for (sel_start = 0; range_all.compareEndPoints('StartToStart', range) < 0; sel_start++)
{ {
range_all.moveStart('character', 1); range_all.moveStart('character', 1);
} }
txtarea.sel_start = sel_start; txtarea.sel_start = sel_start;
// we ignore the end value for IE, this is already dirty enough and we don't need it // we ignore the end value for IE, this is already dirty enough and we don't need it
caretPos.start = txtarea.sel_start; caretPos.start = txtarea.sel_start;
caretPos.end = txtarea.sel_start; caretPos.end = txtarea.sel_start;

96
phpBB/styles/subsilver2/template/editor.js
View file

@ -6,8 +6,8 @@
// Startup variables // Startup variables
var imageTag = false; var imageTag = false;
var theSelection = false; var theSelection = false;
var bbcodeEnabled = true;
var bbcodeEnabled = true;
// Check for Browser & Platform for PC & IE specific bits // Check for Browser & Platform for PC & IE specific bits
// More details from: http://www.mozilla.org/docs/web-developer/sniffer/browser_type.html // More details from: http://www.mozilla.org/docs/web-developer/sniffer/browser_type.html
var clientPC = navigator.userAgent.toLowerCase(); // Get client info var clientPC = navigator.userAgent.toLowerCase(); // Get client info
@ -15,7 +15,6 @@ var clientVer = parseInt(navigator.appVersion); // Get browser version
var is_ie = ((clientPC.indexOf('msie') != -1) && (clientPC.indexOf('opera') == -1)); var is_ie = ((clientPC.indexOf('msie') != -1) && (clientPC.indexOf('opera') == -1));
var is_win = ((clientPC.indexOf('win') != -1) || (clientPC.indexOf('16bit') != -1)); var is_win = ((clientPC.indexOf('win') != -1) || (clientPC.indexOf('16bit') != -1));
var baseHeight; var baseHeight;
/** /**
@ -29,8 +28,8 @@ function helpline(help)
/** /**
* Fix a bug involving the TextRange object. From * Fix a bug involving the TextRange object. From
* http://www.frostjedi.com/terra/scripts/demo/caretBug.html * http://www.frostjedi.com/terra/scripts/demo/caretBug.html
*/ */
function initInsertions() function initInsertions()
{ {
var doc; var doc;
@ -38,14 +37,15 @@ function initInsertions()
{ {
doc = document; doc = document;
} }
else else
{ {
doc = opener.document; doc = opener.document;
} }
var textarea = doc.forms[form_name].elements[text_name]; var textarea = doc.forms[form_name].elements[text_name];
if (is_ie && typeof(baseHeight) != 'number') if (is_ie && typeof(baseHeight) != 'number')
{ {
textarea.focus(); textarea.focus();
baseHeight = doc.selection.createRange().duplicate().boundingHeight; baseHeight = doc.selection.createRange().duplicate().boundingHeight;
@ -60,12 +60,12 @@ function initInsertions()
* bbstyle * bbstyle
*/ */
function bbstyle(bbnumber) function bbstyle(bbnumber)
{ {
if (bbnumber != -1) if (bbnumber != -1)
{ {
bbfontstyle(bbtags[bbnumber], bbtags[bbnumber+1]); bbfontstyle(bbtags[bbnumber], bbtags[bbnumber+1]);
} }
else else
{ {
insert_text('[*]'); insert_text('[*]');
document.forms[form_name].elements[text_name].focus(); document.forms[form_name].elements[text_name].focus();
@ -78,7 +78,7 @@ function bbstyle(bbnumber)
function bbfontstyle(bbopen, bbclose) function bbfontstyle(bbopen, bbclose)
{ {
theSelection = false; theSelection = false;
var textarea = document.forms[form_name].elements[text_name]; var textarea = document.forms[form_name].elements[text_name];
textarea.focus(); textarea.focus();
@ -86,14 +86,10 @@ function bbfontstyle(bbopen, bbclose)
if ((clientVer >= 4) && is_ie && is_win) if ((clientVer >= 4) && is_ie && is_win)
{ {
// Get text selection // Get text selection
theSelection = document.selection.createRange().text; if (textarea.createTextRange && textarea.caretPos)
if (theSelection)
{ {
// Add tags around selection textarea.caretPos.text = bbopen + textarea.caretPos.text + bbclose;
document.selection.createRange().text = bbopen + theSelection + bbclose; textarea.focus();
document.forms[form_name].elements[text_name].focus();
theSelection = '';
return; return;
} }
} }
@ -104,7 +100,7 @@ function bbfontstyle(bbopen, bbclose)
theSelection = ''; theSelection = '';
return; return;
} }
//The new position for the cursor after adding the bbcode //The new position for the cursor after adding the bbcode
var caret_pos = getCaretPosition(textarea).start; var caret_pos = getCaretPosition(textarea).start;
var new_pos = caret_pos + bbopen.length; var new_pos = caret_pos + bbopen.length;
@ -118,12 +114,12 @@ function bbfontstyle(bbopen, bbclose)
{ {
textarea.selectionStart = new_pos; textarea.selectionStart = new_pos;
textarea.selectionEnd = new_pos; textarea.selectionEnd = new_pos;
} }
// IE // IE
else if (document.selection) else if (document.selection)
{ {
var range = textarea.createTextRange(); var range = textarea.createTextRange();
range.move("character", new_pos); range.move("character", new_pos);
range.select(); range.select();
storeCaret(textarea); storeCaret(textarea);
} }
@ -138,16 +134,16 @@ function bbfontstyle(bbopen, bbclose)
function insert_text(text, spaces, popup) function insert_text(text, spaces, popup)
{ {
var textarea; var textarea;
if (!popup) if (!popup)
{ {
textarea = document.forms[form_name].elements[text_name]; textarea = document.forms[form_name].elements[text_name];
} }
else else
{ {
textarea = opener.document.forms[form_name].elements[text_name]; textarea = opener.document.forms[form_name].elements[text_name];
} }
if (spaces) if (spaces)
{ {
text = ' ' + text + ' '; text = ' ' + text + ' ';
} }
@ -162,28 +158,26 @@ function insert_text(text, spaces, popup)
mozWrap(textarea, text, ''); mozWrap(textarea, text, '');
textarea.selectionStart = sel_start + text.length; textarea.selectionStart = sel_start + text.length;
textarea.selectionEnd = sel_end + text.length; textarea.selectionEnd = sel_end + text.length;
} }
else if (textarea.createTextRange && textarea.caretPos) else if (textarea.createTextRange && textarea.caretPos)
{ {
if (baseHeight != textarea.caretPos.boundingHeight) if (baseHeight != textarea.caretPos.boundingHeight)
{ {
textarea.focus(); textarea.focus();
storeCaret(textarea); storeCaret(textarea);
} }
var caret_pos = textarea.caretPos; var caret_pos = textarea.caretPos;
caret_pos.text = caret_pos.text.charAt(caret_pos.text.length - 1) == ' ' ? caret_pos.text + text + ' ' : caret_pos.text + text; caret_pos.text = caret_pos.text.charAt(caret_pos.text.length - 1) == ' ' ? caret_pos.text + text + ' ' : caret_pos.text + text;
} }
else else
{ {
textarea.value = textarea.value + text; textarea.value = textarea.value + text;
} }
if (!popup) if (!popup)
{ {
textarea.focus(); textarea.focus();
} }
} }
/** /**
@ -279,7 +273,6 @@ function addquote(post_id, username, l_wrote)
return; return;
} }
function split_lines(text) function split_lines(text)
{ {
var lines = text.split('\n'); var lines = text.split('\n');
@ -298,7 +291,7 @@ function split_lines(text)
do do
{ {
var splitAt = line.indexOf(' ', 80); var splitAt = line.indexOf(' ', 80);
if (splitAt == -1) if (splitAt == -1)
{ {
splitLines[j] = line; splitLines[j] = line;
@ -316,7 +309,6 @@ function split_lines(text)
} }
return splitLines; return splitLines;
} }
/** /**
* From http://www.massless.org/mozedit/ * From http://www.massless.org/mozedit/
*/ */
@ -327,7 +319,7 @@ function mozWrap(txtarea, open, close)
var selEnd = txtarea.selectionEnd; var selEnd = txtarea.selectionEnd;
var scrollTop = txtarea.scrollTop; var scrollTop = txtarea.scrollTop;
if (selEnd == 1 || selEnd == 2) if (selEnd == 1 || selEnd == 2)
{ {
selEnd = selLength; selEnd = selLength;
} }
@ -351,7 +343,17 @@ function mozWrap(txtarea, open, close)
*/ */
function storeCaret(textEl) function storeCaret(textEl)
{ {
if (textEl.createTextRange) var keyCode = false;
if (is_ie)
{
keyCode = (event.keyCode) ? event.keyCode : event.charCode;
}
// Did the user press Shift (16), Ctrl (17) or Alt (18)?
// If so, we do not update the caretPos, so BBCodes can still be applied correctly.
var is_control_key = (keyCode == 16 || keyCode == 17 || keyCode == 18);
if ((!is_ie || !is_control_key) && (textEl.createTextRange))
{ {
textEl.caretPos = document.selection.createRange().duplicate(); textEl.caretPos = document.selection.createRange().duplicate();
} }
@ -387,7 +389,7 @@ function colorPalette(dir, width, height)
{ {
document.writeln('<tr>'); document.writeln('<tr>');
} }
for (b = 0; b < 5; b++) for (b = 0; b < 5; b++)
{ {
color = String(numberList[r]) + String(numberList[g]) + String(numberList[b]); color = String(numberList[r]) + String(numberList[g]) + String(numberList[b]);
@ -427,15 +429,15 @@ function caretPosition()
function getCaretPosition(txtarea) function getCaretPosition(txtarea)
{ {
var caretPos = new caretPosition(); var caretPos = new caretPosition();
// simple Gecko/Opera way // simple Gecko/Opera way
if(txtarea.selectionStart || txtarea.selectionStart == 0) if (!is_ie && (txtarea.selectionStart || txtarea.selectionStart == 0))
{ {
caretPos.start = txtarea.selectionStart; caretPos.start = txtarea.selectionStart;
caretPos.end = txtarea.selectionEnd; caretPos.end = txtarea.selectionEnd;
} }
// dirty and slow IE way // dirty and slow IE way
else if(document.selection) else if (document.selection)
{ {
// get current selection // get current selection
var range = document.selection.createRange(); var range = document.selection.createRange();
@ -443,16 +445,16 @@ function getCaretPosition(txtarea)
// a new selection of the whole textarea // a new selection of the whole textarea
var range_all = document.body.createTextRange(); var range_all = document.body.createTextRange();
range_all.moveToElementText(txtarea); range_all.moveToElementText(txtarea);
// calculate selection start point by moving beginning of range_all to beginning of range // calculate selection start point by moving beginning of range_all to beginning of range
var sel_start; var sel_start;
for (sel_start = 0; range_all.compareEndPoints('StartToStart', range) < 0; sel_start++) for (sel_start = 0; range_all.compareEndPoints('StartToStart', range) < 0; sel_start++)
{ {
range_all.moveStart('character', 1); range_all.moveStart('character', 1);
} }
txtarea.sel_start = sel_start; txtarea.sel_start = sel_start;
// we ignore the end value for IE, this is already dirty enough and we don't need it // we ignore the end value for IE, this is already dirty enough and we don't need it
caretPos.start = txtarea.sel_start; caretPos.start = txtarea.sel_start;
caretPos.end = txtarea.sel_start; caretPos.end = txtarea.sel_start;