diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html
index a77f543d67..c603aad7e6 100644
--- a/phpBB/docs/CHANGELOG.html
+++ b/phpBB/docs/CHANGELOG.html
@@ -85,7 +85,6 @@ p,ul,td {font-size:10pt;}
[Fix] incorrect handling of move stubs (Bug #179)
[Fix] wrong mode_type in memberlist (Bug #187)
[Fix] removed unused variable from topic_notify email template (Bug #210)
-[Fix] invalid HTML in overall_header.tpl when user is logged in (Bug #211)
[Fix] removed unset variable from smilies popup window title (Bug #224)
[Fix] removed duplicate template assignment from admin_board.php (Bug #226)
[Fix] incorrect search link for guest posts in modcp.php (Bug #254)
@@ -95,6 +94,8 @@ p,ul,td {font-size:10pt;}
[Fix] fixed "var-by-ref" errors (Bug #322)
[Fix] changed redirection to installation (Bug #325)
[Fix] added timout of 10 seconds to version check (Bug #348)
+[Fix] multiple minor HTML issues with subSilver
+[Change] Deprecated the use of some PHP 3 compatability functions in favour of the native equivalents
l.ii. Changes since 2.0.16
diff --git a/phpBB/includes/bbcode.php b/phpBB/includes/bbcode.php
index 8f773de485..f8ba2720e3 100644
--- a/phpBB/includes/bbcode.php
+++ b/phpBB/includes/bbcode.php
@@ -432,7 +432,7 @@ function bbencode_first_pass_pda($text, $uid, $open_tag, $close_tag, $close_tag_
// We have an opening tag.
// Push its position, the text we matched, and its index in the open_tag array on to the stack, and then keep going to the right.
$match = array("pos" => $curr_pos, "tag" => $which_start_tag, "index" => $start_tag_index);
- bbcode_array_push($stack, $match);
+ array_push($stack, $match);
//
// Rather than just increment $curr_pos
// Set it to the ending of the tag we just found
@@ -454,7 +454,7 @@ function bbencode_first_pass_pda($text, $uid, $open_tag, $close_tag, $close_tag_
// There exists a starting tag.
$curr_nesting_depth = sizeof($stack);
// We need to do 2 replacements now.
- $match = bbcode_array_pop($stack);
+ $match = array_pop($stack);
$start_index = $match['pos'];
$start_tag = $match['tag'];
$start_length = strlen($start_tag);
@@ -520,7 +520,7 @@ function bbencode_first_pass_pda($text, $uid, $open_tag, $close_tag, $close_tag_
// otherwise, we go back to the start.
if (sizeof($stack) > 0)
{
- $match = bbcode_array_pop($stack);
+ $match = array_pop($stack);
$curr_pos = $match['pos'];
// bbcode_array_push($stack, $match);
// ++$curr_pos;
@@ -700,6 +700,7 @@ function escape_slashes($input)
* This function does exactly what the PHP4 function array_push() does
* however, to keep phpBB compatable with PHP 3 we had to come up with our own
* method of doing it.
+ * This function was deprecated in phpBB 2.0.18
*/
function bbcode_array_push(&$stack, $value)
{
@@ -711,6 +712,7 @@ function bbcode_array_push(&$stack, $value)
* This function does exactly what the PHP4 function array_pop() does
* however, to keep phpBB compatable with PHP 3 we had to come up with our own
* method of doing it.
+ * This function was deprecated in phpBB 2.0.18
*/
function bbcode_array_pop(&$stack)
{
@@ -761,7 +763,7 @@ function smilies_pass($message)
for ($i = 0; $i < count($smilies); $i++)
{
- $orig[] = "/(?<=.\W|\W.|^\W)" . phpbb_preg_quote($smilies[$i]['code'], "/") . "(?=.\W|\W.|\W$)/";
+ $orig[] = "/(?<=.\W|\W.|^\W)" . preg_quote($smilies[$i]['code'], "/") . "(?=.\W|\W.|\W$)/";
$repl[] = '
';
}
}
diff --git a/phpBB/includes/emailer.php b/phpBB/includes/emailer.php
index 5220562a41..1b735d65e7 100755
--- a/phpBB/includes/emailer.php
+++ b/phpBB/includes/emailer.php
@@ -164,7 +164,7 @@ class emailer
if (preg_match('#^(Subject:(.*?))$#m', $this->msg, $match))
{
$this->subject = (trim($match[2]) != '') ? trim($match[2]) : (($this->subject != '') ? $this->subject : 'No Subject');
- $drop_header .= '[\r\n]*?' . phpbb_preg_quote($match[1], '#');
+ $drop_header .= '[\r\n]*?' . preg_quote($match[1], '#');
}
else
{
@@ -174,7 +174,7 @@ class emailer
if (preg_match('#^(Charset:(.*?))$#m', $this->msg, $match))
{
$this->encoding = (trim($match[2]) != '') ? trim($match[2]) : trim($lang['ENCODING']);
- $drop_header .= '[\r\n]*?' . phpbb_preg_quote($match[1], '#');
+ $drop_header .= '[\r\n]*?' . preg_quote($match[1], '#');
}
else
{
@@ -261,7 +261,7 @@ class emailer
$str = chunk_split(base64_encode($str), $length, $spacer);
// remove trailing spacer and add start and end delimiters
- $str = preg_replace('#' . phpbb_preg_quote($spacer, '#') . '$#', '', $str);
+ $str = preg_replace('#' . preg_quote($spacer, '#') . '$#', '', $str);
return $start . $str . $end;
}
diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php
index 54c3a7bc7d..38b3f38fc4 100644
--- a/phpBB/includes/functions.php
+++ b/phpBB/includes/functions.php
@@ -539,7 +539,7 @@ function obtain_word_list(&$orig_word, &$replacement_word)
{
do
{
- $orig_word[] = '#\b(' . str_replace('\*', '\w*?', phpbb_preg_quote($row['word'], '#')) . ')\b#i';
+ $orig_word[] = '#\b(' . str_replace('\*', '\w*?', preg_quote($row['word'], '#')) . ')\b#i';
$replacement_word[] = $row['replacement'];
}
while ( $row = $db->sql_fetchrow($result) );
diff --git a/phpBB/includes/functions_validate.php b/phpBB/includes/functions_validate.php
index d6d950bfbb..3f8a23b699 100644
--- a/phpBB/includes/functions_validate.php
+++ b/phpBB/includes/functions_validate.php
@@ -70,7 +70,7 @@ function validate_username($username)
{
do
{
- if (preg_match("#\b(" . str_replace("\*", ".*?", phpbb_preg_quote($row['disallow_username'], '#')) . ")\b#i", $username))
+ if (preg_match("#\b(" . str_replace("\*", ".*?", preg_quote($row['disallow_username'], '#')) . ")\b#i", $username))
{
$db->sql_freeresult($result);
return array('error' => true, 'error_msg' => $lang['Username_disallowed']);
@@ -89,7 +89,7 @@ function validate_username($username)
{
do
{
- if (preg_match("#\b(" . str_replace("\*", ".*?", phpbb_preg_quote($row['word'], '#')) . ")\b#i", $username))
+ if (preg_match("#\b(" . str_replace("\*", ".*?", preg_quote($row['word'], '#')) . ")\b#i", $username))
{
$db->sql_freeresult($result);
return array('error' => true, 'error_msg' => $lang['Username_disallowed']);
diff --git a/phpBB/viewtopic.php b/phpBB/viewtopic.php
index 1597b4a438..344a475478 100644
--- a/phpBB/viewtopic.php
+++ b/phpBB/viewtopic.php
@@ -490,7 +490,7 @@ if (isset($HTTP_GET_VARS['highlight']))
{
if (trim($words[$i]) != '')
{
- $highlight_match .= (($highlight_match != '') ? '|' : '') . str_replace('*', '\w*', phpbb_preg_quote($words[$i], '#'));
+ $highlight_match .= (($highlight_match != '') ? '|' : '') . str_replace('*', '\w*', preg_quote($words[$i], '#'));
}
}
unset($words);