From ecebaef5b6eb86bbc14a9aea593c96f11a7a1826 Mon Sep 17 00:00:00 2001 From: Ruben Calvo Date: Sun, 30 Jun 2024 14:14:13 +0200 Subject: [PATCH] [ticket/17357] Fix test PHPBB-17357 --- tests/attachment/delete_test.php | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/attachment/delete_test.php b/tests/attachment/delete_test.php index 7acac28f33..e92319c078 100644 --- a/tests/attachment/delete_test.php +++ b/tests/attachment/delete_test.php @@ -86,16 +86,16 @@ class phpbb_attachment_delete_test extends \phpbb_database_test_case public function data_attachment_unlink() { return array( - array(true, true, true), - array(true, false, false), - array(true, true, false, true), + array(true, true), + array(false, false), + array(true, false, true), ); } /** * @dataProvider data_attachment_unlink */ - public function test_attachment_delete_success($remove_success, $exists_success, $expected, $throw_exception = false) + public function test_attachment_delete_success($exists_success, $expected, $throw_exception = false) { $this->storage = $this->createMock('\phpbb\storage\storage'); if ($throw_exception) @@ -107,8 +107,7 @@ class phpbb_attachment_delete_test extends \phpbb_database_test_case else { $this->storage->expects($this->any()) - ->method('delete') - ->willReturn($remove_success); + ->method('delete'); } $this->storage->expects($this->any()) ->method('exists')