makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-11 22:08:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/security-180] Check if redirect URL contains board URL

Browse source 
SECURITY-180
This commit is contained in:
Marc Alexander 2015-04-10 18:02:58 +02:00
parent 35d2467c94
commit eed355b798
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
phpBB/includes/functions.php
View file

@ -2579,6 +2579,12 @@ function redirect($url, $return = false, $disable_cd_check = false)
} }
} }
// Make sure we don't redirect to external URLs
if (!$disable_cd_check && strpos($url, generate_board_url(true)) !== 0)
{
trigger_error('Tried to redirect to potentially insecure url.', E_USER_ERROR);
}
// Make sure no linebreaks are there... to prevent http response splitting for PHP < 4.4.2 // Make sure no linebreaks are there... to prevent http response splitting for PHP < 4.4.2
if (strpos(urldecode($url), "\n") !== false || strpos(urldecode($url), "\r") !== false || strpos($url, ';') !== false) if (strpos(urldecode($url), "\n") !== false || strpos(urldecode($url), "\r") !== false || strpos($url, ';') !== false)
{ {