mirror of
https://github.com/phpbb/phpbb.git
synced 2025-06-08 20:38:52 +00:00
[ticket/13122] Make phpbb_wrapper_gmgetdate_test more reliable
If you're unlucky, calling time() or similar twice in a row will give you different results. Facebook runs these tests thousands of times a day, so we occasionally get bogus failures. PHPBB3-13122
This commit is contained in:
parent
6f093ade8a
commit
f30c5f730e
1 changed files with 12 additions and 1 deletions
|
@ -50,7 +50,18 @@ class phpbb_wrapper_gmgetdate_test extends phpbb_test_case
|
||||||
$date_array['year']
|
$date_array['year']
|
||||||
);
|
);
|
||||||
|
|
||||||
$this->assertEquals($expected, $actual);
|
// Calling second-granularity time functions twice isn't guaranteed to
|
||||||
|
// give the same results. As long as they're in the right order, allow
|
||||||
|
// a 1 second difference.
|
||||||
|
$this->assertGreaterThanOrEqual(
|
||||||
|
$expected, $actual,
|
||||||
|
'Expected second time to be after (or equal to) the previous one'
|
||||||
|
);
|
||||||
|
$this->assertLessThanOrEqual(
|
||||||
|
1,
|
||||||
|
abs($actual - $expected),
|
||||||
|
"Expected $actual to be within 1 second of $expected."
|
||||||
|
);
|
||||||
|
|
||||||
if (isset($current_timezone))
|
if (isset($current_timezone))
|
||||||
{
|
{
|
||||||
|
|
Loading…
Add table
Reference in a new issue