diff --git a/phpBB/adm/style/acp_users_signature.html b/phpBB/adm/style/acp_users_signature.html
index e51b5ab68d..3b6303319b 100644
--- a/phpBB/adm/style/acp_users_signature.html
+++ b/phpBB/adm/style/acp_users_signature.html
@@ -27,7 +27,7 @@
t: '{LA_BBCODE_T_HELP}',
tip: '{L_STYLES_TIP}'
- ,cb_{custom_tags.BBCODE_ID}: '{custom_tags.BBCODE_HELPLINE}'
+ ,cb_{custom_tags.BBCODE_ID}: '{custom_tags.A_BBCODE_HELPLINE}'
}
diff --git a/phpBB/adm/style/install_update.html b/phpBB/adm/style/install_update.html
index c9059d8801..318795f4cf 100644
--- a/phpBB/adm/style/install_update.html
+++ b/phpBB/adm/style/install_update.html
@@ -201,7 +201,7 @@
diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html
index e7cdbe9a8b..8913c7148d 100644
--- a/phpBB/docs/CHANGELOG.html
+++ b/phpBB/docs/CHANGELOG.html
@@ -92,6 +92,7 @@
[Fix] Fixing false new private message indicator (Bug #14627)
[Fix] Let newly activated passwords work if users were converted (Bug #14787)
[Fix] Quote bbcode fixes. Letting parse quote="[" and re-allowing whitelisted bbcodes within username portion (Bug #14770)
+
[Sec] Fix bbcode helpline display for custom bbcodes - this requires style changes for any custom style (Bug #14850)
1.ii. Changes since 3.0.RC6
diff --git a/phpBB/includes/acp/acp_styles.php b/phpBB/includes/acp/acp_styles.php
index 9e04ede90b..f4f7f8e56b 100644
--- a/phpBB/includes/acp/acp_styles.php
+++ b/phpBB/includes/acp/acp_styles.php
@@ -993,6 +993,11 @@ parse_css_file = {PARSE_CSS_FILE}
$filename = "{$cache_prefix}_$file.html.$phpEx";
+ if (!file_exists("{$phpbb_root_path}cache/$filename"))
+ {
+ continue;
+ }
+
$template->assign_block_vars('file', array(
'U_VIEWSOURCE' => $this->u_action . "&action=cache&id=$template_id&source=$file",
diff --git a/phpBB/includes/functions_display.php b/phpBB/includes/functions_display.php
index b75747a862..05630342d1 100644
--- a/phpBB/includes/functions_display.php
+++ b/phpBB/includes/functions_display.php
@@ -826,8 +826,9 @@ function display_custom_bbcodes()
'BBCODE_NAME' => "'[{$row['bbcode_tag']}]', '[/" . str_replace('=', '', $row['bbcode_tag']) . "]'",
'BBCODE_ID' => $num_predefined_bbcodes + ($i * 2),
'BBCODE_TAG' => $row['bbcode_tag'],
- 'BBCODE_HELPLINE' => str_replace(array('&', '"', "'", '<', '>'), array('\&', '\"', '\\\'', '<', '>'), $row['bbcode_helpline']))
- );
+ 'BBCODE_HELPLINE' => $row['bbcode_helpline'],
+ 'A_BBCODE_HELPLINE' => str_replace(array('&', '"', "'", '<', '>'), array('&', '"', "\'", '<', '>'), $row['bbcode_helpline']),
+ ));
$i++;
}
diff --git a/phpBB/styles/prosilver/template/posting_buttons.html b/phpBB/styles/prosilver/template/posting_buttons.html
index c235e49d04..357d20c93b 100644
--- a/phpBB/styles/prosilver/template/posting_buttons.html
+++ b/phpBB/styles/prosilver/template/posting_buttons.html
@@ -28,7 +28,7 @@
e: '{LA_BBCODE_E_HELP}',
d: '{LA_BBCODE_D_HELP}'
- ,cb_{custom_tags.BBCODE_ID}: '{custom_tags.BBCODE_HELPLINE}'
+ ,cb_{custom_tags.BBCODE_ID}: '{custom_tags.A_BBCODE_HELPLINE}'
}
diff --git a/phpBB/styles/subsilver2/template/posting_buttons.html b/phpBB/styles/subsilver2/template/posting_buttons.html
index b57a273e25..5adfeab6cd 100644
--- a/phpBB/styles/subsilver2/template/posting_buttons.html
+++ b/phpBB/styles/subsilver2/template/posting_buttons.html
@@ -26,7 +26,7 @@
t: '{LA_BBCODE_T_HELP}',
tip: '{L_STYLES_TIP}'
- ,cb_{custom_tags.BBCODE_ID}: '{custom_tags.BBCODE_HELPLINE}'
+ ,cb_{custom_tags.BBCODE_ID}: '{custom_tags.A_BBCODE_HELPLINE}'
}