[ticket/12557] Notification fixes

PHPBB3-12557

phpBB/phpbb/notification/manager.php

@@ -68,12 +68,14 @@ class manager
 	* @param \phpbb\user_loader $user_loader
 	* @param \phpbb\config\config $config
 	* @param \phpbb\db\driver\driver_interface $db
+	* @param \phpbb\cache\service $cache
 	* @param \phpbb\user $user
 	* @param string $phpbb_root_path
 	* @param string $php_ext
 	* @param string $notification_types_table
 	* @param string $notifications_table
 	* @param string $user_notifications_table
+	*
 	* @return \phpbb\notification\manager
 	*/
 	public function __construct($notification_types, $notification_methods, ContainerInterface $phpbb_container, \phpbb\user_loader $user_loader, \phpbb\config\config $config, \phpbb\db\driver\driver_interface $db, \phpbb\cache\service $cache, $user, $phpbb_root_path, $php_ext, $notification_types_table, $notifications_table, $user_notifications_table)
@@ -832,7 +834,7 @@ class manager
 	* Delete all notifications older than a certain time
 	*
 	* @param int $timestamp Unix timestamp to delete all notifications that were created before
-	* @param bool $only_unread True (default) to only prune read notifications
+	* @param bool $only_read True (default) to only prune read notifications
 	*/
 	public function prune_notifications($timestamp, $only_read = true)
 	{

phpBB/phpbb/notification/type/approve_post.php

@@ -68,6 +68,7 @@ class approve_post extends \phpbb\notification\type\post
 	* Find the users who want to receive notifications
 	*
 	* @param array $post Data from
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/

phpBB/phpbb/notification/type/approve_topic.php

@@ -68,6 +68,7 @@ class approve_topic extends \phpbb\notification\type\topic
 	* Find the users who want to receive notifications
 	*
 	* @param array $post Data from
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/

phpBB/phpbb/notification/type/base.php

@@ -161,6 +161,8 @@ abstract class base implements \phpbb\notification\type\type_interface
 	* Magic method to set data on this notification
 	*
 	* @param mixed $name
+	* @param mixed $value
+	*
 	* @return null
 	*/
 	public function __set($name, $value)
@@ -174,7 +176,6 @@ abstract class base implements \phpbb\notification\type\type_interface
 	*
 	* Primarily for testing
 	*
-	* @param string $name
 	* @return mixed
 	*/
 	public function __toString()

phpBB/phpbb/notification/type/bookmark.php

@@ -60,6 +60,7 @@ class bookmark extends \phpbb\notification\type\post
 	* Find the users who want to receive notifications
 	*
 	* @param array $post Data from
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/

phpBB/phpbb/notification/type/pm.php

@@ -73,6 +73,7 @@ class pm extends \phpbb\notification\type\base
 	* Find the users who want to receive notifications
 	*
 	* @param array $pm Data from
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/
@@ -178,7 +179,7 @@ class pm extends \phpbb\notification\type\base
 	* Function for preparing the data for insertion in an SQL query
 	* (The service handles insertion)
 	*
-	* @param array $post Data from submit_post
+	* @param array $pm Data from submit_post
 	* @param array $pre_create_data Data from pre_create_insert_array()
 	*
 	* @return array Array of data ready to be inserted into the database

phpBB/phpbb/notification/type/post_in_queue.php

@@ -70,6 +70,7 @@ class post_in_queue extends \phpbb\notification\type\post
 	* Find the users who want to receive notifications
 	*
 	* @param array $post Data from the post
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/

phpBB/phpbb/notification/type/quote.php

@@ -67,6 +67,7 @@ class quote extends \phpbb\notification\type\post
 	* Find the users who want to receive notifications
 	*
 	* @param array $post Data from
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/
@@ -122,7 +123,7 @@ class quote extends \phpbb\notification\type\post
 	/**
 	* Update a notification
 	*
-	* @param array $data Data specific for this type that will be updated
+	* @param array $post Data specific for this type that will be updated
 	*/
 	public function update_notifications($post)
 	{

phpBB/phpbb/notification/type/report_pm.php

@@ -94,6 +94,7 @@ class report_pm extends \phpbb\notification\type\pm
 	*  (copied from post_in_queue)
 	*
 	* @param array $post Data from the post
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/

phpBB/phpbb/notification/type/report_pm_closed.php

@@ -53,6 +53,7 @@ class report_pm_closed extends \phpbb\notification\type\pm
 	* Find the users who want to receive notifications
 	*
 	* @param array $pm Data from
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/

phpBB/phpbb/notification/type/report_post.php

@@ -76,6 +76,7 @@ class report_post extends \phpbb\notification\type\post_in_queue
 	* Find the users who want to receive notifications
 	*
 	* @param array $post Data from the post
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/

phpBB/phpbb/notification/type/report_post_closed.php

@@ -60,6 +60,7 @@ class report_post_closed extends \phpbb\notification\type\post
 	* Find the users who want to receive notifications
 	*
 	* @param array $post Data from
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/

phpBB/phpbb/notification/type/topic.php

@@ -87,6 +87,7 @@ class topic extends \phpbb\notification\type\base
 	* Find the users who want to receive notifications
 	*
 	* @param array $topic Data from the topic
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/

phpBB/phpbb/notification/type/topic_in_queue.php

@@ -70,6 +70,7 @@ class topic_in_queue extends \phpbb\notification\type\topic
 	* Find the users who want to receive notifications
 	*
 	* @param array $topic Data from the topic
+	* @param array $options Options for finding users for notification
 	*
 	* @return array
 	*/