From cd34cdedee2e6470238b5ee12154fd056f6192e8 Mon Sep 17 00:00:00 2001
From: Daniel James <danielt70@icloud.com>
Date: Fri, 17 May 2024 12:48:37 +0100
Subject: [PATCH 1/5] [ticket/17317] Change button text for pm recipient to
 increase readability

PHPBB3-17317
---
 phpBB/styles/prosilver/template/posting_pm_header.html | 4 ++--
 phpBB/styles/prosilver/theme/common.css                | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/phpBB/styles/prosilver/template/posting_pm_header.html b/phpBB/styles/prosilver/template/posting_pm_header.html
index 2fee21fd97..738d5b25f2 100644
--- a/phpBB/styles/prosilver/template/posting_pm_header.html
+++ b/phpBB/styles/prosilver/template/posting_pm_header.html
@@ -31,7 +31,7 @@
 					<ul class="recipients">
 						<!-- BEGIN to_recipient -->
 						<li>
-							<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]" value="x" class="button2" /><!-- ENDIF -->
+							<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]" value="{L_REMOVE}" class="button2" /><!-- ENDIF -->
 							<!-- IF to_recipient.IS_GROUP --><a href="{to_recipient.U_VIEW}" style="color: {{ to_recipient.COLOUR }}"><strong>{to_recipient.NAME}</strong></a><!-- ELSE -->{to_recipient.NAME_FULL}<!-- ENDIF -->
 						</li>
 						<!-- END to_recipient -->
@@ -48,7 +48,7 @@
 					<ul class="recipients">
 						<!-- BEGIN bcc_recipient -->
 						<li>
-							<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{bcc_recipient.TYPE}[{bcc_recipient.UG_ID}]" value="x" class="button2" /><!-- ENDIF -->
+							<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{bcc_recipient.TYPE}[{bcc_recipient.UG_ID}]" value="{L_REMOVE}" class="button2" /><!-- ENDIF -->
 							<!-- IF bcc_recipient.IS_GROUP --><a href="{bcc_recipient.U_VIEW}" style="color: {{ bcc_recipient.COLOUR }}"><strong>{bcc_recipient.NAME}</strong></a><!-- ELSE -->{bcc_recipient.NAME_FULL}<!-- ENDIF -->
 						</li>
 						<!-- END bcc_recipient -->
diff --git a/phpBB/styles/prosilver/theme/common.css b/phpBB/styles/prosilver/theme/common.css
index e1d9e757f9..ebfb478274 100644
--- a/phpBB/styles/prosilver/theme/common.css
+++ b/phpBB/styles/prosilver/theme/common.css
@@ -780,10 +780,10 @@ fieldset.fields1 dd.recipients {
 	margin-left: 1em;
 }
 
-fieldset.fields1 ul.recipients  input.button2 {
+fieldset.fields1 ul.recipients input.button2 {
 	font-size: 0.8em;
 	margin-right: 0;
-	padding: 0;
+	padding: 2px 0;
 }
 
 fieldset.fields1 dl.pmlist > dt {

From 40ed6c6458b5db0ab3ce817cf0b2310af101fea3 Mon Sep 17 00:00:00 2001
From: Daniel James <danielt70@icloud.com>
Date: Fri, 17 May 2024 12:58:27 +0100
Subject: [PATCH 2/5] [ticket/17317] Fix padding on button, left and right not
 top and bottom

PHPBB3-17317
---
 phpBB/styles/prosilver/theme/common.css | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/phpBB/styles/prosilver/theme/common.css b/phpBB/styles/prosilver/theme/common.css
index ebfb478274..eaa9cf332a 100644
--- a/phpBB/styles/prosilver/theme/common.css
+++ b/phpBB/styles/prosilver/theme/common.css
@@ -783,7 +783,7 @@ fieldset.fields1 dd.recipients {
 fieldset.fields1 ul.recipients input.button2 {
 	font-size: 0.8em;
 	margin-right: 0;
-	padding: 2px 0;
+	padding: 0 2px;
 }
 
 fieldset.fields1 dl.pmlist > dt {

From 9fcf956888c2f5fce21a0d1c072387b360deb225 Mon Sep 17 00:00:00 2001
From: Daniel James <danielt70@icloud.com>
Date: Wed, 22 May 2024 11:17:25 +0100
Subject: [PATCH 3/5] [ticket/17317] Replace button with small red fa-icon

Updated the button to a small red X using Font Awesome
rather than using the default phpBB button with text
which adds a better visual distinction in the interface
between the username and action. Credit to @iMattPro for
the suggestion in the ticket comments.

PHPBB3-17317
---
 .../styles/prosilver/template/posting_pm_header.html | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/phpBB/styles/prosilver/template/posting_pm_header.html b/phpBB/styles/prosilver/template/posting_pm_header.html
index 738d5b25f2..aecd98eacc 100644
--- a/phpBB/styles/prosilver/template/posting_pm_header.html
+++ b/phpBB/styles/prosilver/template/posting_pm_header.html
@@ -31,7 +31,11 @@
 					<ul class="recipients">
 						<!-- BEGIN to_recipient -->
 						<li>
-							<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]" value="{L_REMOVE}" class="button2" /><!-- ENDIF -->
+							<!-- IF not S_EDIT_POST -->
+								<button type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]">
+									<i class="icon fa-times icon-red" aria-hidden="true"></i><span class="sr-only">{L_REMOVE}</span>
+								</button>
+							<!-- ENDIF -->
 							<!-- IF to_recipient.IS_GROUP --><a href="{to_recipient.U_VIEW}" style="color: {{ to_recipient.COLOUR }}"><strong>{to_recipient.NAME}</strong></a><!-- ELSE -->{to_recipient.NAME_FULL}<!-- ENDIF -->
 						</li>
 						<!-- END to_recipient -->
@@ -48,7 +52,11 @@
 					<ul class="recipients">
 						<!-- BEGIN bcc_recipient -->
 						<li>
-							<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{bcc_recipient.TYPE}[{bcc_recipient.UG_ID}]" value="{L_REMOVE}" class="button2" /><!-- ENDIF -->
+							<!-- IF not S_EDIT_POST -->
+								<button type="submit" name="remove_{bcc_recipient.TYPE}[{bcc_recipient.UG_ID}]">
+									<i class="icon fa-times icon-red" aria-hidden="true"></i><span class="sr-only">{L_REMOVE}</span>
+								</button>
+							<!-- ENDIF -->
 							<!-- IF bcc_recipient.IS_GROUP --><a href="{bcc_recipient.U_VIEW}" style="color: {{ bcc_recipient.COLOUR }}"><strong>{bcc_recipient.NAME}</strong></a><!-- ELSE -->{bcc_recipient.NAME_FULL}<!-- ENDIF -->
 						</li>
 						<!-- END bcc_recipient -->

From c330500c4d46de0cd39c030217d1672a084d00e7 Mon Sep 17 00:00:00 2001
From: Daniel James <danielt70@icloud.com>
Date: Wed, 22 May 2024 17:39:24 +0100
Subject: [PATCH 4/5] [ticket/17317] Add new icon for groups and remove CSS
 change

PHPBB3-17317
---
 phpBB/styles/prosilver/template/posting_pm_header.html | 8 ++++++--
 phpBB/styles/prosilver/theme/common.css                | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/phpBB/styles/prosilver/template/posting_pm_header.html b/phpBB/styles/prosilver/template/posting_pm_header.html
index aecd98eacc..6b03febeec 100644
--- a/phpBB/styles/prosilver/template/posting_pm_header.html
+++ b/phpBB/styles/prosilver/template/posting_pm_header.html
@@ -77,8 +77,12 @@
 						<ul class="recipients">
 							<!-- BEGIN to_recipient -->
 							<li>
-								<!-- IF to_recipient.IS_GROUP --><a href="{to_recipient.U_VIEW}"><strong>{to_recipient.NAME}</strong></a><!-- ELSE -->{to_recipient.NAME_FULL}<!-- ENDIF -->&nbsp;
-								<!-- IF not S_EDIT_POST --><input type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]" value="x" class="button2" /><!-- ENDIF -->
+								<!-- IF not S_EDIT_POST -->
+									<button type="submit" name="remove_{to_recipient.TYPE}[{to_recipient.UG_ID}]">
+										<i class="icon fa-times icon-red" aria-hidden="true"></i><span class="sr-only">{L_REMOVE}</span>
+									</button>
+								<!-- ENDIF -->
+								<!-- IF to_recipient.IS_GROUP --><a href="{to_recipient.U_VIEW}"><strong>{to_recipient.NAME}</strong></a><!-- ELSE -->{to_recipient.NAME_FULL}<!-- ENDIF -->
 							</li>
 							<!-- END to_recipient -->
 						</ul>
diff --git a/phpBB/styles/prosilver/theme/common.css b/phpBB/styles/prosilver/theme/common.css
index eaa9cf332a..dc4d7e07bd 100644
--- a/phpBB/styles/prosilver/theme/common.css
+++ b/phpBB/styles/prosilver/theme/common.css
@@ -783,7 +783,7 @@ fieldset.fields1 dd.recipients {
 fieldset.fields1 ul.recipients input.button2 {
 	font-size: 0.8em;
 	margin-right: 0;
-	padding: 0 2px;
+	padding: 0;
 }
 
 fieldset.fields1 dl.pmlist > dt {

From 92e545fc26185ac236aa6a880a483ed33824bd45 Mon Sep 17 00:00:00 2001
From: Daniel James <danielt70@icloud.com>
Date: Thu, 23 May 2024 16:25:57 +0100
Subject: [PATCH 5/5] [ticket/17317] Remove unused CSS styling for inputs

PHPBB3-17317
---
 phpBB/styles/prosilver/theme/common.css | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/phpBB/styles/prosilver/theme/common.css b/phpBB/styles/prosilver/theme/common.css
index dc4d7e07bd..e184557a89 100644
--- a/phpBB/styles/prosilver/theme/common.css
+++ b/phpBB/styles/prosilver/theme/common.css
@@ -780,12 +780,6 @@ fieldset.fields1 dd.recipients {
 	margin-left: 1em;
 }
 
-fieldset.fields1 ul.recipients input.button2 {
-	font-size: 0.8em;
-	margin-right: 0;
-	padding: 0;
-}
-
 fieldset.fields1 dl.pmlist > dt {
 	width: auto !important;
 }