makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17100] Move html for ext group selects from PHP files

Browse source 
PHPBB3-17100
This commit is contained in:
Marc Alexander 2022-04-17 23:01:24 +02:00
parent 3e75aabc64
commit f64eb7dd04
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
2 changed files with 31 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
phpBB/adm/style/acp_attachments.html
View file

@ -281,8 +281,14 @@
<dd><input type="text" id="add_extension" size="20" maxlength="100" name="add_extension" value="{ADD_EXTENSION}" /></dd> <dd><input type="text" id="add_extension" size="20" maxlength="100" name="add_extension" value="{ADD_EXTENSION}" /></dd>
</dl> </dl>
<dl> <dl>
<dt><label for="extension_group">{L_EXTENSION_GROUP}</label></dt> <dt><label for="{{ GROUP_SELECT_OPTIONS.id }}">{L_EXTENSION_GROUP}</label></dt>
<dd>{GROUP_SELECT_OPTIONS}</dd> <dd>
<select name="{{ GROUP_SELECT_OPTIONS.name }}" id="{{ GROUP_SELECT_OPTIONS.id }}">
{% for option in GROUP_SELECT_OPTIONS.options %}
<option value="{{ option.value }}"{% if option.selected %} selected="selected"{% endif %}>{{ option.label }}</option>
{% endfor %}
</select>
</dd>
</dl> </dl>
<p class="quick"> <p class="quick">
@ -315,7 +321,13 @@
<!-- ENDIF --> <!-- ENDIF -->
<tr> <tr>
<td><strong>{extensions.EXTENSION}</strong></td> <td><strong>{extensions.EXTENSION}</strong></td>
<td>{extensions.GROUP_OPTIONS}</td> <td>
<select name="{{ extensions.GROUP_OPTIONS.name }}" id="{{ extensions.GROUP_OPTIONS.id }}">
{% for option in extensions.GROUP_OPTIONS.options %}
<option value="{{ option.value }}"{% if option.selected %} selected="selected"{% endif %}>{{ option.label }}</option>
{% endfor %}
</select>
</td>
<td><input type="checkbox" class="radio" name="extension_id_list[]" value="{extensions.EXTENSION_ID}" /><input type="hidden" name="extension_change_list[]" value="{extensions.EXTENSION_ID}" /></td> <td><input type="checkbox" class="radio" name="extension_id_list[]" value="{extensions.EXTENSION_ID}" /><input type="hidden" name="extension_change_list[]" value="{extensions.EXTENSION_ID}" /></td>
</tr> </tr>
<!-- END extensions --> <!-- END extensions -->

26
phpBB/includes/acp/acp_attachments.php
View file

@ -452,11 +452,11 @@ class acp_attachments
$cache->destroy('_extensions'); $cache->destroy('_extensions');
} }
$template->assign_vars(array( $template->assign_vars([
'S_EXTENSIONS' => true, 'S_EXTENSIONS' => true,
'ADD_EXTENSION' => (isset($add_extension)) ? $add_extension : '', 'ADD_EXTENSION' => (isset($add_extension)) ? $add_extension : '',
'GROUP_SELECT_OPTIONS' => (isset($_POST['add_extension_check'])) ? $this->group_select('add_group_select', $add_extension_group, 'extension_group') : $this->group_select('add_group_select', false, 'extension_group')) 'GROUP_SELECT_OPTIONS' => $this->group_select('add_group_select', $request->is_set_post('add_extension_check') ? $add_extension_group : false, 'extension_group'),
); ]);
$sql = 'SELECT * $sql = 'SELECT *
FROM ' . EXTENSIONS_TABLE . ' FROM ' . EXTENSIONS_TABLE . '
@ -1470,8 +1470,6 @@ class acp_attachments
{ {
global $db, $user; global $db, $user;
$group_select = '<select name="' . $select_name . '"' . (($key) ? ' id="' . $key . '"' : '') . '>';
$sql = 'SELECT group_id, group_name $sql = 'SELECT group_id, group_name
FROM ' . EXTENSION_GROUPS_TABLE . ' FROM ' . EXTENSION_GROUPS_TABLE . '
ORDER BY group_name'; ORDER BY group_name';
@ -1489,22 +1487,30 @@ class acp_attachments
$row['group_name'] = $user->lang['NOT_ASSIGNED']; $row['group_name'] = $user->lang['NOT_ASSIGNED'];
$group_name[] = $row; $group_name[] = $row;
$group_select = [
'name' => $select_name,
'id' => $key,
'options' => [],
];
for ($i = 0, $groups_size = count($group_name); $i < $groups_size; $i++) for ($i = 0, $groups_size = count($group_name); $i < $groups_size; $i++)
{ {
if ($default_group === false) if ($default_group === false)
{ {
$selected = ($i == 0) ? ' selected="selected"' : ''; $selected = $i == 0;
} }
else else
{ {
$selected = ($group_name[$i]['group_id'] == $default_group) ? ' selected="selected"' : ''; $selected = $group_name[$i]['group_id'] == $default_group;
} }
$group_select .= '<option value="' . $group_name[$i]['group_id'] . '"' . $selected . '>' . $group_name[$i]['group_name'] . '</option>'; $group_select['options'][] = [
'value' => $group_name[$i]['group_id'],
'selected' => $selected,
'label' => $group_name[$i]['group_name'],
];
} }
$group_select .= '</select>';
return $group_select; return $group_select;
} }