From f9192bed79c2d5a0c1e8388bcdc35be3d21aa9a8 Mon Sep 17 00:00:00 2001
From: Igor Wiedler <igor@wiedler.ch>
Date: Thu, 11 Mar 2010 19:44:21 +0100
Subject: [PATCH] [git-tools] Some pre-commit enhancements, abolish tempfile

---
 git-tools/hooks/pre-commit | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/git-tools/hooks/pre-commit b/git-tools/hooks/pre-commit
index 937d2d2dc0..6129470196 100755
--- a/git-tools/hooks/pre-commit
+++ b/git-tools/hooks/pre-commit
@@ -12,6 +12,8 @@
 # ln -s ../../git-tools/hooks/pre-commit \\
 #   .git/hooks/pre-commit
 
+PHP_BIN=php
+
 # necessary check for initial commit
 if git rev-parse --verify HEAD >/dev/null 2>&1
 then
@@ -27,12 +29,10 @@ error=0
 IFS=" "
 for file in $(git diff --cached --name-status $against | grep -v -E '^D' | cut -f2 | grep -E '\.php$')
 do
-	# store lint result in a temp file
-	tempfile=$(mktemp -t "$(basename $0).XXXXXX")
-	if ! php -l "$file" >/dev/null 2>"$tempfile"
+	# hide output, but show errors
+	if ! $PHP_BIN -l "$file" >/dev/null
 	then
 		error=1
-		cat "$tempfile"
 	fi
 done
 unset IFS