From fa6d60401656ee875ef18b35dc7ce43bd270ff4e Mon Sep 17 00:00:00 2001 From: Nathan Guse Date: Sun, 14 Oct 2012 12:49:09 -0500 Subject: [PATCH] [ticket/11103] Remove todo comments that are no longer todo PHPBB3-11103 --- phpBB/includes/notification/type/quote.php | 6 ------ phpBB/includes/ucp/ucp_notifications.php | 1 - 2 files changed, 7 deletions(-) diff --git a/phpBB/includes/notification/type/quote.php b/phpBB/includes/notification/type/quote.php index 4d1e637820..0cc183346f 100644 --- a/phpBB/includes/notification/type/quote.php +++ b/phpBB/includes/notification/type/quote.php @@ -184,12 +184,6 @@ class phpbb_notification_type_quote extends phpbb_notification_type_post $add_notifications[$user_id] = $notifications[$user_id]; } - // todo Adding notifications while editing a post can be funky. - // If the user has read the topic/post already, and the user is newly quoted it an edit, - // The notification will be stuck as unread until another post is made and the user visits - // the topic again because the posts will not be marked as read since the topic is already - // marked as read - // Add the necessary notifications $this->notification_manager->add_notifications_for_users(self::get_item_type(), $post, $add_notifications); diff --git a/phpBB/includes/ucp/ucp_notifications.php b/phpBB/includes/ucp/ucp_notifications.php index 98165a7bf7..321730a64b 100644 --- a/phpBB/includes/ucp/ucp_notifications.php +++ b/phpBB/includes/ucp/ucp_notifications.php @@ -79,7 +79,6 @@ class ucp_notifications $message = $user->lang['PREFERENCES_UPDATED'] . '

' . sprintf($user->lang['RETURN_UCP'], '', ''); trigger_error($message); } - // todo include language files for extensions? $this->output_notification_methods('notification_methods', $phpbb_notifications, $template, $user);