diff --git a/phpBB/adm/style/acp_icons.html b/phpBB/adm/style/acp_icons.html
index 9c488c9f90..265136cbcc 100644
--- a/phpBB/adm/style/acp_icons.html
+++ b/phpBB/adm/style/acp_icons.html
@@ -4,8 +4,8 @@
+
+ var toggle_options;
+
+ function toggle_select(smilie, display, select)
+ {
+ var disp = document.getElementById('order_disp[' + smilie + ']');
+ var nodisp = document.getElementById('order_no_disp[' + smilie + ']');
+ disp.disabled = !display;
+ //document.getElementById('order_disp[' + smilie + ']').style = '';
+ nodisp.disabled = display;
+ //document.getElementById('order_no_disp[' + smilie + ']').style = 'display:none';
+ if (display)
+ {
+
+ document.getElementById(select).selectedIndex = 0;
+
+ nodisp.style.display = 'none';
+ disp.style.display = '';
+ }
+ else
+ {
+ document.getElementById(select).selectedIndex = {S_ORDER_LIST_DISPLAY_COUNT};
+
+ disp.style.display = 'none';
+ nodisp.style.display = '';
+ }
+ }
+
+
+
« {L_BACK}
@@ -89,13 +117,16 @@
|
|
-
+
|
- |
+ |
|
@@ -113,8 +144,11 @@
|
|
|
- |
- |
+ |
+ |
|
diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html
index 78fa24536f..f22ce6b952 100644
--- a/phpBB/docs/CHANGELOG.html
+++ b/phpBB/docs/CHANGELOG.html
@@ -193,6 +193,10 @@ p a {
[Fix] Allow MS SQL to properly connect when using the mssql driver and PHP is less than either 4.4.1 or 5.1 (Bug #13874)
[Fix] Ignore files containging HTML special chars in the filenames as gallery avatars (Bug #13906)
[Fix] Multiple PM recipients not separated (Bug #13876)
+ [Change] Split the select list for the smilie order to clarify which are feasible and which are not (Bug #13911)
+ [Fix] Convert empty homepage fields (Bug #13917)
+
+
diff --git a/phpBB/includes/acp/acp_icons.php b/phpBB/includes/acp/acp_icons.php
index 538a46358d..f0a0ad1a89 100644
--- a/phpBB/includes/acp/acp_icons.php
+++ b/phpBB/includes/acp/acp_icons.php
@@ -144,13 +144,19 @@ class acp_icons
}
}
}
-
+
$sql = "SELECT *
FROM $table
ORDER BY {$fields}_order " . (($icon_id || $action == 'add') ? 'DESC' : 'ASC');
$result = $db->sql_query($sql);
-
+
$data = array();
+ $after = false;
+ $display = 0;
+ $order_lists = array('', '');
+ $add_order_lists = array('', '');
+ $display_count = 0;
+
while ($row = $db->sql_fetchrow($result))
{
if ($action == 'add')
@@ -158,9 +164,11 @@ class acp_icons
unset($_images[$row[$fields . '_url']]);
}
+
if ($row[$fields . '_id'] == $icon_id)
{
$after = true;
+ $display = $row['display_on_posting'];
$data[$row[$fields . '_url']] = $row;
}
else
@@ -176,35 +184,41 @@ class acp_icons
$selected = ' selected="selected"';
$after = false;
}
-
+ if ($row['display_on_posting'])
+ {
+ $display_count++;
+ }
$after_txt = ($mode == 'smilies') ? $row['code'] : $row['icons_url'];
- $order_list = '' . $order_list;
+ $order_lists[$row['display_on_posting']] = '' . $order_lists[$row['display_on_posting']];
if (!empty($default_row))
{
- $add_order_list = '' . $add_order_list;
+ $add_order_lists[$row['display_on_posting']] = '' . $add_order_lists[$row['display_on_posting']];
}
}
}
$db->sql_freeresult($result);
- $order_list = '' . $order_list;
- $add_order_list = '' . $add_order_list;
-
+ $order_list = '';
+ $add_order_list = '';
+
if ($action == 'add')
{
$data = $_images;
}
-
+
$colspan = (($mode == 'smilies') ? '7' : '5');
$colspan += ($icon_id) ? 1 : 0;
$colspan += ($action == 'add') ? 2 : 0;
-
+
$template->assign_vars(array(
'S_EDIT' => true,
'S_SMILIES' => ($mode == 'smilies') ? true : false,
'S_ADD' => ($action == 'add') ? true : false,
- 'S_ORDER_LIST' => $order_list,
+
+ 'S_ORDER_LIST_DISPLAY' => $order_list . $order_lists[1],
+ 'S_ORDER_LIST_UNDISPLAY' => $order_list . $order_lists[0],
+ 'S_ORDER_LIST_DISPLAY_COUNT' => $display_count + 1,
'L_TITLE' => $user->lang['ACP_' . $lang],
'L_EXPLAIN' => $user->lang['ACP_' . $lang . '_EXPLAIN'],
@@ -247,7 +261,10 @@ class acp_icons
'S_ADD_CODE' => true,
'S_IMG_OPTIONS' => $smiley_options,
- 'S_ADD_ORDER_LIST' => $add_order_list,
+
+ 'S_ADD_ORDER_LIST_DISPLAY' => $add_order_list . $add_order_lists[1],
+ 'S_ADD_ORDER_LIST_UNDISPLAY' => $add_order_list . $add_order_lists[0],
+
'IMG_SRC' => $phpbb_root_path . $img_path . '/' . $default_row['smiley_url'],
'IMG_PATH' => $img_path,
'PHPBB_ROOT_PATH' => $phpbb_root_path,
diff --git a/phpBB/includes/functions_convert.php b/phpBB/includes/functions_convert.php
index 159ec387bd..5e1159cb22 100644
--- a/phpBB/includes/functions_convert.php
+++ b/phpBB/includes/functions_convert.php
@@ -228,7 +228,7 @@ function validate_website($url)
{
return '';
}
- else if (strpos(strtolower($url), 'http://') !== 0)
+ else if (strpos(strtolower($url), 'http://') !== 0 && strlen($url) > 0)
{
return 'http://' . $url;
}