diff --git a/phpBB/adm/style/acp_forums.html b/phpBB/adm/style/acp_forums.html index 3bb5aab2fc..5f7b2cb63c 100644 --- a/phpBB/adm/style/acp_forums.html +++ b/phpBB/adm/style/acp_forums.html @@ -311,11 +311,13 @@
{forums.FORUM_DESCRIPTION}

{L_TOPICS}: {forums.FORUM_TOPICS} / {L_POSTS}: {forums.FORUM_POSTS} - {L_MOVE_UP} + + {L_MOVE_UP} {L_MOVE_DOWN} {L_EDIT} {L_RESYNC} - {L_DELETE} + {L_DELETE} + diff --git a/phpBB/adm/style/acp_icons.html b/phpBB/adm/style/acp_icons.html index a417c50f38..8fb0592412 100644 --- a/phpBB/adm/style/acp_icons.html +++ b/phpBB/adm/style/acp_icons.html @@ -128,8 +128,7 @@ {L_CODE} {L_EMOTION} - {L_ACTION} - {L_REORDER} + {L_OPTIONS} @@ -145,8 +144,12 @@ {items.CODE} {items.EMOTION} - {L_EDIT} | {L_DELETE} - {L_MOVE_UP}
{L_MOVE_DOWN} + + {L_MOVE_UP} + {L_MOVE_DOWN} + {L_EDIT} + {L_DELETE} + diff --git a/phpBB/includes/acp/acp_icons.php b/phpBB/includes/acp/acp_icons.php index 3ca135847d..35b41f0ae1 100644 --- a/phpBB/includes/acp/acp_icons.php +++ b/phpBB/includes/acp/acp_icons.php @@ -447,7 +447,6 @@ class acp_icons 'L_TITLE' => $user->lang['ACP_' . $lang], 'L_EXPLAIN' => $user->lang['ACP_' . $lang . '_EXPLAIN'], - 'L_IMPORT' => $user->lang[$lang . '_IMPORT'], 'L_NO_PAK_OPTIONS' => $user->lang['NO_' . $lang . '_PAK'], 'L_CURRENT' => $user->lang['CURRENT_' . $lang], 'L_CURRENT_EXPLAIN' => $user->lang['CURRENT_' . $lang . '_EXPLAIN'], @@ -547,7 +546,7 @@ class acp_icons case 'move_up': case 'move_down': - $image_order = intval($_GET['order']); + $image_order = request_var('order', 0); $order_total = $image_order * 2 + (($action == 'move_up') ? -1 : 1); $sql = 'UPDATE ' . $table . ' @@ -564,7 +563,7 @@ class acp_icons // By default, check that image_order is valid and fix it if necessary $sql = "SELECT {$fields}_id AS order_id, {$fields}_order AS fields_order FROM $table - ORDER BY {$fields}_order"; + ORDER BY display_on_posting DESC, {$fields}_order"; $result = $db->sql_query($sql); if ($row = $db->sql_fetchrow($result)) @@ -608,7 +607,7 @@ class acp_icons $sql = "SELECT * FROM $table - ORDER BY display_on_posting DESC, {$fields}_order ASC"; + ORDER BY {$fields}_order ASC"; $result = $db->sql_query($sql); while ($row = $db->sql_fetchrow($result)) diff --git a/phpBB/includes/functions_display.php b/phpBB/includes/functions_display.php index 9e38d39296..5f4f8ed5f6 100644 --- a/phpBB/includes/functions_display.php +++ b/phpBB/includes/functions_display.php @@ -127,6 +127,16 @@ function display_forums($root_data = '', $display_moderators = true, $return_mod // Display active topics from this forum? if ($show_active && $row['forum_type'] == FORUM_POST && $auth->acl_get('f_read', $forum_id) && ($row['forum_flags'] & 16)) { + if (!isset($active_forum_ary['forum_topics'])) + { + $active_forum_ary['forum_topics'] = 0; + } + + if (!isset($active_forum_ary['forum_posts'])) + { + $active_forum_ary['forum_posts'] = 0; + } + $active_forum_ary['forum_id'][] = $forum_id; $active_forum_ary['enable_icons'][] = $row['enable_icons']; $active_forum_ary['forum_topics'] += ($auth->acl_get('m_approve', $forum_id)) ? $row['forum_topics_real'] : $row['forum_topics']; diff --git a/phpBB/viewforum.php b/phpBB/viewforum.php index 5df376d804..d0ef22428f 100644 --- a/phpBB/viewforum.php +++ b/phpBB/viewforum.php @@ -219,7 +219,7 @@ if ($forum_data['forum_type'] == FORUM_POST || (($forum_data['forum_flags'] & 16 $template->assign_vars(array( 'PAGINATION' => generate_pagination("{$phpbb_root_path}viewforum.$phpEx$SID&f=$forum_id&$u_sort_param", $topics_count, $config['topics_per_page'], $start), 'PAGE_NUMBER' => on_page($topics_count, $config['topics_per_page'], $start), - 'TOTAL_TOPICS' => ($forum_data['forum_flags'] & 16) ? false : (($topics_count == 1) ? $user->lang['VIEW_FORUM_TOPIC'] : sprintf($user->lang['VIEW_FORUM_TOPICS'], $topics_count)), + 'TOTAL_TOPICS' => ($forum_data['forum_flags'] & 16 && $forum_data['forum_type'] == FORUM_CAT) ? false : (($topics_count == 1) ? $user->lang['VIEW_FORUM_TOPIC'] : sprintf($user->lang['VIEW_FORUM_TOPICS'], $topics_count)), 'MODERATORS' => (!empty($moderators[$forum_id])) ? implode(', ', $moderators[$forum_id]) : '', 'POST_IMG' => ($forum_data['forum_status'] == ITEM_LOCKED) ? $user->img('btn_locked', $post_alt) : $user->img('btn_post', $post_alt),