Merge pull request #4974 from Elsensee/ticket/15379

[ticket/15379] Fix assignments in reparser cron job
This commit is contained in:
Marc Alexander 2017-09-28 21:33:19 +02:00
commit fc3d3a83db
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
2 changed files with 11 additions and 8 deletions

View file

@ -85,7 +85,7 @@ class reparser extends \phpbb\cron\task\base
if ($this->resume_data === null) if ($this->resume_data === null)
{ {
$this->reparser_manager->get_resume_data($this->reparser_name); $this->resume_data = $this->reparser_manager->get_resume_data($this->reparser_name);
} }
} }
@ -96,7 +96,7 @@ class reparser extends \phpbb\cron\task\base
{ {
if ($this->resume_data === null) if ($this->resume_data === null)
{ {
$this->reparser_manager->get_resume_data($this->reparser_name); $this->resume_data = $this->reparser_manager->get_resume_data($this->reparser_name);
} }
if (!isset($this->resume_data['range-max']) || $this->resume_data['range-max'] >= $this->resume_data['range-min']) if (!isset($this->resume_data['range-max']) || $this->resume_data['range-max'] >= $this->resume_data['range-min'])

View file

@ -54,13 +54,16 @@ class text_reparser extends \phpbb\db\migration\container_aware_migration
/** @var manager $reparser_manager */ /** @var manager $reparser_manager */
$reparser_manager = $this->container->get('text_reparser.manager'); $reparser_manager = $this->container->get('text_reparser.manager');
/** @var reparser_interface[] $reparsers */ if (!is_array($resume_data))
$reparsers = $this->container->get('text_reparser_collection');
// Initialize all reparsers
foreach ($reparsers as $name => $reparser)
{ {
$reparser_manager->update_resume_data($name, 1, $reparser->get_max_id(), 100); /** @var reparser_interface[] $reparsers */
$reparsers = $this->container->get('text_reparser_collection');
// Initialize all reparsers
foreach ($reparsers as $name => $reparser)
{
$reparser_manager->update_resume_data($name, 1, $reparser->get_max_id(), 100);
}
} }
// Sometimes a cron job is too much // Sometimes a cron job is too much