makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

sql_in_set only allows empty sets if the last parameter is set to true, otherwise it will throw an error message and a backtrace

Browse source 
git-svn-id: file:///svn/phpbb/trunk@6913 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Nils Adermann 2007-01-20 23:35:47 +00:00
parent 31e546c5e4
commit fcfe045307
1 changed files with 20 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
phpBB/includes/db/dbal.php
View file

@ -300,22 +300,35 @@ class dbal
} }
/** /**
* Build IN, NOT IN, = and <> sql comparison string. * Build IN or NOT IN sql comparison string, uses <> or = on single element
* arrays to improve comparison speed
* @access public * @access public
* @param string $field name of the sql column that shall be compared
* @param array $array array of values that are allowed (IN) or not allowed (NOT IN)
* @param bool $negate true for IN (), false for NOT IN ()
* @param bool $allow_empty_set Allow $array to be empty, this function will return 1=1 or 1=0 then
*/ */
function sql_in_set($field, $array, $negate = false) function sql_in_set($field, $array, $negate = false, $allow_empty_set = false)
{ {
if (!sizeof($array)) if (!sizeof($array))
{ {
// NOT IN () actually means everything so use a tautology if (!$allow_empty_set)
if ($negate)
{ {
return '1=1'; // Print the backtrace to help identifying the location of the problematic code
$this->sql_error('No values specified for SQL IN comparison');
} }
// IN () actually means nothing so use a contradiction
else else
{ {
return '1=0'; // NOT IN () actually means everything so use a tautology
if ($negate)
{
return '1=1';
}
// IN () actually means nothing so use a contradiction
else
{
return '1=0';
}
} }
} }