From fe87d441eeb54bf5efb56a0f69f42848d9ef53d5 Mon Sep 17 00:00:00 2001
From: Oleg Pudeyev <oleg@bsdpower.com>
Date: Wed, 5 Dec 2012 10:44:36 -0500
Subject: [PATCH] [ticket/11162] Review comments fixed.

PHPBB3-11162
---
 phpBB/includes/functions_tricky_update.php           | 12 ++++++------
 ...e_rows_avoiding_duplicates_notify_status_test.php |  3 ++-
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/phpBB/includes/functions_tricky_update.php b/phpBB/includes/functions_tricky_update.php
index 10321618b2..05cb65e68d 100644
--- a/phpBB/includes/functions_tricky_update.php
+++ b/phpBB/includes/functions_tricky_update.php
@@ -39,19 +39,19 @@ function phpbb_update_rows_avoiding_duplicates($db, $table, $column, $from_value
 	$old_user_ids = array();
 	while ($row = $db->sql_fetchrow($result))
 	{
-		$old_user_ids[$row[$column]][] = $row['user_id'];
+		$old_user_ids[$row[$column]][] = (int) $row['user_id'];
 	}
 	$db->sql_freeresult($result);
 
 	$sql = "SELECT $column, user_id
 		FROM $table
-		WHERE $column = '" . (int) $to_value . "'";
+		WHERE $column = " . (int) $to_value;
 	$result = $db->sql_query($sql);
 
 	$new_user_ids = array();
 	while ($row = $db->sql_fetchrow($result))
 	{
-		$new_user_ids[$row[$column]][] = $row['user_id'];
+		$new_user_ids[$row[$column]][] = (int) $row['user_id'];
 	}
 	$db->sql_freeresult($result);
 
@@ -126,19 +126,19 @@ function phpbb_update_rows_avoiding_duplicates_notify_status($db, $table, $colum
 	$old_user_ids = array();
 	while ($row = $db->sql_fetchrow($result))
 	{
-		$old_user_ids[(int) $row['notify_status']][$row[$column]][] = $row['user_id'];
+		$old_user_ids[(int) $row['notify_status']][$row[$column]][] = (int) $row['user_id'];
 	}
 	$db->sql_freeresult($result);
 
 	$sql = "SELECT $column, user_id
 		FROM $table
-		WHERE $column = '" . (int) $to_value . "'";
+		WHERE $column = " . (int) $to_value;
 	$result = $db->sql_query($sql);
 
 	$new_user_ids = array();
 	while ($row = $db->sql_fetchrow($result))
 	{
-		$new_user_ids[$row[$column]][] = $row['user_id'];
+		$new_user_ids[$row[$column]][] = (int) $row['user_id'];
 	}
 	$db->sql_freeresult($result);
 
diff --git a/tests/functions_tricky_update/update_rows_avoiding_duplicates_notify_status_test.php b/tests/functions_tricky_update/update_rows_avoiding_duplicates_notify_status_test.php
index aa739c5f04..9052585552 100644
--- a/tests/functions_tricky_update/update_rows_avoiding_duplicates_notify_status_test.php
+++ b/tests/functions_tricky_update/update_rows_avoiding_duplicates_notify_status_test.php
@@ -90,7 +90,8 @@ class phpbb_update_rows_avoiding_duplicates_notify_status_test extends phpbb_dat
 		// user id of 1 is the user being updated
 		$sql = 'SELECT notify_status
 			FROM ' . TOPICS_WATCH_TABLE . '
-			WHERE topic_id = ' . (int) $to . ' AND user_id = 1';
+			WHERE topic_id = ' . (int) $to . '
+                        AND user_id = 1';
 		$result = $db->sql_query($sql);
 		$notify_status = $db->sql_fetchfield('notify_status');
 		$db->sql_freeresult($result);