makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/9590] Correctly set roles and refresh page using POST

Browse source 
PHPBB3-9590
This commit is contained in:
Marc Alexander 2016-11-26 12:31:22 +01:00
parent 6c98e3b12f
commit ff76a3e433
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
1 changed files with 29 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
phpBB/adm/style/ajax.js
View file

@ -74,15 +74,16 @@ function submitPermissions() {
$.each(fieldsetList, function (key, value) { $.each(fieldsetList, function (key, value) {
if (key % 5 === 0) { if (key % 5 === 0) {
formDataSets[Math.floor(key / 5)] = $form.find('fieldset#' + value.id + ' input').serialize(); formDataSets[Math.floor(key / 5)] = $form.find('fieldset#' + value.id).serialize();
} else { } else {
formDataSets[Math.floor(key / 5)] += '&' + $form.find('fieldset#' + value.id + ' input').serialize(); formDataSets[Math.floor(key / 5)] += '&' + $form.find('fieldset#' + value.id).serialize();
} }
}); });
// Set proper start values for handling refresh of page // Set proper start values for handling refresh of page
var permissionSubmitSize = formDataSets.length, var permissionSubmitSize = formDataSets.length,
permissionRequestCount = 0, permissionRequestCount = 0,
forumIds = [],
permissionSubmitFailed = false; permissionSubmitFailed = false;
/** /**
@ -98,6 +99,19 @@ function submitPermissions() {
phpbb.alert(res.MESSAGE_TITLE, res.MESSAGE_TEXT); phpbb.alert(res.MESSAGE_TITLE, res.MESSAGE_TEXT);
permissionSubmitFailed = true; permissionSubmitFailed = true;
} else if (!permissionSubmitFailed && res.S_USER_NOTICE) { } else if (!permissionSubmitFailed && res.S_USER_NOTICE) {
// Fill list of selected forums
if (typeof res.REFRESH_DATA !== 'undefined') {
$.each(res.REFRESH_DATA.url.split('&'), function (key, value){
var forumIdMatch = value.match(/^forum_id\[\]=([0-9]+)$/);
if (forumIdMatch !== null) {
forumIds.push(forumIdMatch[1]);
// Remove added forum IDs from refresh URL
res.REFRESH_DATA.url = res.REFRESH_DATA.url.replace('&' + forumIdMatch[0], '');
}
});
}
// Display success message at the end of submitting the form
if (permissionRequestCount >= permissionSubmitSize) { if (permissionRequestCount >= permissionSubmitSize) {
var $alert = phpbb.alert(res.MESSAGE_TITLE, res.MESSAGE_TEXT); var $alert = phpbb.alert(res.MESSAGE_TITLE, res.MESSAGE_TEXT);
// Do not allow closing alert // Do not allow closing alert
@ -106,7 +120,15 @@ function submitPermissions() {
if (typeof res.REFRESH_DATA !== 'undefined') { if (typeof res.REFRESH_DATA !== 'undefined') {
setTimeout(function () { setTimeout(function () {
window.location = res.REFRESH_DATA.url; // Create forum to submit using POST. This will prevent
// exceeding the maximum length of URLs
var form = '<form action="' + res.REFRESH_DATA.url + '" method="post">';
$.each(forumIds, function (key, value) {
form += '<input type="text" name="forum_id[]" value="' + value + '" />';
});
form += '</form>';
$form = $(form);
$('body').append($form);
// Hide the alert even if we refresh the page, in case the user // Hide the alert even if we refresh the page, in case the user
// presses the back button. // presses the back button.
@ -115,12 +137,16 @@ function submitPermissions() {
$alert.hide(); $alert.hide();
} }
}); });
// Submit form
$form.submit();
}, res.REFRESH_DATA.time * 1000); // Server specifies time in seconds }, res.REFRESH_DATA.time * 1000); // Server specifies time in seconds
} }
} }
} }
} }
// Create AJAX request for each form data set
$.each(formDataSets, function (key, formData) { $.each(formDataSets, function (key, formData) {
$.ajax({ $.ajax({
url: $form.action, url: $form.action,