makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-10 13:28:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/12963] Don't use static var in \extension\base\get_migration_file_list

Browse source 
The static var was global to all instance of \phpbb\base and so if two
different instances (for two different extensions) were created by the
same script they shared the same migrations list.

PHPBB3-12963
This commit is contained in:
Tristan Darricau 2014-09-10 19:17:37 +02:00
parent a093c28d1a
commit ff872a7970
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
phpBB/phpbb/extension/base.php
View file

@ -35,6 +35,9 @@ class base implements \phpbb\extension\extension_interface
/** @var string */
protected $extension_path;
/** @var string[] */
private $migrations = false;
/**
* Constructor
*
@ -122,11 +125,9 @@ class base implements \phpbb\extension\extension_interface
*/
protected function get_migration_file_list()
{
static $migrations = false;
if ($migrations !== false)
if ($this->migrations !== false)
{
return $migrations;
return $this->migrations;
}
// Only have the finder search in this extension path directory