From ffb0adfc59934dd6012394855f494872276b61b9 Mon Sep 17 00:00:00 2001 From: 3D-I <480857+3D-I@users.noreply.github.com> Date: Sat, 21 Dec 2019 23:54:32 +0100 Subject: [PATCH] [ticket/16260] Missing check whether the index exists in ACP - PHP 7.4 PHPBB3-16260 --- phpBB/includes/acp/acp_board.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/phpBB/includes/acp/acp_board.php b/phpBB/includes/acp/acp_board.php index 2441a37edc..b0cefbd064 100644 --- a/phpBB/includes/acp/acp_board.php +++ b/phpBB/includes/acp/acp_board.php @@ -530,11 +530,13 @@ class acp_board if ($submit) { - if (strpos($data['type'], 'password') === 0 && $config_value === '********') + if (strpos(isset($data['type']) ? $data['type'] : '', 'password') === 0 && $config_value === '********') { - // Do not update password fields if the content is ********, - // because that is the password replacement we use to not - // send the password to the output + /** + * Do not update password fields if the content is ********, + * because that is the password replacement we use to not + * send the password to the output + */ continue; } $config->set($config_name, $config_value);