Commit graph

27 commits

Author SHA1 Message Date
Nathan Guse
c911a34b5b [ticket/11103] Do not prepend notification.(type|method) unless necessary
PHPBB3-11103
2012-11-21 16:04:01 -06:00
Nathan Guse
570c5ad3c0 [ticket/11103] Some comments
PHPBB3-11103
2012-11-20 23:12:37 -06:00
Nathan Guse
2afb8b9df8 [ticket/11103] Create user loader class, update for DIC
Create a very basic user loader class to handle querying/storing
user data in a centralized location.

Use DIC collection service for notification types/methods.

Cleanup unused dependencies.

Fix some other issues.

PHPBB3-11103
2012-11-20 22:54:16 -06:00
Nathaniel Guse
6c8c54d4d2 [ticket/11103] Inject table prefix to notifications system instead of constants
PHPBB3-11103
2012-11-09 08:48:41 -06:00
Nathaniel Guse
6a0f6833e6 [ticket/11103] Comment indentation
PHPBB3-11103
2012-11-09 07:48:18 -06:00
Nathaniel Guse
b8bdcc957b [ticket/11103] count is reserved, do not use in a SQL query
PHPBB3-11103
2012-11-09 07:45:23 -06:00
Nathaniel Guse
f09ee16252 [ticket/11103] Use phpBB Container to load types/methods
PHPBB3-11103
2012-11-09 07:40:08 -06:00
Nathan Guse
05e74b82ac [ticket/11103] enable/disable notifications functions
disable_notifications
This should be called when an extension which has notification types
is disabled so that all those notifications are hidden and do not
cause errors

enable_notifications
This should be called when an extension which has notification types
that was disabled is re-enabled so that all those notifications that
were hidden are shown again

PHPBB3-11103
2012-10-29 23:34:51 -05:00
Nathan Guse
b60ae30b02 [ticket/11103] More cleanup
PHPBB3-11103
2012-10-29 18:20:07 -05:00
Nathan Guse
ecf6f1eb8c [ticket/11103] Code cleanup
PHPBB3-11103
2012-10-29 18:15:01 -05:00
Nathan Guse
e549b7663d [ticket/11103] Set basic notifications to be enabled by default
Now, if there is no row for the user in the user_notifications table,
the user will receive basic notifications. If the user wishes to not
receive notifications, a row must be added with notify = 0.

For other methods besides the basic (e.g. email, jabber) a row must
still be added with notify = 1 for them to receive notifications

PHPBB3-11103
2012-10-29 18:09:20 -05:00
Nathan Guse
bc18e368c3 [ticket/11103] Correct the test case
Fix a bug that broke it and make sure to set the needed config/auth settings

PHPBB3-11103
2012-10-20 21:55:58 -05:00
Nathan Guse
94d682f774 [ticket/11103] Use the full class name as the item_type/method
This is going to require you recreate the db tables.

PHPBB3-11103
2012-10-20 20:58:53 -05:00
Nathan Guse
471ca5e7dc [ticket/11103] Change is_disabled to is_enabled
If you're following along and would like to update your DB, you can run
the following queries to do so:

ALTER TABLE phpbb_notifications CHANGE `is_disabled` `is_enabled`
TINYINT( 1 ) NOT NULL DEFAULT  '1';

UPDATE `phpbb_notifications` SET is_enabled = 1;

PHPBB3-11103
2012-10-19 15:50:32 -05:00
Nathan Guse
2c06c2bd36 [ticket/11103] Declare $ for jQuery, check for instance of, newlines at eof
PHPBB3-11103
2012-10-18 19:20:54 -05:00
Nathan Guse
eb07b3ad9c [ticket/11103] Expand class vars and use docblocks for phpBB classes
PHPBB3-11103
2012-10-18 18:50:04 -05:00
Nathan Guse
a48f090338 [ticket/11103] Make sure notifications are marked read when clicking them
How do we do this? If an item is unread, the URL to view that item will
be the URL to mark it as read (index.php?mark_notification=$id). When the
URL is visited it marks the item as read and redirects them to the correct
URL for the item.

If the item is read, the URL is directly to the item.

Prettify the html output

PHPBB-11103
2012-10-14 12:35:35 -05:00
Nathan Guse
c5f280351a [ticket/11103] UCP Notification option grouping
Also add the ability to specify an _EXPLAIN text for the notification option

PHPBB3-11103
2012-10-13 23:52:49 -05:00
Nathan Guse
94ffbb4050 [ticket/11103] Add is_disabled column to notifications table
EXTENSION AUTHORS TAKE NOTE! This is to prevent errors with notifications
from extensions!

Set is_disabled to 1 for all your notifications when your extension is
disabled so they are ignored and do not cause errors.

When your extension is enabled again, set is_disabled to 0 and your
notifications will be working again.

PHPBB3-11103
2012-10-13 23:24:30 -05:00
Nathan Guse
cb93784126 [ticket/11103] UCP Notification List
PHPBB3-11103
2012-10-13 20:02:38 -05:00
Nathan Guse
3d79ce2803 [ticket/11103] Ability to query data before running create_insert_array()
Mark post/topic in queue notifications read when visiting mcp
Change post/topic in queue notification url to use MCP.

Fix the bug:
Approving a topic marks the topic as read, but before the notification
is created for the user approving the topic (if they would get a
notification that the topic has been made). This causes it to be
stuck "unread".

PHPBB3-11103
2012-10-12 16:54:42 -05:00
Nathan Guse
bafb5b0eca [ticket/11103] Starting work on combining notifications
Just for posts currently and not yet outputted.

PHPBB3-11103
2012-10-05 18:12:48 -05:00
Nathan Guse
3f2e3ad633 [ticket/11103] Working on test case
Fixing extension type/method naming scheme so they can be autoloaded.

Other bugs

PHPBB3-11103
2012-10-05 00:07:48 -05:00
Nathan Guse
ceb56da965 [ticket/11103] Fixing a few bugs from the previous changes
PHPBB3-11103
2012-10-04 21:39:17 -05:00
Nathan Guse
ff136cc96a [ticket/11103] Do not use Symfony\...\ContainerBuilder;
It's no longer needed

PHPBB3-11103
2012-10-04 15:21:07 -05:00
Nathan Guse
cea94d8984 [ticket/11103] Use dependency injection instead of phpbb_container
PHPBB3-11103
2012-10-04 14:27:43 -05:00
Nathan Guse
64820546d7 [ticket/11103] Move notification files to includes/notification/
PHPBB3-11103
2012-10-04 13:42:52 -05:00
Renamed from phpBB/includes/notifications/service.php (Browse further)