Oleg Pudeyev
01eded7cc2
Merge PR #1388 branch 'dhruvgoel92/ticket/11288' into develop
...
# By Dhruv
# Via Dhruv
* dhruvgoel92/ticket/11288:
[ticket/11288] fix regex in postgres
[ticket/11288] add search tests cases
2013-05-06 15:46:00 -04:00
Dhruv
bfdc6e1930
[ticket/11288] fix regex in postgres
...
Postgres search backend now uses updated regex being used by
mysql search backend.
PHPBB3-11288
2013-05-04 20:11:12 +05:30
Nils Adermann
7320e4a535
Merge pull request #1348 from nickvergessen/ticket/11495
...
Ticket/11495 Nested Set Implementation
2013-05-02 15:04:19 -07:00
Joas Schilling
d7787682df
[ticket/11495] Throw exception when item that should be deleted does not exist
...
PHPBB3-11495
2013-04-30 22:19:35 +02:00
Joas Schilling
6a7378ecbd
[ticket/11495] Some more doc changes
...
PHPBB3-11495
2013-04-30 18:39:22 +02:00
Joas Schilling
2f54a63b0f
[ticket/11495] Fix more grammar issues in doc blocks
...
PHPBB3-11495
2013-04-30 18:24:54 +02:00
Joas Schilling
98e6207c35
[ticket/11495] Fix "as well" typo and remove brackets
...
PHPBB3-11495
2013-04-30 18:13:32 +02:00
Joas Schilling
5c4d69581a
[ticket/11495] Do not reset item_parent if not required
...
PHPBB3-11495
2013-04-30 18:06:29 +02:00
Joas Schilling
f3f7be4cd1
[ticket/11495] Fix @return doc of get_sql_where()
...
PHPBB3-11495
2013-04-30 17:11:55 +02:00
Joas Schilling
6055a3cc7e
[ticket/11495] Remove useless release_lock() method
...
PHPBB3-11495
2013-04-30 16:19:25 +02:00
Joas Schilling
78b0d3e723
[ticket/11495] Use $lock->owns_lock() instead of own property
...
PHPBB3-11495
2013-04-30 15:50:14 +02:00
Joas Schilling
714092ab4e
[ticket/11495] Add owns_lock() method to lock classes
...
PHPBB3-11495
2013-04-30 15:48:29 +02:00
Joas Schilling
055ee41065
[ticket/11495] Remove useless cast
...
PHPBB3-11495
2013-04-30 15:16:41 +02:00
Joas Schilling
529e4c00fb
[ticket/11495] Move lock code into two methods to allow easier handling
...
This also allows to simply remove the lock handling by overwriting the two
methods acquire_lock() and release_lock().
PHPBB3-11495
2013-04-30 15:15:50 +02:00
Joas Schilling
202484ebb4
[ticket/11495] Fix docs of add_item_to_nestedset() and take id as argument
...
PHPBB3-11495
2013-04-30 14:45:22 +02:00
Joas Schilling
863d0c7687
[ticket/11495] Fix some more comments and the package tag
...
PHPBB3-11495
2013-04-30 14:36:26 +02:00
Joas Schilling
87e8e60d3c
[ticket/11495] Correctly distinguish between children and descendants
...
PHPBB3-11495
2013-04-30 14:12:45 +02:00
Joas Schilling
67f2edae17
[ticket/11495] Use descendants and ancestors instead of parents/children
...
PHPBB3-11495
2013-04-30 13:58:03 +02:00
Joas Schilling
4810c61fd7
[ticket/11495] Remove get_parent_data from interface and rename it
...
The method is implementation specific and has no use, apart from cache, that is
not covered by get_path_data().
PHPBB3-11495
2013-04-30 10:37:59 +02:00
Joas Schilling
8a4260703f
[ticket/11495] Fix some docs and replace branch with other terms
...
PHPBB3-11495
2013-04-30 10:32:01 +02:00
Oleg Pudeyev
c182ab0e7b
Merge PR #1371 branch 'EXreaction/ticket/11236' into develop
...
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11236:
[ticket/11236] Change PRUNE_USERS_GROUP_EXPLAIN language
[ticket/11236] Do not require group selection in prune users
[ticket/11236] Correct HTML
2013-04-26 22:35:13 -04:00
Joas Schilling
2afa673023
[ticket/11495] Fix doc blocks once more
...
PHPBB3-11495
2013-04-26 08:42:44 +02:00
Joas Schilling
a9f02d1efa
[ticket/11495] Make method names for add/remove more descriptive
...
PHPBB3-11495
2013-04-26 00:04:58 +02:00
Joas Schilling
baff4287e5
[ticket/11495] Fix comments and package docs
...
PHPBB3-11495
2013-04-25 22:39:24 +02:00
Nathaniel Guse
1a16ee4cb2
[ticket/11236] Do not require group selection in prune users
...
PHPBB3-11236
2013-04-25 11:20:13 -05:00
Nathaniel Guse
ee457e584c
[ticket/11236] Correct HTML
...
PHPBB3-11236
2013-04-25 11:16:00 -05:00
Joas Schilling
0def8b7d9c
[ticket/11495] Use constructor arguments over properties in implementation
...
PHPBB3-11495
2013-04-25 18:09:21 +02:00
Nathaniel Guse
42cfb7264d
[ticket/11237] Fix PHP error in acp_prune.php
...
Also making the code a bit more efficient (removing one SQL query)
PHPBB3-11237
2013-04-25 10:58:48 -05:00
Joas Schilling
abfb7bc51f
[ticket/11495] Remove add/remove from the interface
...
PHPBB3-11495
2013-04-25 17:24:18 +02:00
Joas Schilling
73d8735484
[ticket/11495] Remove fixing function from tree interface
...
The fixing function is implementation dependent.
PHPBB3-11495
2013-04-25 17:19:52 +02:00
Joas Schilling
b334a2ce0f
[ticket/11495] Move classes to tree/ as they all implement a tree
...
PHPBB3-11495
2013-04-25 17:04:37 +02:00
Joas Schilling
c72f5bf487
[ticket/11495] Explain use of set_subset_zero on remove_subset()
...
PHPBB3-11495
2013-04-25 16:24:31 +02:00
Joas Schilling
804f139be0
[ticket/11495] Use default exceptions
...
PHPBB3-11495
2013-04-25 16:17:58 +02:00
Joas Schilling
9d7d962c0d
[ticket/11495] Explain what "given item" means
...
PHPBB3-11495
2013-04-25 14:08:06 +02:00
Joas Schilling
fe97915fc9
[ticket/11495] Split get_branch_data into multiple methods
...
PHPBB3-11495
2013-04-25 14:05:41 +02:00
Joas Schilling
ab7054445f
[ticket/11495] Rename set_parent to change_parent()
...
PHPBB3-11495
2013-04-25 13:48:19 +02:00
Joas Schilling
3efae6d8af
[ticket/11495] Explain whether move_children prepends/appends/overwrittes
...
PHPBB3-11495
2013-04-25 13:44:52 +02:00
Joas Schilling
4bff28a0ee
[ticket/11495] Rename fix function to regenerate_left_right_ids()
...
This method regenerates the left/right ids for the nested set based on the
parent/child relations. This function executes three queries per item, so
it should only be called, when the set has one of the following problems:
- The set has a duplicated value inside the left/right id chain
- The set has a missing value inside the left/right id chain
- The set has items that do not have a left/right is set
When regenerating the items, the items are sorted by parent id and their
current left id, so the current child/parent relationships are kept and
running the function on a working set will not change any orders.
PHPBB3-11495
2013-04-25 13:40:25 +02:00
Joas Schilling
61e72d3a10
[ticket/11495] Explain move() more
...
An item is only moved up/down within the same parent. If the delta is larger
then the number of children, the item is moved to the top/bottom of the list
of children within this parent.
PHPBB3-11495
2013-04-25 13:09:00 +02:00
Nils Adermann
7b144bbff2
Merge pull request #1369 from EXreaction/ticket/11335
...
Ticket/11335
2013-04-25 04:01:38 -07:00
Nils Adermann
6d0b183553
Merge pull request #1367 from EXreaction/ticket/11454
...
Ticket/11454 - Jabber notifications are not working at all
2013-04-25 03:59:34 -07:00
Joas Schilling
e8b192fa32
[ticket/11495] Do not compare to null anymore (left over from item class)
...
PHPBB3-11495
2013-04-25 12:57:21 +02:00
Nathaniel Guse
9c4553c41f
[ticket/11335] Replace "$phpEx" with $phpEx
...
PHPBB3-11335
2013-04-24 20:39:24 -05:00
Nathaniel Guse
0d2d72e8ee
[ticket/11454] Check if the fields are set
...
PHPBB3-11454
2013-04-24 20:28:35 -05:00
Nathan Guse
f49993766e
[ticket/11335] (more) Make php_ext 'php' not '.php'
...
PHPBB3-11335
2013-04-24 17:46:00 -05:00
Nathan Guse
14f1340903
[ticket/11335] (avatars) Make php_ext 'php' not '.php'
...
PHPBB3-11335
2013-04-24 17:45:46 -05:00
Nathan Guse
df70b6ebe6
[ticket/11335] (kernel request subscriber) Make php_ext 'php' not '.php'
...
PHPBB3-11335
2013-04-24 17:45:41 -05:00
Nathan Guse
fe89e56686
[ticket/11335] (hook finder) Make php_ext 'php' not '.php'
...
PHPBB3-11335
2013-04-24 17:45:39 -05:00
Nathan Guse
ce230f8dea
[ticket/11335] (extension manager/finder) Make php_ext 'php' not '.php'
...
PHPBB3-11335
2013-04-24 17:45:36 -05:00
Nathan Guse
6ef363547a
[ticket/11335] (controller/helper.php) Make php_ext 'php' not '.php'
...
PHPBB3-11335
2013-04-24 17:45:33 -05:00