Commit graph

16359 commits

Author SHA1 Message Date
Oleg Pudeyev
01eded7cc2 Merge PR #1388 branch 'dhruvgoel92/ticket/11288' into develop
# By Dhruv
# Via Dhruv
* dhruvgoel92/ticket/11288:
  [ticket/11288] fix regex in postgres
  [ticket/11288] add search tests cases
2013-05-06 15:46:00 -04:00
Oleg Pudeyev
ba01996e5a Merge PR #1389 branch 'EXreaction/ticket/11519' into develop
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11519:
  [ticket/11519] Rename test event template file
2013-05-06 15:12:44 -04:00
Nathaniel Guse
9608d9bf1e [ticket/11519] Rename test event template file
As requested by Oleg
https://github.com/phpbb/phpbb3/pull/1340#issuecomment-17306967

PHPBB3-11519
2013-05-04 11:45:49 -05:00
Dhruv
bfdc6e1930 [ticket/11288] fix regex in postgres
Postgres search backend now uses updated regex being used by
mysql search backend.

PHPBB3-11288
2013-05-04 20:11:12 +05:30
Dhruv
3a30bd2753 [ticket/11288] add search tests cases
PHPBB3-11288
2013-05-04 18:25:43 +05:30
Nils Adermann
7320e4a535 Merge pull request #1348 from nickvergessen/ticket/11495
Ticket/11495 Nested Set Implementation
2013-05-02 15:04:19 -07:00
Andreas Fischer
1dea12d607 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11517] Fix list numbering
2013-05-02 23:13:27 +02:00
Andreas Fischer
92e0613324 Merge remote-tracking branch 'hjpotter92/ticket/11517' into develop-olympus
* hjpotter92/ticket/11517:
  [ticket/11517] Fix list numbering
2013-05-02 23:12:39 +02:00
hjpotter92
6d4a75b3cb [ticket/11517] Fix list numbering
PHPBB3-11517
2013-05-02 06:29:32 +05:30
Oleg Pudeyev
954edb3eb4 Merge PR #1372 branch 'EXreaction/ticket/11435' into develop
# By Nathan Guse (2) and Nathaniel Guse (1)
# Via Nathaniel Guse
* EXreaction/ticket/11435:
  [ticket/11435] Mark extension spacing test as incomplete
  [ticket/11435] Create test to make sure template/event output is equal
  [ticket/11435] Fix comments in events test
2013-05-01 14:16:41 -04:00
Nathaniel Guse
356bc00a29 [ticket/11435] Mark extension spacing test as incomplete
This test fails until 11435 is fixed

Add newlines at EOF

PHPBB3-11435
2013-04-30 23:21:50 -05:00
Joas Schilling
d7787682df [ticket/11495] Throw exception when item that should be deleted does not exist
PHPBB3-11495
2013-04-30 22:19:35 +02:00
Joas Schilling
6a7378ecbd [ticket/11495] Some more doc changes
PHPBB3-11495
2013-04-30 18:39:22 +02:00
Joas Schilling
d1d59dc5cc [ticket/11495] Remove unneccessary values from tests
PHPBB3-11495
2013-04-30 18:33:28 +02:00
Joas Schilling
2f54a63b0f [ticket/11495] Fix more grammar issues in doc blocks
PHPBB3-11495
2013-04-30 18:24:54 +02:00
Joas Schilling
98e6207c35 [ticket/11495] Fix "as well" typo and remove brackets
PHPBB3-11495
2013-04-30 18:13:32 +02:00
Joas Schilling
fe02218a2d [ticket/11495] Remove forum_parents from tests where it is not required
PHPBB3-11495
2013-04-30 18:11:24 +02:00
Joas Schilling
5c4d69581a [ticket/11495] Do not reset item_parent if not required
PHPBB3-11495
2013-04-30 18:06:29 +02:00
Joas Schilling
39ff3ed15f [ticket/11495] Add proper testing of item_parent to tests
PHPBB3-11495
2013-04-30 18:05:44 +02:00
Joas Schilling
f3f7be4cd1 [ticket/11495] Fix @return doc of get_sql_where()
PHPBB3-11495
2013-04-30 17:11:55 +02:00
Joas Schilling
6055a3cc7e [ticket/11495] Remove useless release_lock() method
PHPBB3-11495
2013-04-30 16:19:25 +02:00
Joas Schilling
78b0d3e723 [ticket/11495] Use $lock->owns_lock() instead of own property
PHPBB3-11495
2013-04-30 15:50:14 +02:00
Joas Schilling
714092ab4e [ticket/11495] Add owns_lock() method to lock classes
PHPBB3-11495
2013-04-30 15:48:29 +02:00
Joas Schilling
055ee41065 [ticket/11495] Remove useless cast
PHPBB3-11495
2013-04-30 15:16:41 +02:00
Joas Schilling
529e4c00fb [ticket/11495] Move lock code into two methods to allow easier handling
This also allows to simply remove the lock handling by overwriting the two
methods acquire_lock() and release_lock().

PHPBB3-11495
2013-04-30 15:15:50 +02:00
Joas Schilling
202484ebb4 [ticket/11495] Fix docs of add_item_to_nestedset() and take id as argument
PHPBB3-11495
2013-04-30 14:45:22 +02:00
Joas Schilling
863d0c7687 [ticket/11495] Fix some more comments and the package tag
PHPBB3-11495
2013-04-30 14:36:26 +02:00
Joas Schilling
87e8e60d3c [ticket/11495] Correctly distinguish between children and descendants
PHPBB3-11495
2013-04-30 14:12:45 +02:00
Joas Schilling
67f2edae17 [ticket/11495] Use descendants and ancestors instead of parents/children
PHPBB3-11495
2013-04-30 13:58:03 +02:00
Joas Schilling
4810c61fd7 [ticket/11495] Remove get_parent_data from interface and rename it
The method is implementation specific and has no use, apart from cache, that is
not covered by get_path_data().

PHPBB3-11495
2013-04-30 10:37:59 +02:00
Joas Schilling
8a4260703f [ticket/11495] Fix some docs and replace branch with other terms
PHPBB3-11495
2013-04-30 10:32:01 +02:00
Oleg Pudeyev
c182ab0e7b Merge PR #1371 branch 'EXreaction/ticket/11236' into develop
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11236:
  [ticket/11236] Change PRUNE_USERS_GROUP_EXPLAIN language
  [ticket/11236] Do not require group selection in prune users
  [ticket/11236] Correct HTML
2013-04-26 22:35:13 -04:00
Oleg Pudeyev
efd9e331bc Merge PR #1370 branch 'EXreaction/ticket/11237' into develop
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11237:
  [ticket/11237] Fix PHP error in acp_prune.php
2013-04-26 22:34:55 -04:00
Joas Schilling
2afa673023 [ticket/11495] Fix doc blocks once more
PHPBB3-11495
2013-04-26 08:42:44 +02:00
Joas Schilling
a9f02d1efa [ticket/11495] Make method names for add/remove more descriptive
PHPBB3-11495
2013-04-26 00:04:58 +02:00
Nathaniel Guse
c057141ea6 Merge remote-tracking branch 'remotes/cyberalien/ticket/11275' into develop 2013-04-25 16:33:30 -05:00
Nathaniel Guse
ad1a4919d6 Merge remote-tracking branch 'remotes/cyberalien/ticket/4412' into develop 2013-04-25 16:21:14 -05:00
Joas Schilling
baff4287e5 [ticket/11495] Fix comments and package docs
PHPBB3-11495
2013-04-25 22:39:24 +02:00
Nathan Guse
ab87fe7982 [ticket/11435] Create test to make sure template/event output is equal
PHPBB3-11435
2013-04-25 15:26:59 -05:00
Nathan Guse
6801e36def [ticket/11435] Fix comments in events test
PHPBB3-11435
2013-04-25 15:26:59 -05:00
Nathaniel Guse
e7cb0f687d [ticket/11236] Change PRUNE_USERS_GROUP_EXPLAIN language
PHPBB3-11236
2013-04-25 11:23:09 -05:00
Nathaniel Guse
1a16ee4cb2 [ticket/11236] Do not require group selection in prune users
PHPBB3-11236
2013-04-25 11:20:13 -05:00
Nathaniel Guse
ee457e584c [ticket/11236] Correct HTML
PHPBB3-11236
2013-04-25 11:16:00 -05:00
Joas Schilling
0def8b7d9c [ticket/11495] Use constructor arguments over properties in implementation
PHPBB3-11495
2013-04-25 18:09:21 +02:00
Nathaniel Guse
42cfb7264d [ticket/11237] Fix PHP error in acp_prune.php
Also making the code a bit more efficient (removing one SQL query)

PHPBB3-11237
2013-04-25 10:58:48 -05:00
Joas Schilling
ce07b27765 [ticket/11495] Fix failing unit tests
PHPBB3-11495
2013-04-25 17:27:33 +02:00
Joas Schilling
abfb7bc51f [ticket/11495] Remove add/remove from the interface
PHPBB3-11495
2013-04-25 17:24:18 +02:00
Joas Schilling
73d8735484 [ticket/11495] Remove fixing function from tree interface
The fixing function is implementation dependent.

PHPBB3-11495
2013-04-25 17:19:52 +02:00
Joas Schilling
d4b7708d4b [ticket/11495] Remove tests for add/remove we make them protected later
PHPBB3-11495
2013-04-25 17:19:21 +02:00
Joas Schilling
499dd3a833 [ticket/11495] Move tests to tree/ directory
PHPBB3-11495
2013-04-25 17:13:21 +02:00