makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity
17739 commits 18 branches 192 tags 207 MiB
Commit graph

17739 commits

This branch
This branch
All branches
Author SHA1 Message Date
Andy Chase
6f8187f7fa [ticket/11620] Reworked create_test without data provider 
PHPBB3-11620
 2013-07-05 14:10:04 -07:00
Andy Chase
521d35dd6e [ticket/11620] Add create_test with test for bot detection 
Added a test for the creation of a session with a simple test
for detecting whether a bot is present.

PHPBB3-11620
 2013-07-05 14:10:02 -07:00
Andy Chase
7ef95ce8ac [ticket/11620] Fix typo and confusingly named test 
PHPBB3-11620
 2013-07-05 14:10:01 -07:00
Andy Chase
ab1c42babf [ticket/11620] Add indentation, change quote style. 
indentation is probably more important than 80 characters per line apparently.
Single quotes instead of double per coding guidelines.

PHPBB3-11620
 2013-07-05 14:10:00 -07:00
Andy Chase
290533a14f [ticket/11620] Add validate_referrer test 
Add a test for the validate_referrer function.

PHPBB3-11620
 2013-07-05 14:09:58 -07:00
Andy Chase
30ebc03d14 [ticket/11620] Remove unneeded functions from testable facade 
There are functions listed in testable facade that don't have a lot of dependencies,
instead mostly just take the input and perform database functions on them.
These can be tested without a testable facade function and so will be removed.

PHPBB3-11620
 2013-07-05 14:09:57 -07:00
Andy Chase
17890a308b [ticket/11620] Add ipv6 test cases and remove extra arguments. 
PHPBB3-11620
 2013-07-05 14:09:56 -07:00
Andy Chase
2f92c903e7 [ticket/11620] Make testable_facade non-static, expand. 
Make the class functions of testable_facade no longer static methods,
but a class based one and expand the methods to be filled in, in later commits.

PHPBB3-11620
 2013-07-05 14:09:54 -07:00
Andy Chase
e8facfc735 [ticket/11620] Add commas in extract_page_test 
PHPBB3-11620
 2013-07-05 14:09:53 -07:00
Andy Chase
71fbe74ede [ticket/11620] Fix quotes in extract_hostname_test 
PHPBB3-11620
 2013-07-05 14:09:52 -07:00
Andy Chase
b8d9d7b79f [ticket/11620] Add extract_current_hostname 
Add a tests for extracting the current hostname from session.

PHPBB3-11620
 2013-07-05 14:09:50 -07:00
Andy Chase
7fd03abcab [ticket/11620] Add data provider to extract_page 
These test cases were taken from a live session,
more test cases should be added to test specific
functionality in this function.

PHPBB3-11620
 2013-07-05 14:09:49 -07:00
Andy Chase
9f156e9954 [ticket/11620] Rename class_functions_test -> extract_page_test 
Renaming this file because it is going to contain a large data provider,
so I'd rather split this test out.

PHPBB3-11620
 2013-07-05 14:09:48 -07:00
Andy Chase
e1d957c3ee [ticket/11620] Remove accidental argument from testable_facade. 
PHPBB3-11620
 2013-07-05 14:09:46 -07:00
Andy Chase
19a348e359 [ticket/11620] Add test for test_extract_current_page 
PHPBB3-11620
 2013-07-05 14:09:45 -07:00
Andy Chase
1d9d22cc76 [ticket/11620] Add testable facade for sessions.php 
Since many functions in session.php have global variables inside the function,
this exposes those functions through a testable facade that uses testable_factory's
mock global variables to modify global variables used in the functions.

 This is using the facade pattern to provide a testable "front" to the functions in sessions.php.

 PHPBB3-11620
 2013-07-05 14:09:44 -07:00
Nathan Guse
921d44aa4d [feature/twig] Put $SCRIPTS below overall_footer_after, use includejs for core 
Moved below overall_footer_after so events can add JS files in that event.

PHPBB3-11598
 2013-07-05 14:17:46 -05:00
Nathan Guse
8d11a147f5 [feature/twig] Use Twig mask for IF statements instead of our own tokenparser 
PHPBB3-11598
 2013-07-05 14:10:57 -05:00
Nathan Guse
0ffbdc80d1 [feature/twig] context_recursive_loop_builder isn't used anymore, removing it 
PHPBB3-11598
 2013-07-05 13:15:10 -05:00
Nathan Guse
c5c34ff831 [feature/twig] Add check for defined IN_PHPBB in all new Twig related files 
PHPBB3-11598
 2013-07-05 13:10:35 -05:00
Nathan Guse
99ddbe1adc [feature/twig] Can't use typehint here, causes tests to fail 
PHPBB3-11598
 2013-07-05 12:55:32 -05:00
Nathan Guse
9ac61565fd [feature/twig] Add template tests for S_NUM_ROWS and S_BLOCK_NAME 
PHPBB3-11598
 2013-07-05 12:48:02 -05:00
Nathan Guse
05984be2c0 [feature/twig] Fix S_NUM_ROWS assignment 
PHPBB3-11598
 2013-07-05 12:47:50 -05:00
Nathan Guse
13c3565454 [feature/twig] Remove style dependency for controller helper 
If a controller wants to use set_style, it can just use phpbb_style

PHPBB3-11598
 2013-07-05 12:11:59 -05:00
Nathan Guse
1f4a717f9e [feature/twig] Add template test for ===, !== 
PHPBB3-11598
 2013-07-05 10:29:24 -05:00
Nathan Guse
81f0715b8e [feature/twig] Clarify comment 
PHPBB3-11598
 2013-07-05 10:05:20 -05:00
Nathan Guse
2674740573 [feature/twig] Spacing 
PHPBB3-11598
 2013-07-05 10:03:48 -05:00
Nathan Guse
c1a600277d [feature/twig] Nicer code for get_user_style.php() 
PHPBB3-11598
 2013-07-05 09:57:55 -05:00
Nathan Guse
576d8d7072 [feature/twig] Docs/typehinting for Twig extension 
PHPBB3-11598
 2013-07-05 09:56:25 -05:00
Nathan Guse
192c9d8f86 [feature/twig] Removing template/renderer.php (no longer used) 
PHPBB3-11598
 2013-07-05 09:37:40 -05:00
Andreas Fischer
4aef3d0ab9 Merge remote-tracking branch 'Hardolaf/feature/auth-refactor' into develop 
* Hardolaf/feature/auth-refactor:
  [feature/auth-refactor] Move auth providers to separate directory
 2013-07-05 16:06:07 +02:00
Joseph Warner
5746c8d96f [feature/auth-refactor] Move auth providers to separate directory 
Moves the provider files to their own directory per bantu's
suggestion.

PHPBB3-9734
 2013-07-04 17:14:19 -04:00
Nathaniel Guse
25b4732845 [feature/twig] Remove debug code 
PHPBB3-11598
 2013-07-04 15:32:04 -05:00
Nathaniel Guse
0f3086a54b [feature/twig] Spacing 
PHPBB3-11598
 2013-07-04 15:24:42 -05:00
Nathaniel Guse
53496e6a47 [feature/twig] acp module tpls are in ext/adm, ucp/mcp in styles/ 
PHPBB3-11598
 2013-07-04 15:21:57 -05:00
Marc Alexander
5afcb1d5f4 [ticket/11600] Remove duplicate test case 
PHPBB3-11600
 2013-07-04 21:15:02 +02:00
Nathaniel Guse
38700a80f8 [feature/twig] Fix copy/pasted code 
PHPBB3-11598
 2013-07-04 14:09:50 -05:00
Nathaniel Guse
24be216366 [feature/twig] Attempt to automatically set style dir for ext modules 
Extension authors can change it themselves if necessary

PHPBB3-11598
 2013-07-04 13:49:56 -05:00
Nathaniel Guse
8cf6dbd950 [feature/twig] Trying some new debug code for this mkdir error 
PHPBB3-11598
 2013-07-04 13:40:37 -05:00
Nathaniel Guse
fdbdd8bfd9 [feature/twig] Fix a regular expression 
PHPBB3-11598
 2013-07-04 13:22:41 -05:00
Nathaniel Guse
4f6cb9acbd [feature/twig] Fix helper URL test 
PHPBB3-11598
 2013-07-04 13:19:21 -05:00
Nathaniel Guse
864465761f [feature/twig] Fix debug code 
PHPBB3-11598
 2013-07-04 13:19:03 -05:00
Nathaniel Guse
5f03321fac [feature/twig] Support using Twig filters on {VAR}, add masks for Twig tags 
Now we can do {L_TITLE|upper}, {SITENAME|lower}, etc

We can also use all the Twig tags in our own syntax. E.g. <!-- BLOCK foo -->
= {% block foo %]. All tags are the same as the Twig tag names, but are
in uppercase.

PHPBB3-11598
 2013-07-04 12:44:12 -05:00
Nathaniel Guse
35b628f737 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into feature/twig 
# By Joseph Warner (44) and others
# Via Joas Schilling (4) and others
* 'develop' of https://github.com/phpbb/phpbb3: (63 commits)
  [ticket/11617] Remove spaces and tabs from empty lines
  [ticket/11617] Missing U_ACTION in acp_captcha.php
  [feature/auth-refactor] Fix code style issue
  [feature/auth-refactor] Fix comment grammar
  [feature/auth-refactor] Fix the actual cause of test failures
  [feature/auth-refactor] A possible fix for the functional test failures
  [ticket/11566] Subsilver template error displayed after table headers
  [ticket/11566] Remove extra pair of brackets from conditional statement
  [ticket/11566] Check that guest doesn't have reporting permission by default
  [ticket/11566] Add captcha to report post template in subsilver
  [ticket/11566] Use the new constant CONFIRM_REPORT for captcha init
  [ticket/11566] Rename var to $visual_confirmation_response
  [ticket/11566] Revert forum permission changes
  [ticket/11566] Use language variable instead of hardcode
  [ticket/11566] add tests for reporting post
  [ticket/11566] add captcha reset and hidden fields
  [ticket/11566] display error instead of trigger_error
  [ticket/11566] add error in template
  [ticket/11566] add error functionality
  [ticket/11566] add interface for captcha
  ...
 2013-07-04 11:19:10 -05:00
Nathaniel Guse
b7ede06835 [feature/twig] Make style dependency optional for resolver 
PHPBB3-11598
 2013-07-04 11:16:44 -05:00
Nathaniel Guse
1ce33c1ff6 [feature/twig] Safety check for 2fb48d6 
PHPBB3-11598
 2013-07-04 11:12:26 -05:00
Nathaniel Guse
bb56c1a391 Revert "[feature/twig] Call set_style in the foo/bar controller for functional tests" 
This reverts commit 5c39f26cd2.
 2013-07-04 11:09:33 -05:00
Nathaniel Guse
2fb48d60f1 [feature/twig] Attempt to automatically set style dir for ext controllers 
Extension authors can change it themselves if necessary

PHPBB3-11598
 2013-07-04 11:08:36 -05:00
Nathaniel Guse
81f27fd87e [feature/twig] Add test to make sure nested loops get the correct S_ROW_COUNT 
PHPBB3-11598
 2013-07-04 10:40:14 -05:00
Nathaniel Guse
84e0943c7b [feature/twig] Indentation and comments 
PHPBB3-11598
 2013-07-04 10:22:12 -05:00