Upload filenames are already processed via htmlspecialchars in the
type_cast_helper of the new request class. There is no need to run it through
htmlspecialchars() again in the filespec class.
PHPBB3-12211
When you click on the link, the turning circle is missing, so you don't
know whether it is actually doing something or not, until the response is
served.
PHPBB3-12351
The symfony routing component allows us to use the path "/" for routes.
Therefore, we should be able to use example.com/app.php/ for controllers.
However, this currently does not properly work. The method get_web_root_path
incorrectly returns phpbb_root_path. Therefore, paths to images or files are
broken.
PHPBB3-12004
* develop-ascraeus:
[ticket/12386] Rename DEBUG_EXTRA to DEBUG_CONTAINER for more descriptive name
[ticket/12386] Add DEBUG_EXTRA again and use it for container creation
* marc/ticket/12386:
[ticket/12386] Rename DEBUG_EXTRA to DEBUG_CONTAINER for more descriptive name
[ticket/12386] Add DEBUG_EXTRA again and use it for container creation
We are currently creating a new compiled container on every page load when
having DEBUG enabled. However, one might only have that enabled to be
presented with errors or for getting the page load stats.
This change will add the DEBUG_EXTRA constant again. It will be used for
choosing whether the compiled container should be created on every page load -
when defined as true - or just once after the cache is cleared.
PHPBB3-12386
* develop-ascraeus:
[ticket/12377] Forgot to change the INCLUDEs
[ticket/12377] Renamed template files to navbar_xxx
[ticket/12377] Moved notifications to new template
[ticket/12377] Forgot empty line at the end
[ticket/12377] Move navbar(s) to new template file
* paybas/ticket/12377:
[ticket/12377] Forgot to change the INCLUDEs
[ticket/12377] Renamed template files to navbar_xxx
[ticket/12377] Moved notifications to new template
[ticket/12377] Forgot empty line at the end
[ticket/12377] Move navbar(s) to new template file
* vsephpbb/ticket/12380:
[ticket/12380] Explicity state the order of sorting for login keys
[ticket/12380] Sort Remember Me keys by last login time in UCP
The Topic Tools menu appears at the top of a topic page and again at the
bottom of a topic page.
When you use the Topic Tools menu to Bookmark or Subscribe to a Topic, the
menu item you chose is updated to reflect that, by switching to say
Unsubscribe topic or Remove from Bookmarks.
However, this change is not mirrored in the other Topic Tools menu at the
other location on the page.
Both Topic Tools menus should be updated during the AJAX event, so that
they always show the same options to the user.
It is solved by creating a data-update-all attribute which contains all
the class/ID that will update when topic tool is clicked
PHPBB3-12355
* develop-ascraeus:
[ticket/12370] Add unit tests for topic notifications
[ticket/12370] Fix functional notification test and remove unneeded requests
[ticket/12370] Do not delete topic notifications when the topic is visible
* github-nickvergessen/ticket/12370:
[ticket/12370] Add unit tests for topic notifications
[ticket/12370] Fix functional notification test and remove unneeded requests
[ticket/12370] Do not delete topic notifications when the topic is visible
* develop-ascraeus:
[ticket/12113] Fix view_log() tests
[ticket/12113] Correctly use plurals when deleting user warnings
[ticket/12113] Allow log entries to use plurals
* github-nickvergessen/ticket/12113:
[ticket/12113] Fix view_log() tests
[ticket/12113] Correctly use plurals when deleting user warnings
[ticket/12113] Allow log entries to use plurals
* develop-ascraeus:
[ticket/12331] Add functional test for saving custom profile fields
[ticket/12331] Fix SQL error when inserting a new entry to profile field data
* github-nickvergessen/ticket/12331:
[ticket/12331] Add functional test for saving custom profile fields
[ticket/12331] Fix SQL error when inserting a new entry to profile field data
* develop-ascraeus:
[ticket/12286] Reword section about plurals
[ticket/12286] Fix spelling of elephant(s) in the sample
[ticket/12286] Correctly capitalize PHP
[ticket/12286] Fix nesting of ul inside li element
[ticket/12286] Add note that goto should not be used
[ticket/12286] Add section about plurals to the coding guidelines
[ticket/12286] Classes must use the name space
[ticket/12286] Remove section about utf8_normalize_nfc()
[ticket/12286] Use $request->variable() instead of request_var()
[ticket/12286] Function names should be prefixed with phpbb_
[ticket/12286] Add "Since" to template event docs
[ticket/12286] style.php and imagesets dont exist anymore
[ticket/12286] Styles have a phpbb_version and a style_version in 3.1
[ticket/12286] Use UTF8 (c) in style.cfg samples
* github-nickvergessen/ticket/12286:
[ticket/12286] Reword section about plurals
[ticket/12286] Fix spelling of elephant(s) in the sample
[ticket/12286] Correctly capitalize PHP
[ticket/12286] Fix nesting of ul inside li element
[ticket/12286] Add note that goto should not be used
[ticket/12286] Add section about plurals to the coding guidelines
[ticket/12286] Classes must use the name space
[ticket/12286] Remove section about utf8_normalize_nfc()
[ticket/12286] Use $request->variable() instead of request_var()
[ticket/12286] Function names should be prefixed with phpbb_
[ticket/12286] Add "Since" to template event docs
[ticket/12286] style.php and imagesets dont exist anymore
[ticket/12286] Styles have a phpbb_version and a style_version in 3.1
[ticket/12286] Use UTF8 (c) in style.cfg samples
* develop-ascraeus:
[ticket/12282] Update new references
[ticket/12282] Update container db mock
[ticket/12282] Add new line at EOF of the interface
[ticket/12282] Use interface for type hinting
[ticket/12282] Use {@inheritDoc} for inherited methods
[ticket/12282] Add Interface for DBAL drivers
* github-nickvergessen/ticket/12282:
[ticket/12282] Update new references
[ticket/12282] Update container db mock
[ticket/12282] Add new line at EOF of the interface
[ticket/12282] Use interface for type hinting
[ticket/12282] Use {@inheritDoc} for inherited methods
[ticket/12282] Add Interface for DBAL drivers
* develop-ascraeus:
[ticket/11352] Add functional tests for disapproving a post/topic
[ticket/11352] Redirect the user back to view*.php after disapproving
* github-nickvergessen/ticket/11352:
[ticket/11352] Add functional tests for disapproving a post/topic
[ticket/11352] Redirect the user back to view*.php after disapproving
