makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-23 11:48:52 +00:00
Code Issues Projects Releases Packages Wiki Activity
13165 commits 18 branches 192 tags 207 MiB
Commit graph

13165 commits

This branch
This branch
All branches
Author SHA1 Message Date
Nils Adermann
0b11951412 - adding tests for the new request class and extending the tests for request_var to include deep direct access to multidimensional arrays and arbitrary number of dimensions 
git-svn-id: file:///svn/phpbb/trunk@9105 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-24 00:28:57 +00:00
Nils Adermann
c8cba06910 - updated security/redirect test to use new framework functionality 
git-svn-id: file:///svn/phpbb/trunk@9104 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-24 00:27:18 +00:00
Nils Adermann
bcfcf9b048 - added phpBB test framework which is an extension with some additional 
functionality of PHPUnit
- first addition: setExpectedTriggerError() if a test expects a call
  to trigger_error().

git-svn-id: file:///svn/phpbb/trunk@9103 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-24 00:24:46 +00:00
Nils Adermann
07e9b83a3d - updated all code to use the request class instead of any direct access to 
super globals
- disabled super globals in common.php. See commit r9101 for
  more information
- cleaned up/simplified a few lines along the way.

git-svn-id: file:///svn/phpbb/trunk@9102 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-24 00:20:33 +00:00
Nils Adermann
8427ae3fd4 Introducing the new request class. All input his handled through this class. 
"Given a choice between dancing pigs and security, users will pick
          dancing pigs every time." (Gary McGraw and Edward Felten)

What stays the same?
- request_var() keeps working as it used to, alternatively you can directly use
  request::variable() which allows choosing which super global you want to read

So what's new?
- request::disable_super_globals() which disables super globals. This
  function causes any direct use of $_POST, $_GET, $_REQUEST or $_COOKIE to
  result in an E_USER_ERROR. We hope that this will force MOD authors to at
  least think about validation as they will have to read about how to use the
  request class.
- request::is_set() / request::is_set_post will be used instead of using isset
  directly on super globals
- request_var() now supports arrays with arbitrary depth
- request_var() can be used with an array as the variable name to directly
  access values in mutli dimensional arrays.

What's next?
- request::disable_super_globals() will be active by default (set in
  common.php)
- all code will be adjusted to use the new class consistently
- tests for the request class to make sure it works as designed and will not
  change behaviour between releases

I've also already updated all the code within functions.php to use the request class.

git-svn-id: file:///svn/phpbb/trunk@9101 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 23:43:00 +00:00
Chris Smith
6e2d2f85b5 More tests 
git-svn-id: file:///svn/phpbb/trunk@9100 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 22:39:31 +00:00
Chris Smith
500eb05c48 test advanced loop constructs 
git-svn-id: file:///svn/phpbb/trunk@9099 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 19:51:52 +00:00
Chris Smith
3f11fc12ac S_NUM_ROWS gives you the number of rows in a block 
git-svn-id: file:///svn/phpbb/trunk@9098 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 16:07:36 +00:00
Chris Smith
aa3a2f565b Why did I not do it this way to begin with :) 
git-svn-id: file:///svn/phpbb/trunk@9097 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 16:01:33 +00:00
Meik Sievertsen
3bd6984785 [Change] Alllow applications to set custom module inclusion path (idea by HoL) 
git-svn-id: file:///svn/phpbb/trunk@9096 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 12:45:22 +00:00
Meik Sievertsen
9a7d2a3736 [Change] Alllow applications to set custom module inclusion path (idea by HoL) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9095 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 12:42:34 +00:00
Chris Smith
dcf0b15c9f Will he ever be happy? ... 
git-svn-id: file:///svn/phpbb/trunk@9094 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 03:50:16 +00:00
Chris Smith
ff22d7a368 Refactor and fix :) 
git-svn-id: file:///svn/phpbb/trunk@9093 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 03:41:54 +00:00
Chris Smith
f4c079a62b Run template tests over non-cached data as well 
git-svn-id: file:///svn/phpbb/trunk@9092 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 01:55:12 +00:00
Chris Smith
d26f38c4e0 all 557 tests pass now :D 
git-svn-id: file:///svn/phpbb/trunk@9091 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 01:08:08 +00:00
Chris Smith
f1b1d0c839 Make searching for members by YIM address work in prosilver 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9090 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 00:37:30 +00:00
Chris Smith
99fa62267e Fix r9088 
git-svn-id: file:///svn/phpbb/trunk@9089 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 00:10:48 +00:00
Chris Smith
74121b41fa Fix a tiny bug 
git-svn-id: file:///svn/phpbb/trunk@9088 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-23 00:09:34 +00:00
Chris Smith
416270ee77 - Deprecate S_ROW_COUNT use S_ROW_NUM 
- S_ROW_NUM, S_FIRST_ROW, S_LAST_ROW are now using internal template engine variables saving memory
- Other small changes
- Update of template tests


git-svn-id: file:///svn/phpbb/trunk@9087 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 23:53:40 +00:00
Nils Adermann
efe06af913 - merge r9084 and r9085 
- added tests for make_clickable

git-svn-id: file:///svn/phpbb/trunk@9086 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 23:25:57 +00:00
Nils Adermann
81a1803c43 better fix for (Bug #37055) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9085 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 23:17:05 +00:00
Nils Adermann
dcea9f082a - Properly treat punctuation marks after local urls [Bug #37055] 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9084 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 21:18:35 +00:00
Meik Sievertsen
04f7c1da69 Only display special ranks to guests; no longer display normal ranks for guests (Bug #36735) 
[changed parameters for get_user_rank(), breaks backward compatibility]

git-svn-id: file:///svn/phpbb/trunk@9083 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 20:26:47 +00:00
Meik Sievertsen
e02c3e3b4a Only display special ranks to guests; no longer display normal ranks for guests (Bug #36735) 
[a bit ugly, but retains backward compatibility]

git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9082 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 20:26:09 +00:00
Meik Sievertsen
a9274f1d63 define cookie var for styleswitcher.js for popups (Bug #36765) 
git-svn-id: file:///svn/phpbb/trunk@9081 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 20:05:24 +00:00
Meik Sievertsen
d2f4a17ebf define cookie var for styleswitcher.js for popups (Bug #36765) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9080 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 20:03:47 +00:00
Meik Sievertsen
08bd36f0b2 Do not try to send jabber notifications if no jid entered (Bug #36775) 
git-svn-id: file:///svn/phpbb/trunk@9079 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 19:58:08 +00:00
Meik Sievertsen
c831a3edce Do not try to send jabber notifications if no jid entered (Bug #36775) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9078 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 19:55:00 +00:00
Meik Sievertsen
d46e8e6f98 merge revisions i missed... hopefully not breaking things - did not check every change. 
git-svn-id: file:///svn/phpbb/trunk@9077 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 19:38:25 +00:00
Meik Sievertsen
f588f58fa9 small adjustement... only add an empty array if cached data is empty (from 3.2.x) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9076 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 19:06:42 +00:00
Meik Sievertsen
127750f89d Do not display COPPA group in memberlist find member dialog if COPPA disabled (Bug #37175) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9075 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 18:13:18 +00:00
Chris Smith
47b4b83468 Merge in r9065 
git-svn-id: file:///svn/phpbb/trunk@9074 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 18:03:04 +00:00
Meik Sievertsen
3d9eb90d72 make sure phpbb_chmod is able to be called 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9073 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 18:00:45 +00:00
Meik Sievertsen
7d1e8ed70e Fix header list build for replying oldest PM in PM history (Bug #37275) 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9072 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 17:53:27 +00:00
Meik Sievertsen
cf2a0852ca add the first fixed bugs from after the release 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9071 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-22 17:21:01 +00:00
Henry Sudhof
72662eeb04 changelog, up indexes 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9070 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-21 14:11:49 +00:00
Henry Sudhof
d24a82aaac changelog for 9067 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9069 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-21 14:01:58 +00:00
Henry Sudhof
c8e3035a4b Merge R 9067 
git-svn-id: file:///svn/phpbb/trunk@9068 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-21 13:46:39 +00:00
Henry Sudhof
bbfe3b0b7b 37375 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9067 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-21 13:21:53 +00:00
Chris Smith
4a38e5cc3f Before we forget 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9066 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-14 02:01:04 +00:00
Chris Smith
b9bf3dafd3 Fix a bug in r8908 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9065 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-13 17:32:55 +00:00
Chris Smith
ef0c0d4c82 been a while :( ... merge in r8997, r8998, r8999, r9000, r9001, r9002, r9003, r9004, r9005, r9007, r9008, r9009, r9010, r9011, r9012, r9013, r9014, r9015, r9022, r9023, r9029, r9030, r9034, r9048, r9049, r9054, r9056 
git-svn-id: file:///svn/phpbb/trunk@9064 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-13 13:04:54 +00:00
Henry Sudhof
9d4e7aeab1 problems with case handling #36725 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9063 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-13 12:56:24 +00:00
Henry Sudhof
1739da9335 Merging R9051 and R 9052 
git-svn-id: file:///svn/phpbb/trunk@9062 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-13 11:46:49 +00:00
Henry Sudhof
36635929a8 #36695 
git-svn-id: file:///svn/phpbb/trunk@9061 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-13 11:45:40 +00:00
Henry Sudhof
2e2ec887d7 #36695 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9060 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-13 11:38:14 +00:00
Meik Sievertsen
615b0d4e37 3.0.3 tag 
git-svn-id: file:///svn/phpbb/tags/release_3_0_3@9059 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-12 21:06:22 +00:00
Meik Sievertsen
40fa01b9f0 gah, forgot this tiny little thing... 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9058 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-12 20:26:36 +00:00
Henry Sudhof
d143032995 inheritance is reflexive 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9057 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-10 16:24:18 +00:00
Chris Smith
2b477bad8f Provide a way to disable the config write check and rename the ACP style editor disable constant 
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9056 89ea8834-ac86-4346-8a33-228a782c2dd0
 2008-11-09 19:38:44 +00:00