Commit graph

355 commits

Author SHA1 Message Date
Joas Schilling
54b0ebc410 Merge pull request #2862 from marc1706/ticket/12932
[ticket/12932] Add method for allowing override of \phpbb\datetime class

* marc1706/ticket/12932:
  [ticket/12932] Remove set_datetime_class method from user class
  [ticket/12932] Fix tests and calls to create_datetime
  [ticket/12932] Add method for getting the datetime class and allow overriding
2014-08-10 15:23:15 +02:00
Dhruv
0244a9b6a4 [ticket/12950] Force the installer to use language=en
PHPBB3-12950
2014-08-10 13:49:42 +02:00
Marc Alexander
8d99b4afe1 [ticket/12932] Fix tests and calls to create_datetime
PHPBB3-12932
2014-08-10 13:43:04 +02:00
Dhruv
dd8adb5d6e [ticket/11528] Revert Mink changes
PHPBB3-11528
2014-08-09 17:18:33 +02:00
Tristan Darricau
67d19920c4 [ticket/11480] Fix unit tests
PHPBB3-11480
2014-07-31 15:36:42 +02:00
Tristan Darricau
702d567c69 Merge branch 'ticket/11480' into ticket/11480-ascraeus
* ticket/11480:
  [ticket/11480] Move the test into get_folder()
  [ticket/11480] Fix the double spaces in phpbb_functional_test_case
  [ticket/11480] Fix typos
  [ticket/11480] Add functionnal test
  [ticket/11480] PM : "Unknown folder" returned when inbox folder is full

Conflicts:
	tests/test_framework/phpbb_functional_test_case.php
2014-07-30 21:01:05 +02:00
Tristan Darricau
c4cd1c58c1 [ticket/12844] Don't clear $dbpasswd early in connection manager
PHPBB3-12844
2014-07-13 00:25:25 +02:00
Andreas Fischer
b2a883d504 Merge pull request #2671 from Nicofuma/ticket/12775
[ticket/12775] Replace functions_container with a container_builder class.

* Nicofuma/ticket/12775: (34 commits)
  [ticket/12775] Set dbal.conn.driver as synthetic during installation
  [ticket/12775] Add the definition of dbal.conn in fixtures/config/services.yml
  [ticket/12775] Inject the connection when created in the container
  [ticket/12775] Extract the vars later in install/install_update.php
  [ticket/12775] Rename config_php_handler to config_php_file container_builder
  [ticket/12775] Set defined_vars as a property of config_php_file
  [ticket/12775] Fix doc blocks in the container builder
  [ticket/12775] Remove useless includes of config.php
  [ticket/12775] Move phpbb_convert_30_dbms_to_31 into the config file class
  [ticket/12775] Fix comments
  [ticket/12775] Update doc blocks
  [ticket/12775] Fix container_builder
  [ticket/12775] Rename config_php to config_php_file
  [ticket/12775] Renamed to \phpbb\di\container_builder
  [ticket/12775] Remove the last include of functions_container
  [ticket/12775] Fix unit tests
  [ticket/12775] Add tests for \phpbb\config_php
  [ticket/12775] Add tests for the container factory
  [ticket/12775] Use a field instead of a local var in load_config_var()
  [ticket/12775] Update container and config in install/
  ...
2014-07-11 11:49:51 +02:00
Joas Schilling
91f5d59f69 Merge pull request #2676 from Nicofuma/ticket/12787
[ticket/12787] Allow the route to say that the referer has to be used.

* Nicofuma/ticket/12787:
  [ticket/12787] Updates phpbb_mock_controller_helper
  [ticket/12787] Add controller_helper::get_current_url()
  [ticket/12787] Remove one app.php when it's both in $path and $web_root_path
  [ticket/12787] Fix the absolute board url
  [ticket/12787] Use a parameter (_referer) instead of the Referer header
  [ticket/12099] Add unit tests for get_web_root_path_from_ajax_referer()
  [ticket/12099] Remove config again
  [ticket/12099] Correctly fix the path when performing AJAX requests
  [ticket/12099] Add request argument to path_helper service
2014-07-08 18:09:41 +02:00
Tristan Darricau
ed812a9dfb [ticket/12775] Move phpbb_convert_30_dbms_to_31 into the config file class
PHPBB3-12775
2014-07-07 01:02:40 +02:00
Cesar G
d95c97c3b4 [ticket/12013] Fix functional tests and sniffer issue.
PHPBB3-12013
2014-07-04 01:22:32 -07:00
Tristan Darricau
0ce27eacb1 [ticket/11480] Fix the double spaces in phpbb_functional_test_case
PHPBB3-11480
2014-06-30 00:33:33 +02:00
Joas Schilling
b7e1959d56 [ticket/12099] Remove config again
PHPBB3-12099
2014-06-29 20:54:41 +02:00
Pico88
f383d4221c [ticket/12099] Add request argument to path_helper service
PHPBB3-12099
2014-06-29 20:54:38 +02:00
Joas Schilling
3fd7fd435d [ticket/12763] Remove empty schema files
PHPBB3-12763
2014-06-23 21:41:04 +02:00
Andreas Fischer
8332671813 Merge pull request #2587 from dhruvgoel92/ticket/11528
[ticket/11528] Refactor install_board( ) into a new mink class

* dhruvgoel92/ticket/11528:
  [ticket/11528] Change click_submit() to accept id as param
  [ticket/11528] Handle case when config file cant be written by installer
  [ticket/11528] Change NULL to null
  [ticket/11528] Fix spaces and slashes as per guidelines
  [ticket/11528] Add asserts in installation steps
  [ticket/11528] Use 'use' keyword to import classes to current scope
  [ticket/11528] Move parent::tearDown() to end of tearDown()
  [ticket/11528] Call parent::tearDown in overrided tearDown method
  [ticket/11528] Instantiate $client, $driver from functional test case
  [ticket/11528] Refactor install_board() code into a new class
  [ticket/11528] Add behat/mink and mink-goutte-driver as dependency
2014-06-23 20:38:11 +02:00
Dhruv
61fa0908bc [ticket/11528] Change click_submit() to accept id as param
PHPBB3-11528
2014-06-23 21:24:29 +05:30
Dhruv
2147a5eba5 [ticket/11528] Handle case when config file cant be written by installer
PHPBB3-11528
2014-06-23 21:23:47 +05:30
Dhruv
f0e115fdcc [ticket/11528] Change NULL to null
PHPBB3-11528
2014-06-23 01:26:22 +05:30
Dhruv
a92c1d1ec0 [ticket/11528] Fix spaces and slashes as per guidelines
PHPBB3-11528
2014-06-23 01:26:21 +05:30
Dhruv
f5aa9732d1 [ticket/11528] Add asserts in installation steps
PHPBB3-11528
2014-06-23 01:26:19 +05:30
Dhruv
2d1a998003 [ticket/11528] Use 'use' keyword to import classes to current scope
PHPBB3-11528
2014-06-23 01:26:18 +05:30
Dhruv
c26fa6a15b [ticket/11528] Move parent::tearDown() to end of tearDown()
PHPBB3-11528
2014-06-23 01:26:17 +05:30
Dhruv
648cbbd9a0 [ticket/11528] Instantiate $client, $driver from functional test case
Make mink test case an abstract class, instantiate $driver, $client
from its child class i.e. functional test case.

PHPBB3-11528
2014-06-23 01:26:14 +05:30
Dhruv
01f350a614 [ticket/11528] Refactor install_board() code into a new class
PHPBB3-11528
2014-06-23 01:26:13 +05:30
Joas Schilling
dc7ed58bf5 [ticket/12747] Remove some methods which are not used anymore
PHPBB3-12747
2014-06-22 19:31:40 +02:00
Joas Schilling
04164affe6 [ticket/12747] Drop support for Firebird
PHPBB3-12747
2014-06-20 12:35:42 +02:00
Joas Schilling
b855f5fc6a Merge pull request #2566 from marc1706/ticket/11711
[ticket/11711] Inform user of unsupported characters while posting

* marc1706/ticket/11711:
  [ticket/11711] Improve coding and comments of character check
  [ticket/11711] Reduce size of tests and also test topic titles
  [ticket/11711] Improve checks for unsupported characters and check subject
  [ticket/11711] Inform user of unsupported characters while posting
2014-06-20 10:51:58 +02:00
Matt Friedman
be54b64893 [ticket/12697] Delete cached extension schema.json files after testing
PHPBB3-12697
2014-06-12 14:57:32 -07:00
Joas Schilling
916db1a0b1 [ticket/12483] Fix selectors for installing extensions in functional tests
PHPBB3-12483
2014-06-10 20:30:07 +02:00
Joas Schilling
38c2d42304 [ticket/12483] Remove unused globals
PHPBB3-12483
2014-06-10 19:44:06 +02:00
Joas Schilling
d0766a2321 [ticket/12483] Fix finder usage when generating the schema.json file
PHPBB3-12483
2014-06-10 19:43:13 +02:00
Joas Schilling
18d145f38f [ticket/12483] Use file_put_contents()
PHPBB3-12483
2014-06-10 19:41:37 +02:00
Joas Schilling
7b0b6a99c0 [ticket/12483] Close database connection when tearDown() is called
Similar to phpbb_database_test_case::tearDown()

PHPBB3-12483
2014-06-10 19:41:36 +02:00
Joas Schilling
13217fe3ff [ticket/12483] Require the extension manager class
PHPBB3-12483
2014-06-10 19:41:36 +02:00
Joas Schilling
5bae2911a2 [ticket/12483] Move schema files into tmp/ and only copy them when needed
PHPBB3-12483
2014-06-10 19:41:35 +02:00
Joas Schilling
997028a0ec [ticket/12483] Allow to setup extensions before database and functional tests
PHPBB3-12483
2014-06-10 19:41:34 +02:00
Marc Alexander
5ee7f20f4e [ticket/11711] Improve coding and comments of character check
PHPBB3-11711
2014-06-10 15:51:25 +02:00
Marc Alexander
65884bf2bd [ticket/11711] Reduce size of tests and also test topic titles
PHPBB3-11711
2014-06-09 18:57:05 +02:00
Tristan Darricau
9c8e843def [ticket/11480] Add functionnal test
PHPBB3-11480
2014-05-29 14:56:45 +02:00
n-aleha
7f00c38c50 [ticket/11467] Add user object to extension manager for tests
PHPBB3-11467
2014-05-29 01:07:44 +03:00
Yuriy Rusko
a759704b39 [ticket/12594] Remove @package tags and update file headers
PHPBB3-12594
2014-05-27 20:51:13 +02:00
Joas Schilling
d419bd1899 [feature/sqlite3] Use SQLite3 by default
PHPBB3-9728
2014-05-02 15:45:24 +02:00
Patrick Webster
b39b0369aa [feature/sqlite3] Add support for SQLite 3
Minimum version requirement is 3.6.15 as that's what ships with PHP 5.3.0
when support for SQLite 3 was added.

PHPBB3-9728
2014-05-02 15:45:20 +02:00
Andreas Fischer
d7c3cf4700 Merge pull request #2288 from nickvergessen/ticket/12012
[ticket/12012] Correctly drop default value constraints

* nickvergessen/ticket/12012:
  [ticket/12012] Move property to the top
  [ticket/12012] Move MS SQL server comparison into a method
  [ticket/12012] Fix docs in connection manager
  [ticket/12012] Remove duplicated code (only the $sql are different)
  [ticket/12012] Handle begin and commit transactions in tests
  [ticket/12012] Drop and recreate indexes when removing columns
  [ticket/12012] Add a unit test for removing a column with indexes
  [ticket/12012] Add a unit test for changing the column type
  [ticket/12012] Return SQL statements for index drop/create
  [ticket/12012] Fix tools::mssql_get_existing_indexes() for SQL Server 2000
  [ticket/12012] Drop and recreate indexes when changing a column on MSSQL
  [ticket/12012] Fix query layout
  [ticket/12012] Correctly drop default value constraints on MSSQL
2014-04-25 18:54:40 +02:00
Andreas Fischer
69865852a0 [ticket/12436] Data passed to sql_multi_insert is expected to be multi-dim.
PHPBB3-12436
2014-04-24 13:16:50 +02:00
Joas Schilling
4775ad59b0 [ticket/12012] Fix docs in connection manager
PHPBB3-12012
2014-04-20 12:58:46 +02:00
Matt Friedman
067ab9e800 [ticket/12405] Valid timezone and dateformat for create_user() in tests
PHPBB3-12405
2014-04-19 09:42:45 -07:00
Joas Schilling
a75ac5efd2 [ticket/12012] Handle begin and commit transactions in tests
PHPBB3-12012
2014-04-17 11:35:10 +02:00
Marc Alexander
22090dc3a3 [ticket/12386] Add DEBUG_EXTRA again and use it for container creation
We are currently creating a new compiled container on every page load when
having DEBUG enabled. However, one might only have that enabled to be
presented with errors or for getting the page load stats.
This change will add the DEBUG_EXTRA constant again. It will be used for
choosing whether the compiled container should be created on every page load -
when defined as true - or just once after the cache is cleared.

PHPBB3-12386
2014-04-11 11:11:31 +02:00