Commit graph

3719 commits

Author SHA1 Message Date
Marc Alexander
9d4d212e0f [ticket/11525] Only remove group or user prefix from given avatar data
Until now, the user data had both user_id and group_id keys in the avatar
data. As both group_ and user_ prefixes were removed the group_id was
collapsed onto the user_id and therefore all users in the same group had
the same prefix for their uploaded avatars. This patch will make sure
that the correct id is used depending on whether it's a group's or user's
avatar data.

PHPBB3-11525
2013-10-24 13:55:23 +02:00
Marc Alexander
bc7ff47537 [ticket/11912] Supply filename to content_guesser for guessing on windows
The filename of the files sent to the guesser by plupload do not contain
the file extension. Therefore, it's impossible to guess the mimetype if
only the content_guesser is available and the function mime_content_type()
doesn't exist. By supplying the filename we can circumvent this issue.

PHPBB3-11912
2013-10-24 12:05:00 +02:00
Marc Alexander
f617aff182 [ticket/11912] Add tests for content_guesser
PHPBB3-11912
2013-10-23 23:18:40 +02:00
Marc Alexander
c8040024cb [ticket/11912] Add tests for phpbb mimetype guesser
PHPBB3-11912
2013-10-23 18:36:11 +02:00
Nils Adermann
a7e41b23fd Merge pull request #1801 from nickvergessen/ticket/11948
Ticket/11948 Extensions should be allowed to have more then 1 routing file
2013-10-22 00:29:20 -07:00
Joas Schilling
96317b2c45 [ticket/11948] Check actual result of routes
PHPBB3-11948
2013-10-21 22:18:03 +02:00
Joas Schilling
51561ed538 [ticket/11948] Allow resource importing for routing
PHPBB3-11948
2013-10-21 21:52:48 +02:00
Marc Alexander
d7bf50bc80 [ticket/11930] Move path_helper in front of optional cache argument
Optional method arguments should be after any mandatory ones.

PHPBB3-11930
2013-10-21 10:20:12 +02:00
Joas Schilling
3cc2e619d2 [ticket/11948] Add second routing file to tests
PHPBB3-11948
2013-10-19 12:11:09 +02:00
Marc Alexander
3f0ce78a25 [ticket/11930] Fix tests after adding phpbb\path_helper to avatar drivers
PHPBB3-11930
2013-10-17 20:49:10 +02:00
Marc Alexander
1d57ec1f65 [feature/passwords] Add functional tests for forum passwords
PHPBB3-11610
2013-10-13 12:06:02 +02:00
Andreas Fischer
2050a39da7 [feature/plupload/integration] Integration of Plupload
This commit is a highly-refactored and up-to-date version of Fyorl's work
which was part of his Google Summer of Code 2012 project "Attachment
Improvements".

PHPBB3-10929
2013-10-11 17:40:16 +02:00
Nils Adermann
446dc9b47e Merge pull request #1764 from EXreaction/ticket/11874
[ticket/11874] Do not always prepend the web path; only replace phpbb_root_path
2013-10-10 15:54:58 -07:00
Nathan Guse
4ad1495768 [ticket/11903] Speed up paging test
PHPBB3-11903
2013-10-10 16:55:01 -05:00
Nathan Guse
31649f1eb0 [ticket/11874] Fix tests
PHPBB3-11874
2013-10-10 16:20:00 -05:00
Marc Alexander
7c347864a4 [feature/passwords] Fix tests for 8th bit characters in bcrypt on PHP < 5.3.7
PHPBB3-11610
2013-10-10 12:09:50 +02:00
Marc Alexander
fdf9ae7c18 [feature/passwords] Increase test coverage to 100% of methods
Obsolete code that is impossible to hit has been removed and the logic
of the salted md5 driver has been changed to correctly implement the
phpBB 3.0 phpbb_hash() function.

PHPBB3-11610
2013-10-10 12:01:10 +02:00
Marc Alexander
cd74fb0946 [feature/passwords] Increase test coverage to 35 out ouf 36 methods
Only one small code part in the salted md5 driver can't be tested right now.
Passwords helper and passwords driver helper are now fully covered by tests.

PHPBB3-11610
2013-10-09 22:53:13 +02:00
Marc Alexander
3b6038cfcd [feature/passwords] Add tests for unique_id() method in helper
PHPBB3-11610
2013-10-09 14:28:57 +02:00
Nathan Guse
1e2ceb456f Merge pull request #1481 from dhruvgoel92/ticket/11608
[ticket/11608] add functional tests for search
2013-10-07 10:15:06 -07:00
Dhruv
8c73d28341 [ticket/11608] Mark failed test as incomplete for mysql search backend
PHPBB3-11608
2013-10-05 22:49:55 +05:30
Dhruv
67536eb9f7 [ticket/11608] Update search backend class names to namespaces
PHPBB3-11608
2013-10-05 21:21:15 +05:30
Dhruv
2b5311deac [ticket/11608] Move markIncomplete to search backends test
PHPBB3-11608
2013-10-05 21:16:06 +05:30
Dhruv
72d939372f [ticket/11608] Rename base search test class file
PHPBB3-11608
2013-10-05 21:16:05 +05:30
Dhruv
77ef82682e [ticket/11608] Remove suffix test from base class
Rename base class to phpbb_functional_search_base and fix Docblocks as per
phpbb guidelines.

PHPBB3-11608
2013-10-05 21:16:04 +05:30
Dhruv
1cd888e0ee [ticket/11608] Mark postgres search not found test as incomplete
PHPBB3-11608
2013-10-05 21:16:03 +05:30
Dhruv
5135ae2a24 [ticket/11608] Mark sphinx tests as incomplete for now
PHPBB3-11608
2013-10-05 21:16:02 +05:30
Dhruv
c31035d047 [ticket/11608] Mark failed search test incomplete for native search
PHPBB3-11608
2013-10-05 21:16:01 +05:30
Dhruv
a3482bded4 [ticket/11608] remove setUp method override
PHPBB3-11608
2013-10-05 21:15:59 +05:30
Dhruv
b31bb8653b [ticket/11608] add search functional tests to search subfolder
PHPBB3-11608
2013-10-05 21:15:36 +05:30
Dhruv
07c259f4b1 [ticket/11608] rename search_found and not_found method
Rename search_found and search_not_found to assert_search_found and
assert_search_not_found. Count .errorbox incase the search backend is not
supported and skip tests

PHPBB3-11608
2013-10-05 21:15:34 +05:30
Dhruv
b7d55b8ff8 [ticket/11608] pass keywords to search_found and search_not_found test
PHPBB3-11608
2013-10-05 21:15:33 +05:30
Dhruv
e1030d3670 [ticket/11608] Set sphinx id from test_config file for tests
PHPBB3-11608
2013-10-05 21:15:32 +05:30
Dhruv
75d16da9fa [ticket/11608] Use assertEquals for more accurate assertions
PHPBB3-11608
2013-10-05 21:15:31 +05:30
Dhruv
5825bf7d33 [ticket/11608] Use assertContainsLang to compare language strings
PHPBB3-11608
2013-10-05 21:15:30 +05:30
Dhruv
36da38f062 [ticket/11608] split search tests into separate files
Tests for each search backend are into their own separate files.
These separate classes inherit from a common search test case class.

PHPBB3-11608
2013-10-05 21:15:29 +05:30
Dhruv
9c082999bb [ticket/11608] Check for word highlights in search results
Search tests check for highlighted words in search results

PHPBB3-11608
2013-10-05 21:15:27 +05:30
Dhruv
115599e78d [ticket/11608] Mark sphinx test as incomplete
Sphinx search for the test board cannot be tested

PHPBB3-11608
2013-10-05 21:15:26 +05:30
Dhruv
ec30fcf819 [ticket/11608] Logout before searching
Keyword search in search functional tests should be
performed as guests rather than logged in as admin.

PHPBB3-11608
2013-10-05 21:15:25 +05:30
Dhruv
f4ca9a30a5 [ticket/11608] Add more assetions in tests
PHPBB3-11608
2013-10-05 21:15:24 +05:30
Dhruv
92698c95dc [ticket/11608] Use assertions in test
PHPBB3-11608
2013-10-05 21:15:23 +05:30
Dhruv
81acd8ef10 [ticket/11608] complete search tests functionalities
PHPBB3-11608
2013-10-05 21:15:21 +05:30
Dhruv
c33c89a790 [ticket/11608] Skip tests for unsupported search backends
PHPBB3-11608
2013-10-05 21:15:20 +05:30
Dhruv
ea75b67f5e [ticket/11608] add basic search functional test structure
PHPBB3-11608
2013-10-05 21:15:19 +05:30
David King
82b9df543b Merge pull request #1742 from EXreaction/ticket/11840
Ticket/11840 Refactor the extension metadata class
2013-10-04 15:40:20 -07:00
Nathan Guse
9653276ebc [ticket/11881] Better split the timezone conversion into chunks; add test
PHPBB3-11881
2013-10-04 12:10:27 -05:00
David King
2683188206 Merge pull request #1726 from EXreaction/ticket/11850
Fix $user->page on pages through the controller
2013-10-03 09:25:11 -07:00
Marc Alexander
035db5e08b [feature/passwords] Fix hash_test for use of passwords manager
PHPBB3-11610
2013-10-03 10:23:17 +02:00
Marc Alexander
7006db7a2d Merge branch 'develop' of https://github.com/phpbb/phpbb3 into feature/passwords
Conflicts:
	phpBB/includes/functions.php
2013-10-03 10:04:59 +02:00
Marc Alexander
93531e7fb0 [feature/passwords] Add prepending backslash to class namespaces
PHPBB3-11610
2013-10-02 23:45:32 +02:00