Commit graph

21562 commits

Author SHA1 Message Date
Andreas Fischer
83ec308eff [ticket/12107] Use log table property instead of log table constant.
PHPBB3-12107
2014-01-12 21:36:50 +01:00
Andreas Fischer
670a9a1aea Merge pull request #1893 from nickvergessen/ticket/12039
[ticket/12039] Add config:* to the command line interface tool

* nickvergessen/ticket/12039:
  [ticket/12039] Allow getting the value without a new line at the end
  [ticket/12039] Do not print success message when config did not exist
  [ticket/12039] Do not colour returned value in get command
  [ticket/12039] Update command descriptions
  [ticket/12039] Remove debug code
  [ticket/12039] Fix option descriptions
  [ticket/12039] Use an abstract class and some more minor adjustments
  [ticket/12039] Add config:* to the command line interface tool
2014-01-12 21:23:21 +01:00
Nils Adermann
46fec7ee90 Merge pull request #1936 from nickvergessen/ticket/12030
[Ticket/12030] Include some directories completly in update packages
2014-01-12 02:31:40 -08:00
Joas Schilling
c665839636 [ticket/11201] Remove global use from admin class
PHPBB3-11201
2014-01-10 23:00:37 +01:00
Nathan Guse
7bac4bf9bd [ticket/12006] Missing a space
PHPBB3-12006
2014-01-10 13:15:37 -06:00
Nathan Guse
e3cba9ceba [ticket/12006] Add module_auth event
PHPBB3-12006
2014-01-10 13:14:50 -06:00
Joas Schilling
2471b19d73 [ticket/11201] Make profile field classes autoloadable
PHPBB3-11201
2014-01-10 16:11:11 +01:00
Joas Schilling
a70973ea42 [ticket/12039] Allow getting the value without a new line at the end
PHPBB3-12039
2014-01-10 11:36:11 +01:00
Matt Friedman
f14ca6df6f [ticket/12104] Update the event's doc block to reflect new variable
PHPBB3-12104
2014-01-09 15:48:32 -08:00
Matt Friedman
c2c677d4f2 [ticket/12104] Remove newline before WHERE parameter
PHPBB3-12104
2014-01-09 15:45:24 -08:00
Matt Friedman
b95631b163 [ticket/12104] Remove empty LEFT_JOIN array
PHPBB3-12104
2014-01-09 15:42:25 -08:00
Matt Friedman
f9cef15989 [ticket/12104] Replace shadow topics $sql with $sql_array for better Event handling
PHPBB3-12104
2014-01-09 12:43:33 -08:00
Joas Schilling
5d89c283f0 [ticket/12039] Do not print success message when config did not exist
PHPBB3-12039
2014-01-08 23:59:46 +01:00
Joas Schilling
52c452c768 [ticket/12039] Do not colour returned value in get command
PHPBB3-12039
2014-01-08 23:56:50 +01:00
Joas Schilling
2081d973b0 [ticket/12030] Fix some spelling issues
PHPBB3-12030
2014-01-08 23:53:45 +01:00
Joas Schilling
3e84fb76a3 Merge remote-tracking branch 'Marc/ticket/11997' into develop
* Marc/ticket/11997: (23 commits)
  [ticket/11997] Use functional test cases that should always work
  [ticket/11997] Fix redirect tests for mod rewrite
  [ticket/11997] Add user's page dir to redirect path and fix unit tests for it
  [ticket/11997] Remove obsolete function get_controller_redirect_url()
  [ticket/11997] Use path_helper in in foo/bar extension for redirect URLs
  [ticket/11997] Add remove_web_root_path() in order to prevent incorrect URLs
  [ticket/11997] Do not check if file or dir we redirect to exist
  [ticket/11997] Modifiy tests after adding path_helper clean_url method
  [ticket/11997] Add clean_url() method to path_helper
  [ticket/11997] Allow redirects to parent folders like previously
  [ticket/11997] Move expected redirect returns to controller and output to HTML
  [ticket/11997] Fix tests for path_helper's get_controller_redirect_url()
  [ticket/11997] Use get_controller_redirect_url() in redirect() function
  [ticket/11997] Add method for controller redirect URLs to path helper
  [ticket/11997] Undo changes to phpbb_own_realpath()
  [ticket/11997] Remove obsolete failover_flag in function redirect()
  [ticket/11997] Add functional test for redirects in controller
  [ticket/11997] Fix missing global
  [ticket/11997] Fix redirects from inside controllers
  [ticket/11997] Use $phpbb_filesystem->clean_path() for proper redirect paths
  ...
2014-01-08 16:17:48 +01:00
marc1706
98aebabd73 [ticket/12071] Add test that covers not available fileinfo
The newly added test case will also emulate a non-existing fileinfo
in order to check if the mimetype guesser is properly working when
fileinfo is not available.

PHPBB3-12071
2014-01-03 16:40:12 +01:00
marc1706
f111a9262f [ticket/12071] Get rid of unneeded cast to boolean in tests
PHPBB3-12071
2014-01-03 13:45:38 +01:00
marc1706
8ebf5bb8d1 [ticket/12071] Skip tests that depend on fileinfo and fix expected results
Tests that depend on fileinfo being enabled will now be skipped to prevent
fatal errors while running the test suite. The expected results will be
modified to "application/octet-stream" in test_guess_files() if only the
extension_guesser is available due to the non-existing extension of those
files.

PHPBB3-12071
2014-01-03 13:30:52 +01:00
Nathan Guse
c6491c9078 [ticket/11881] Fix test filename
PHPBB3-11881
2013-12-30 14:27:13 -06:00
Nathan Guse
405f883437 [ticket/11902] Use phpbb\php\ini class
PHPBB3-11902
2013-12-30 14:24:58 -06:00
Nathan Guse
821f737560 Merge pull request #1890 from prototech/ticket/12034
[ticket/12034] AJAXify notifications popup.
2013-12-30 12:20:22 -08:00
Nathan Guse
b186d31ce6 Merge pull request #1920 from prototech/ticket/12038
[ticket/12038] AJAXify move up/down buttons for various ACP pages.
2013-12-30 11:23:22 -08:00
Cesar G
d76ec60ee1 [ticket/12034] Move similar code in the two callbacks to separate function.
PHPBB3-12034
2013-12-30 11:12:15 -08:00
Cesar G
0c0375df65 [ticket/12034] Add comma to end of array.
PHPBB3-12034
2013-12-30 11:12:15 -08:00
Cesar G
f4b832a27d [ticket/12034] AJAXify notifications popup.
PHPBB3-12034
2013-12-30 11:12:15 -08:00
Cesar G
06262aca54 [ticket/12038] Free query results.
PHPBB3-12038
2013-12-30 11:09:08 -08:00
Nathan Guse
be67124dc7 Merge pull request #1889 from prototech/ticket/11963
[ticket/11963] Remove stale MCP notifications.
2013-12-30 11:04:43 -08:00
Nathan Guse
34c3e74c16 Merge pull request #1913 from prototech/ticket/12055
[ticket/12055] Alternate table row background colors using nth-child rule.
2013-12-30 10:44:30 -08:00
Nathan Guse
6ab12c1779 [ticket/12006] Test for ext module auth
PHPBB3-12006
2013-12-30 12:32:48 -06:00
Nathan Guse
05cf83aca7 [ticket/12006] Add extension enabled check token to module auth
PHPBB3-12006
2013-12-30 11:50:37 -06:00
Nathan Guse
7740ab5dc3 [ticket/12006] Cleanup the module auth function token replacement code
PHPBB3-12006
2013-12-30 11:46:02 -06:00
Marc Alexander
85f1e8afa5 [feature/passwords] Correct docblock of phpbb_hash() function
PHPBB3-11610
2013-12-29 20:52:25 +01:00
Marc Alexander
4b832cf2bd [feature/passwords] Intialize output array before usage in passwords helper
PHPBB3-11610
2013-12-29 17:57:17 +01:00
Marc Alexander
1465915830 [feature/passwords] Remove unneeded definitions of full namespace
PHPBB3-11610
2013-12-29 17:56:41 +01:00
Marc Alexander
8383d1f1d3 [feature/passwords] Add missing documentation to docblocks
Also contains some minor spacing changes.

PHPBB3-11610
2013-12-29 17:55:00 +01:00
Marc Alexander
141bef75cb [feature/passwords] Undo simplification to bcrypt driver
By simplifying, a needed part was removed that is actually required.

PHPBB3-11610
2013-12-29 17:04:38 +01:00
Marc Alexander
808c54fa89 [feature/passwords] Get rid of unneeded code complexity
Simplified a little bit of code as pointed out by imkingdavid on github.

PHPBB3-11610
2013-12-29 16:33:09 +01:00
Marc Alexander
555cd025b2 [feature/passwords] Remove unnecessary specification of namespace in drivers
PHPBB3-11610
2013-12-29 16:17:37 +01:00
Marc Alexander
b37549ce63 [feature/passwords] Remove IN_PHPBB check from passwords files
PHPBB3-11610
2013-12-29 14:07:27 +01:00
Marc Alexander
382317b135 Merge branch 'develop' of https://github.com/phpbb/phpbb into feature/passwords
Conflicts:
	phpBB/config/services.yml
2013-12-29 13:46:42 +01:00
Marc Alexander
f906fb41e9 [ticket/11997] Use functional test cases that should always work
The previous test cases that tried to redirect to ../index.php and similar
might cause us to try to go to http://localhost/../index.php, which will
result in http://index.php. As this obviously will trigger an error as
intended, we should not put this inside our test cases for the redirect
function.

PHPBB3-11997
2013-12-28 20:40:18 +01:00
Marc Alexander
ac131a5159 [feature/passwords] Fix indentation in auth providers
PHPBB3-11610
2013-12-28 16:56:20 +01:00
Marc Alexander
3e815616c5 [ticket/11997] Fix redirect tests for mod rewrite
Controller routes that are supposed to link to parent directories can't be
tested as the links are incorrectly created depending on enabled mod rewrite
or not.

PHPBB3-11997
2013-12-28 16:50:15 +01:00
Marc Alexander
4c1569dd8a [ticket/11997] Add user's page dir to redirect path and fix unit tests for it
The user's page directory needs to be added to the redirect URL for proper
redirects outside of the forum root. Fix the unit tests accordingly.

PHPBB3-11997
2013-12-28 00:14:12 +01:00
Marc Alexander
ce2c5213d7 [ticket/11997] Remove obsolete function get_controller_redirect_url()
PHPBB3-11997
2013-12-27 18:41:44 +01:00
Marc Alexander
68ce16f9b3 [ticket/11997] Use path_helper in in foo/bar extension for redirect URLs
By using path_helper's clean_url() method, we'll be able to properly check
the full URL instead of just parts of the expected URL.

PHPBB3-11997
2013-12-27 17:55:14 +01:00
Marc Alexander
a304d99b2b [ticket/11997] Add remove_web_root_path() in order to prevent incorrect URLs
Adding a call to this method to the redirect function will make sure that we
do not end up with incorrect URLs after using append_sid().

PHPBB3-11997
2013-12-27 17:50:17 +01:00
Joas Schilling
95d4e6aa97 [ticket/11996] Add explanation how to correctly remove and update an extension
See http://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=44001 for more
information about the decision.

PHPBB3-11996
2013-12-27 15:25:03 +01:00
Dhruv
db94f80c5b Merge remote-tracking branch 'nickvergessen/ticket/11911' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/11911:
  [ticket/11911] Warn admins when there is no search index for the selected engine
2013-12-27 18:01:48 +05:30