Meik Sievertsen
4cbf6bc703
Merge most changes from 3.0.x branch since the 25th december.
...
(Captcha changes for refreshing captcha image not included)
git-svn-id: file:///svn/phpbb/trunk@9404 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-03-22 16:34:26 +00:00
Meik Sievertsen
d181f0ef36
append_sid wrapper + is_guest
...
git-svn-id: file:///svn/phpbb/trunk@9338 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-02-22 19:17:10 +00:00
Meik Sievertsen
b27add94f8
$template to phpbb::$template
...
git-svn-id: file:///svn/phpbb/trunk@9337 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-02-22 18:56:09 +00:00
Meik Sievertsen
794c574969
remove global and change $user-> to phpbb::$user->
...
git-svn-id: file:///svn/phpbb/trunk@9334 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-02-22 15:29:18 +00:00
Meik Sievertsen
950842de5c
add some properties
...
change phpbb_chmod to phpbb::$system->chmod()
also changed chmod behaviour to the most failsafe method. If we are not able to tell the exact outcome, we simply do not mess with it.
git-svn-id: file:///svn/phpbb/trunk@9296 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-01-22 15:59:00 +00:00
Meik Sievertsen
e9f2f841f6
Add proper language to error messages
...
git-svn-id: file:///svn/phpbb/trunk@9293 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-01-22 12:48:38 +00:00
Meik Sievertsen
9f060eba6e
some adjustements to the installer
...
git-svn-id: file:///svn/phpbb/trunk@9284 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-01-21 17:03:00 +00:00
Meik Sievertsen
cd4091af43
i am not sure if people will like the config layout i test here... it requires the framework at least being present
...
git-svn-id: file:///svn/phpbb/trunk@9281 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-01-20 16:54:15 +00:00
Meik Sievertsen
abee782518
This may be an interesting approach for internal functionality and trying to be consistent
...
git-svn-id: file:///svn/phpbb/trunk@9278 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-01-19 15:23:43 +00:00
Meik Sievertsen
57aea7e62f
modified some files to get the admin index page working, as well as index page in logged in state and not logged in state
...
additionally prepare for a working installation
git-svn-id: file:///svn/phpbb/trunk@9272 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-01-16 17:41:04 +00:00
Meik Sievertsen
27c691e6a1
erm... realpath
...
git-svn-id: file:///svn/phpbb/trunk@9259 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-01-13 18:29:09 +00:00
Meik Sievertsen
1106aed2f6
oi... index page looks good...
...
git-svn-id: file:///svn/phpbb/trunk@9246 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-31 13:36:06 +00:00
Meik Sievertsen
11e76473aa
fix some functions
...
git-svn-id: file:///svn/phpbb/trunk@9245 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-30 17:20:50 +00:00
Meik Sievertsen
19aed179e5
$config to phpbb::$config
...
git-svn-id: file:///svn/phpbb/trunk@9242 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-28 23:30:09 +00:00
Meik Sievertsen
fbaf2baa8d
document plugin-support
...
move language path declaration to object instantiation
git-svn-id: file:///svn/phpbb/trunk@9239 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-28 10:53:28 +00:00
Meik Sievertsen
cf5c856c28
change page_header/page_footer and message handler
...
git-svn-id: file:///svn/phpbb/trunk@9234 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-27 13:52:27 +00:00
Meik Sievertsen
25725c9850
replace constants with class constants.
...
ACL_YES, ACL_NO, ACL_NEVER, USER_NORMAL, USER_IGNORE, USER_INACTIVE, USER_FOUNDER
git-svn-id: file:///svn/phpbb/trunk@9233 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-27 12:18:04 +00:00
Meik Sievertsen
5b9a3c9a7d
add nils' request and super globals class
...
rename request:: to phpbb_request::
git-svn-id: file:///svn/phpbb/trunk@9230 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-25 14:47:57 +00:00
Meik Sievertsen
16e8b8271b
ok... now i remember. Added more precise comments
...
git-svn-id: file:///svn/phpbb/trunk@9159 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-03 09:42:10 +00:00
Meik Sievertsen
a236d24ae5
Add same redirect disable_cd_check parameter to meta_refresh - #38065
...
git-svn-id: file:///svn/phpbb/trunk@9154 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-02 17:04:13 +00:00
Meik Sievertsen
eddddaa3a4
Slight performance increase for common parameter calls to append_sid() (Bug #37555 - Patch by BartVB)
...
Unsure if this works with the mysterious, uncommented block in front of it, the parsed_urls thingy... whoever wrote it, please prod me. :) Or add comments.
git-svn-id: file:///svn/phpbb/trunk@9151 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-02 16:27:44 +00:00
Chris Smith
45ac6aba10
merge in r9145
...
git-svn-id: file:///svn/phpbb/trunk@9147 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-01 17:28:32 +00:00
Chris Smith
b68a102491
merge in r9144
...
git-svn-id: file:///svn/phpbb/trunk@9145 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-12-01 17:04:58 +00:00
Meik Sievertsen
764c1c4f2b
Let's face it - the most common setup we see with phpBB is having group-specific settings for external users (FTP, whatever).
...
Changed phpbb_chmod() to set the group bit, even if the PHP user is the owner. (somehow this sounds complicated, i hope you get the idea).
git-svn-id: file:///svn/phpbb/trunk@9132 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-11-30 11:50:23 +00:00
Nils Adermann
8427ae3fd4
Introducing the new request class. All input his handled through this class.
...
"Given a choice between dancing pigs and security, users will pick
dancing pigs every time." (Gary McGraw and Edward Felten)
What stays the same?
- request_var() keeps working as it used to, alternatively you can directly use
request::variable() which allows choosing which super global you want to read
So what's new?
- request::disable_super_globals() which disables super globals. This
function causes any direct use of $_POST, $_GET, $_REQUEST or $_COOKIE to
result in an E_USER_ERROR. We hope that this will force MOD authors to at
least think about validation as they will have to read about how to use the
request class.
- request::is_set() / request::is_set_post will be used instead of using isset
directly on super globals
- request_var() now supports arrays with arbitrary depth
- request_var() can be used with an array as the variable name to directly
access values in mutli dimensional arrays.
What's next?
- request::disable_super_globals() will be active by default (set in
common.php)
- all code will be adjusted to use the new class consistently
- tests for the request class to make sure it works as designed and will not
change behaviour between releases
I've also already updated all the code within functions.php to use the request class.
git-svn-id: file:///svn/phpbb/trunk@9101 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-11-23 23:43:00 +00:00
Meik Sievertsen
d46e8e6f98
merge revisions i missed... hopefully not breaking things - did not check every change.
...
git-svn-id: file:///svn/phpbb/trunk@9077 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-11-22 19:38:25 +00:00
Meik Sievertsen
9c7d8dcd7d
- Do not show link to user/group profiles if user has no permission to view the linked page and gets a denied message anyway. (Bug #15088 )
...
- Do not display last post link and sort display options for search engines. (Bug #15088 )
git-svn-id: file:///svn/phpbb/trunk@8988 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-10-09 14:22:07 +00:00
Meik Sievertsen
9a7804cb71
[Change] Remove NUL-Bytes directly in request_var() for strings and within the custom DBAL sql_escape() functions (MSSQL, Firebird, Oracle) (reported by AdhostMikeSw)
...
git-svn-id: file:///svn/phpbb/trunk@8968 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-10-02 12:05:13 +00:00
Meik Sievertsen
ad4d7c036e
merge r8956, r8957 and r8960
...
git-svn-id: file:///svn/phpbb/trunk@8961 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-30 15:18:35 +00:00
Henry Sudhof
461be11e8d
Okay, that is pretty raw, but better to have it in place than trying to play catch-up. Introducing an early stage of CAPTCHA modules.
...
git-svn-id: file:///svn/phpbb/trunk@8889 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-19 13:17:30 +00:00
Meik Sievertsen
2fc6d5147a
Set secure cookie for style switcher if required. (Bug #19625 )
...
git-svn-id: file:///svn/phpbb/trunk@8875 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-18 14:17:39 +00:00
Chris Smith
0e0100c525
merge r8829, r8830, r8831, r8832, r8833, r8834, r8835, r8836, r8837, r8838
...
git-svn-id: file:///svn/phpbb/trunk@8839 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-08 13:39:34 +00:00
Meik Sievertsen
c83e6f7e94
cleanage
...
git-svn-id: file:///svn/phpbb/trunk@8822 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-04 14:10:17 +00:00
Chris Smith
0dbe7e3b6c
Remove caching of templates from the database completely, themes is cut down ready for a complete chop, and fix the installer :)
...
git-svn-id: file:///svn/phpbb/trunk@8812 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-04 11:39:25 +00:00
Meik Sievertsen
589db44b56
Merge of the language-specific custom path change Revision #r8782
...
git-svn-id: file:///svn/phpbb/trunk@8786 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-08-24 10:04:15 +00:00
Meik Sievertsen
8174462e89
Merge chmod changes into trunk
...
git-svn-id: file:///svn/phpbb/trunk@8781 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-08-22 13:32:34 +00:00
Henry Sudhof
a45ac24bd7
comments
...
git-svn-id: file:///svn/phpbb/trunk@8779 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-08-22 11:02:17 +00:00
Henry Sudhof
3a3b9eb8ef
merge
...
git-svn-id: file:///svn/phpbb/trunk@8776 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-08-21 15:50:21 +00:00
Meik Sievertsen
1071d9cb31
merge cookie secure detection
...
git-svn-id: file:///svn/phpbb/trunk@8738 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-08-01 14:30:42 +00:00
Meik Sievertsen
1b67e80422
marge
...
git-svn-id: file:///svn/phpbb/trunk@8696 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-07-28 13:37:16 +00:00
Meik Sievertsen
036dc071e7
merge
...
git-svn-id: file:///svn/phpbb/trunk@8684 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-07-27 13:42:46 +00:00
Meik Sievertsen
ad739a358c
merge? merge.
...
git-svn-id: file:///svn/phpbb/trunk@8672 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-23 18:22:44 +00:00
David M
97d2fb55b7
/me slaps himself for being old school
...
git-svn-id: file:///svn/phpbb/trunk@8650 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-12 07:27:01 +00:00
David M
0ebc5cc9ee
The beginnings of the destruction of phpBB's greatest bottleneck, dynamic css...
...
As of phpBB 3.0.x, we take our "generic" CSS for a theme and later on combine it with the imagesets and languages as needed... What we did for 3.0.x involved dynamically resolving the variables in the CSS and then sending it off, caching it at several layers (except the one that mattered). The biggest issue with style.php is that it is one giant str_replace on every page load, no matter what; cache be damned. Instead, the trick is to cache the full compilation earlier on...
Further work to do: kill all the old crap and fully integrate the new solution
git-svn-id: file:///svn/phpbb/trunk@8649 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-12 07:24:13 +00:00
Meik Sievertsen
fc8db76da9
added two comments to describe the functions use-case
...
git-svn-id: file:///svn/phpbb/trunk@8644 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-10 12:55:32 +00:00
Nils Adermann
d168abdcc9
Regular expression for email matching in posts will no longer die on long words
...
git-svn-id: file:///svn/phpbb/trunk@8642 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-09 22:32:51 +00:00
Meik Sievertsen
e199f55ba2
#27395
...
git-svn-id: file:///svn/phpbb/trunk@8637 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-09 17:10:59 +00:00
Meik Sievertsen
1aa40171e0
merge...
...
git-svn-id: file:///svn/phpbb/trunk@8624 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-08 21:44:59 +00:00
Henry Sudhof
4dddc3a130
Some xenophobia
...
git-svn-id: file:///svn/phpbb/trunk@8612 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-06 11:28:55 +00:00
Meik Sievertsen
8822747b91
merge...
...
git-svn-id: file:///svn/phpbb/trunk@8610 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-05 14:11:42 +00:00