Commit graph

159 commits

Author SHA1 Message Date
Marc Alexander
0fe95a032b
[ticket/16956] Remove router cache flag
The deferred purge will be used in the future instead. The cache flag in the
router only causes additional issues by trying to rebuild the routing
mid-request

PHPBB3-16956
2022-01-31 16:52:19 +01:00
Tristan Darricau
b28b94b1f1 [ticket/16891] Do not change an extension status in the middle of a request
When enabling an extension, it should be considered as not being enabled for
the entire request as if the "enabled" flag is switch during the request, the
extension will stay not loaded (same when disabling an extension).

Example when it can be an issue today : if the router is called for the first
time after enabling the extension and if the extension uses a custom route
loader (like phpbb/pages) then the router will fail because the custom route
will be found but the custom loader will not be loaded and available.

PHPBB3-16891
2021-10-30 04:25:31 +02:00
rxu
fe38280a1a
[ticket/16549] Fix tests
1. If $service array is empty, $service[0] call will throw fatal error in PHP 8.
2. Division by zero was promoted to fatal error
and throws DivisionByZeroError exception in PHP 8+
3. Adjust make_clickable() logic to avoid 'Undefined array key 3' error.

PHPBB3-16549
2020-10-18 14:59:11 +07:00
William Desportes
fedfc330ef
[ticket/16587] Fix phpdoc errors reported by Doctum
PHPBB3-16587
2020-09-07 12:11:31 +02:00
rxu
4ed854c818
[ticket/16288] PHP 8 compatibility
PHPBB3-16288
2020-01-03 02:21:37 +07:00
Marc Alexander
ebac54aa9e
[ticket/14948] Adjust calls for twig and phpunit updates
PHPBB3-14948
2019-05-09 21:40:06 +02:00
rubencm
a702142a34
[ticket/12636] Rename log.session_errors to session.log_errors
PHPBB3-12636
2019-05-09 21:20:16 +02:00
Rubén Calvo
c20fed43cd
[ticket/12636] Add log.session_errors to mock container_builder
PHPBB3-12636
2019-05-09 21:10:53 +02:00
Jakub Senko
139eb17bb7
[ticket/12624] Add debug.load_time parameter
PHPBB3-12624
2019-05-09 18:40:15 +02:00
luzpaz
a9a28859d4
[ticket/15424] Multiple typo fixes in docs & comments
Fixed typos in some docs, guidelines, some non-user-facing files.

PHPBB3-15424
2019-05-08 22:20:56 +02:00
Marc Alexander
1a8a8da7bf
[ticket/14670] Fix incompatibilities with container definitions
PHPBB3-14670
2019-05-06 21:43:55 +02:00
rxu
f8fbe37936
[ticket/14972] replace all occurrences of sizeof() with the count()
PHPBB3-14972
2018-01-01 13:56:04 +01:00
Marc Alexander
f39e5424f1
[ticket/14938] Add missing language class to extension manager mock
PHPBB3-14938
2017-04-16 16:36:13 +02:00
Marc Alexander
1b63292cc3
Merge branch '3.1.x' into 3.2.x 2017-04-16 15:14:04 +02:00
javiexin
7b2ffaf78c [ticket/14938] Inconsistency in ext_mgr all_available vs is_available
Made is_available much more strict, in line with the checks in all_available
Refactor all_available to use is_available, saving duplicate code.
Further simplify is_available by using metadata_manager.
Make optional the template object on metadata_manager creation.
Fix extension_manager_mock to have config and user components.

PHPBB3-14938
2017-02-10 02:09:18 +01:00
Marc Alexander
072bf470fc
Merge branch 'ticket/14957' into ticket/14957-rhea 2017-01-03 21:41:36 +01:00
Marc Alexander
d817f3cc67
[ticket/14875] Add raw_variable() to request mock
PHPBB3-14875
2016-12-02 12:53:17 +01:00
Matt Friedman
14e8113fcf [ticket/14576] Move common required files to bootstrap
PHPBB3-14576
2016-03-31 11:06:47 -07:00
Tristan Darricau
8e100f000e Merge pull request #4144 from VSEphpbb/ticket/14434
[ticket/14434] Allow non-migration files inside migrations folder (continued)

* VSEphpbb/ticket/14434:
  [ticket/14434] Refactored to check migrations when setting them
  [ticket/14434] Check migrations in the database updater task
  [ticket/14434] Do not include non-migrations in CLI list
  [ticket/14434] Remove redundant conditional
  [ticket/14434] Fix whitespace mistakes
  [ticket/14434] Remove recursion to simplify is_migration method
  [ticket/14434] Extract migration check to a reusable method
  [ticket/14434] Schema generator should ignore migration helpers
2016-02-02 13:12:25 +01:00
Matt Friedman
27027deb9c [ticket/14434] Refactored to check migrations when setting them
PHPBB3-14434
2016-01-28 12:17:35 -08:00
Tristan Darricau
cc38bf550b [ticket/14129] Caches extensions autoloaders
PHPBB3-14129
2016-01-26 22:13:26 +01:00
Matt Friedman
b64a37d451 [ticket/14237] Use $language class for notifications
PHPBB3-14237
2015-10-13 23:40:52 -07:00
Marc Alexander
46e3d82196 [ticket/13904] Add more tests and test cases
PHPBB3-13904
2015-09-09 08:28:08 +02:00
Nicofuma
8e5e954438 [ticket/13645] Move the feeds to controllers
PHPBB3-13645
2015-08-23 22:36:10 +02:00
Tristan Darricau
fc34057f28 [ticket/11444] Update tests and cleanup types/methods
PHPBB3-11444
2015-07-13 22:41:14 +02:00
Nicofuma
be0d4e20d4 [ticket/11444] Moving the in-board notifications to a method class
Currently the in-board method for the notifications is hardcoded and
cannot be disabled. This method should be in his own class extending
`phpbb\notification\method\method_interface`.

It also add the possibility, for each method, to be enabled by default (ie:
no entry in the DB => notification enabled).

https://tracker.phpbb.com/browse/PHPBB3-11444
https://tracker.phpbb.com/browse/PHPBB3-11967

PHPBB3-11444
2015-07-13 22:41:13 +02:00
MateBartus
4bdef6fd21 [ticket/13697] Moving filesystem related functions to filesystem service
* Moving filesystem service to \phpbb\filesystem namespace
 * Wraping Symfony's Filesystem component
 * Moving filesystem related functions from includes/functions.php
   into \phpbb\filesystem\filesystem
   Functions moved (and deprecated):
     - phpbb_chmod
     - phpbb_is_writable
     - phpbb_is_absolute
     - phpbb_own_realpath
     - phpbb_realpath
 * Adding interface for filesystem service

PHPBB3-13697
2015-04-16 13:24:10 +02:00
Joas Schilling
8f67892f5e Merge branch 'develop-ascraeus' into develop 2014-11-22 17:49:06 +01:00
Marc Alexander
f648fe88d5 [ticket/security-171] Modify tests for new file_downloader class
SECURITY-171
2014-11-21 23:49:54 +01:00
Marc Alexander
34004612ac [ticket/security-171] Sanitize data from composer.json
SECURITY-171
2014-11-21 22:32:28 +01:00
Tristan Darricau
a5bfc76a73 [ticket/13063] Introduces a new \phpbb\routing\router class
PHPBB3-13063
2014-11-20 16:03:48 +01:00
Tristan Darricau
0dfe1d0d8b [ticket/13280] Output escaping for the symfony request object
PHPBB3-13280
2014-11-16 16:45:19 +01:00
rxu
ce4035fdd3 [ticket/13059] Add core event to generate_page_link()
Add core event to generate_page_link() to allow
overriding/modifying pagination URLs.
Event request: http://area51.phpbb.com/phpBB/viewtopic.php?f=111&t=45905

PHPBB3-13059
2014-10-01 20:55:07 +08:00
Marc Alexander
4a06511d85 Merge pull request #2932 from Nicofuma/ticket/12963
[ticket/12963] Load extensions migrations from /migration
2014-09-17 00:36:38 +02:00
Tristan Darricau
f4260e261f [ticket/13034] Fix tests
PHPBB3-13034
2014-09-16 01:25:36 +02:00
Tristan Darricau
04e0d305d0 [ticket/12963] Add unit tests
PHPBB3-12963
2014-09-10 19:22:00 +02:00
Tristan Darricau
cb3eb84665 [ticket/13034] Fix the route generated for the frontend not in the phpbb root
PHPBB3-13034
2014-09-04 23:21:55 +02:00
Andreas Fischer
b2a883d504 Merge pull request #2671 from Nicofuma/ticket/12775
[ticket/12775] Replace functions_container with a container_builder class.

* Nicofuma/ticket/12775: (34 commits)
  [ticket/12775] Set dbal.conn.driver as synthetic during installation
  [ticket/12775] Add the definition of dbal.conn in fixtures/config/services.yml
  [ticket/12775] Inject the connection when created in the container
  [ticket/12775] Extract the vars later in install/install_update.php
  [ticket/12775] Rename config_php_handler to config_php_file container_builder
  [ticket/12775] Set defined_vars as a property of config_php_file
  [ticket/12775] Fix doc blocks in the container builder
  [ticket/12775] Remove useless includes of config.php
  [ticket/12775] Move phpbb_convert_30_dbms_to_31 into the config file class
  [ticket/12775] Fix comments
  [ticket/12775] Update doc blocks
  [ticket/12775] Fix container_builder
  [ticket/12775] Rename config_php to config_php_file
  [ticket/12775] Renamed to \phpbb\di\container_builder
  [ticket/12775] Remove the last include of functions_container
  [ticket/12775] Fix unit tests
  [ticket/12775] Add tests for \phpbb\config_php
  [ticket/12775] Add tests for the container factory
  [ticket/12775] Use a field instead of a local var in load_config_var()
  [ticket/12775] Update container and config in install/
  ...
2014-07-11 11:49:51 +02:00
Tristan Darricau
b4d7192b62 [ticket/12787] Updates phpbb_mock_controller_helper
PHPBB3-12787
2014-07-08 00:20:33 +02:00
Tristan Darricau
f2e8e928c0 [ticket/12775] Fix container_builder
PHPBB3-12775
2014-07-07 01:02:36 +02:00
Tristan Darricau
40937e21c5 [ticket/12775] Renamed to \phpbb\di\container_builder
PHPBB3-12775
2014-07-07 01:02:33 +02:00
Tristan Darricau
926e47e5a1 [ticket/12775] Fix unit tests
PHPBB3-12775
2014-07-07 01:02:30 +02:00
Tristan Darricau
1d966fbc86 [ticket/12775] Add tests for the container factory
PHPBB3-12775
2014-07-07 01:02:27 +02:00
Marc Alexander
3508409c89 [ticket/12352] Add tests for phpBB2 md5 passwords driver
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Yuriy Rusko
a759704b39 [ticket/12594] Remove @package tags and update file headers
PHPBB3-12594
2014-05-27 20:51:13 +02:00
Tristan Darricau
346c6f3998 [ticket/11497] Rename set_ext_finder in find_routing_files
PHPBB3-11497
2014-05-05 18:20:14 +02:00
Tristan Darricau
78e1d119f5 [ticket/11497] Change the date in the package declaration
PHPBB3-11497
2014-05-03 19:16:40 +02:00
Tristan Darricau
8d9133a30e [ticket/11497] Use a mock object to define the root folder for the finder
PHPBB3-11497
2014-05-03 14:00:47 +02:00
Matt Friedman
b07ea805d4 [ticket/10521] Fix broken tests using set_cookie
PHPBB3-10521
2014-05-02 17:33:40 -07:00
Nils Adermann
497d81af68 Merge remote-tracking branch 'github-nickvergessen/ticket/12113' into develop-ascraeus
* github-nickvergessen/ticket/12113:
  [ticket/12113] Fix view_log() tests
  [ticket/12113] Correctly use plurals when deleting user warnings
  [ticket/12113] Allow log entries to use plurals
2014-04-10 14:22:36 -07:00