Commit graph

57 commits

Author SHA1 Message Date
Nathaniel Guse
54e9f7b50a Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11103
# By Nathan Guse (28) and others
# Via Andreas Fischer (9) and others
* 'develop' of https://github.com/phpbb/phpbb3: (90 commits)
  [ticket/11350] Do not pass $db by reference; typehint phpbb_db_driver
  [feature/migrations] Remove default values from necessary parameters
  [ticket/11201] Revert WLM dropping because it is still used in China.
  [ticket/11220] Improvement to the info pop-up from "list="
  [feature/migrations] Revert unrelated changes to functions.php
  [ticket/11233] prohibit selecting anonymous user as a PM recipient
  [ticket/11343] Remove spare parentheses.
  [ticket/11343] Remove spare space.
  [ticket/11343] Use === when checking stored user_actkey against user input.
  [ticket/11295] Correct cases: replace postgres with phpbb_db_driver_postgres.
  [ticket/10050] removing prosilver edits
  [ticket/9737] Fix some comments
  [ticket/11337] Abort setup-webserver.sh script when an error occurs.
  [ticket/11337] Only run functional tests on 5.3.19 or higher. No FPM otherwise.
  [ticket/11337] Silence nginx config file writing.
  [ticket/11337] php-fpm.conf is no longer owned by root.
  [ticket/11337] Run functional tests on travis using nginx and php-fpm.
  [ticket/11338] Travis CI: Install PHP extension for redis key-value store.
  [ticket/10050] adding .topicrow to template condition
  [ticket/9737] Fix a few minor things in migrations
  ...

Conflicts:
	phpBB/config/services.yml
	phpBB/config/tables.yml
2013-02-11 21:37:15 -06:00
David Colón
4306a7641f [ticket/10786] Javascript toggle member search panel in memberlist.php
Search functions on the memberlist.php page are now rendered by default and displayed via javascript.  If javascript is disabled the page still works as it previously did.

PHPBB3-10786
2013-01-15 23:29:06 -06:00
David Colón
babe07caef [ticket/10786] Javascript toggle member search panel in memberlist.php
Search functions on the memberlist.php page are now rendered by default and displayed via javascript.  If javascript is disabled the page still works as it previously did.

PHPBB3-10786
2013-01-15 23:29:01 -06:00
Nathan Guse
51e0f002ee Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11103
# By Oleg Pudeyev (37) and others
# Via Oleg Pudeyev (24) and others
* 'develop' of github.com:phpbb/phpbb3: (179 commits)
  [ticket/11323] Add tests for inclusion of defined variables
  [ticket/11324] Add PHP 5.5 environment to travis and allow it to fail.
  [ticket/11321] Recreate schema files with develop/create_schema_files.php
  [ticket/11320] Include functions file as we need phpbb_convert_30_dbms_to_31
  [ticket/11313] Use correct object el instead of eel in alt_text callback
  [ticket/11301] Guidelines: Add spaces in front and after the / operator.
  [ticket/11301] Explicitly cast str offset to int to prevent E_NOTICE on 5.4.
  [ticket/11311] Include asset core.js in subsilver2 overall_footer.html
  [ticket/10949] Remove not needed comma
  [ticket/11309] phpbb_extension_interface::disable_step correct docblock.
  [ticket/10949] Converted missing code to new JS coding guidelines
  [ticket/11302] Correctly select first timezone or selected timezone
  [ticket/11305] Mock container for cache driver in functional create_user()
  [ticket/11305] Check for $cache being null before using it in db drivers.
  [ticket/10805] Compare phpbbAlertTimer against null
  [ticket/11305] Define hook finder as a service on the container.
  [ticket/11305] Adjust comment.
  [ticket/11305] Use phpbb_create_default_container.
  [ticket/11305] Create a normal container during final installation step.
  [ticket/11305] Retrieve cache driver from container rather than cache service.
  ...

Conflicts:
	phpBB/install/schemas/firebird_schema.sql
	phpBB/install/schemas/mssql_schema.sql
	phpBB/install/schemas/mysql_40_schema.sql
	phpBB/install/schemas/mysql_41_schema.sql
	phpBB/install/schemas/oracle_schema.sql
	phpBB/install/schemas/postgres_schema.sql
	phpBB/install/schemas/sqlite_schema.sql
	phpBB/styles/subsilver2/template/overall_footer.html
2013-01-15 11:31:39 -06:00
Marc Alexander
be77194435 [ticket/10949] Remove not needed comma
This comma might actually cause issues in browser. Therefore remove it.

PHPBB3-10949
2013-01-05 11:40:41 +01:00
Marc Alexander
b5cc1ed683 [ticket/10949] Converted missing code to new JS coding guidelines
A few missing semi-colons were also added where needed.

PHPBB3-10949
2013-01-04 22:46:12 +01:00
Marc Alexander
46c33e08b5 Merge remote-tracking branch 'callumacrae/ticket/10949' into ticket/10949
Conflicts:
	phpBB/assets/javascript/core.js
2013-01-04 20:46:56 +01:00
Marc Alexander
daf9de689a [ticket/10954] Add missing semi-colon
PHPBB3-10954
2012-12-18 16:24:58 +01:00
Marc Alexander
55b5336b02 [ticket/10954] Make sure to mark subforums unread and add small fixes
PHPBB3-10954
2012-12-18 09:55:22 +01:00
Marc Alexander
fb60f603ba [ticket/10954] Miscellaneous coding fixes
Remove obsolete or unneeded code. Also fix the behavior of removing
icon_topic_newest by actually removing the link to the first unread post
instead of just removing the icon.

PHPBB3-10954
2012-12-18 00:48:50 +01:00
Marc Alexander
703b77cb77 [ticket/10954] Use quotes in attribute selectors and reduce use of each
PHPBB3-10954
2012-12-16 01:06:32 +01:00
Marc Alexander
ec0241d2ef [ticket/10954] Change currentObject to $this for consistency
PHPBB3-10954
2012-12-16 00:59:12 +01:00
Marc Alexander
46cc204523 [ticket/10954] Use function for closing alert popup
PHPBB3-10954
2012-12-16 00:57:53 +01:00
Marc Alexander
f4ff335369 [ticket/10954] Simplify marking forums read and fix topic marking
PHPBB3-10954
2012-12-15 23:48:33 +01:00
Marc Alexander
b90a56a409 [ticket/10954] Join array of class names instead of creating a string
Previously the string for selecting the correct classes was created
directly. Due to that a subsequent comma had to be removed. By joining the
array of class names with a separator this can be omitted.

PHPBB3-10954
2012-12-15 23:23:32 +01:00
Marc Alexander
61ef870fd5 [ticket/10954] Fix coding guidelines infractions
PHPBB3-10954
2012-12-15 21:12:52 +01:00
Marc Alexander
16c021e986 [ticket/10954] Change behavior of marking topics/forums
It will now display a popup message for 3 seconds which will confirm the
taken action. The amount of DOM traversals have been significantly reduced
and jQuery.each is now used instead of for loops. Additionally, it is now
possible to click on the mark topics/forums read links without triggering
an AJAX error.

PHPBB3-10954
2012-12-14 15:46:45 +01:00
Marc Alexander
5919407a1d [ticket/10954] Fix scope of current_object
PHPBB3-10954
2012-12-13 20:43:38 +01:00
Marc Alexander
a3f18caacc [ticket/10954] Only call $(this) once and reduce number of DOM traversals
PHPBB3-10954
2012-12-13 17:56:09 +01:00
Marc Alexander
a57c81481d [ticket/10954] Mark topics read without popup
Also added missing handling of locked forums.

PHPBB3-10954
2012-12-12 18:38:17 +01:00
Marc Alexander
7ce009f2e2 [ticket/10954] Mark forums read without popup or page refresh
PHPBB3-10954
2012-12-12 12:46:20 +01:00
Nathaniel Guse
68363e362d Merge branch 'develop' of github.com:EXreaction/phpbb3 into ticket/11103
Conflicts:
	phpBB/install/schemas/mssql_schema.sql
	phpBB/report.php
	phpBB/styles/prosilver/template/ucp_prefs_personal.html
	phpBB/styles/subsilver2/template/ucp_prefs_personal.html
2012-11-10 10:58:44 -06:00
Nathan Guse
883a961720 [ticket/11103] Use e.preventDefault();
PHPBB3-11103
2012-10-18 18:25:26 -05:00
Nathan Guse
0d098ae5e5 [ticket/11103] Return false to prevent appending # to the URL
PHPBB3-11103
2012-10-16 18:14:06 -05:00
Nathan Guse
3557b39115 [ticket/11103] Hide notifications flyout on a click outside of the list.
PHPBB3-11103
2012-10-16 17:31:48 -05:00
Nathan Guse
716635c834 [ticket/11103] Fix some language strings
Newlines at end of email files

PHPBB3-11103
2012-10-14 10:58:23 -05:00
Nathaniel Guse
98731b1277 [ticket/11103] Prettify the output for prosilver.
Create a way to mark items read from the output list.

PHPBB3-11103
2012-09-20 10:36:11 -05:00
Callum Macrae
d5a788ae5b [ticket/10949] Converted AJAX coding standards to new guidelines.
Basically, moved parentheses to same line and changed variable names to
camel case.

PHPBB3-10949
2012-06-21 19:16:05 +01:00
Callum Macrae
d6d85dea12 [ticket/10947] Fixed quickmod autosubmit functionality.
PHPBB3-10947
2012-06-20 22:34:17 +01:00
David King
a7045e6572 [feature/qrpreview] Preview from Quick Reply
PHPBB3-10726
2012-03-30 21:43:00 -04:00
Vjacheslav Trushkin
ac320fad05 [ticket/10270] Alter background colors for posts
Change background colors for posts after deleted post

PHPBB3-10270
2012-03-31 02:10:17 +02:00
Igor Wiedler
07826d6679 [feature/ajax] Remove quick-reply AJAX handling until we have something good
The current implementation is not very user friendly, lots of things flashing
in the user's face. We can re-consider AJAX when we have a decent solution.

PHPBB3-10270
2012-03-31 02:10:17 +02:00
Vjacheslav Trushkin
cf92528390 [ticket/10270] Disabling links in disappearing content
Disabling click events for blocks that are being removed via ajax

PHPBB3-10270
2012-03-31 02:10:16 +02:00
Callum Macrae
10055d58cd [ticket/10291] Fixed an AJAX bug on quick reply form submit.
It wasn't fading out.

PHPBB3-10291
2012-03-31 02:10:16 +02:00
Callum Macrae
d8e21952fa [ticket/10273] Fixed accepting / denying posts AJAX.
PHPBB3-10273
2012-03-31 02:10:16 +02:00
Igor Wiedler
2f25173d93 [feature/ajax] Change filter semantics, some minor adjustments
PHPBB3-10270
2012-03-31 02:09:26 +02:00
Igor Wiedler
de82608e6f [feature/ajax] Refactor phpbb.ajaxify event callback
PHPBB3-10270
2012-03-31 02:09:26 +02:00
Igor Wiedler
b8a6a50f5c [feature/ajax] Rename exception to filter
PHPBB3-10270
2012-03-31 02:09:25 +02:00
Vjacheslav Trushkin
2ede0b1c81 [feature/ajax] Better handling for zebra
Better handling for zebra: message is displayed instead of first .zebra. Other .zebra entries are emptied, but not completely removed to avoid changing layout.

PHPBB3-10272
2012-03-31 02:09:25 +02:00
Igor Wiedler
7ed2cbef75 [feature/ajax] Make phpbb.ajaxify signature use single object (more explicit)
PHPBB3-10270
2012-03-31 02:09:25 +02:00
Igor Wiedler
1fc26eb1d5 [feature/ajax] Make quick-mod tools "exception" handling more explicit
PHPBB3-10270
2012-03-31 02:09:24 +02:00
Igor Wiedler
d53c36684d [feature/ajax] JavaScript strict mode
PHPBB3-10270
2012-03-31 02:09:24 +02:00
Igor Wiedler
628074bf70 [feature/ajax] Stylistic JavaScript adjustments
PHPBB3-10270
2012-03-31 02:09:24 +02:00
Igor Wiedler
30888ff2a0 [feature/ajax] Use attr('data-foo') instead of data('foo')
data() is slower and does additional unwanted things like
caching and type conversion. Just reading the value is safer.

PHPBB3-10270
2012-03-31 02:09:23 +02:00
Callum Macrae
d1134f9a90 [ticket/10271] Improved the AJAXification of the quick-mod tools.
Instead of passing the querystring, now gets the value properly.

PHPBB3-10271
2012-03-31 02:09:23 +02:00
Callum Macrae
81e357beef [ticket/10272] Removed some duplication calls to $.fn.data.
PHPBB3-10272
2012-03-31 02:09:22 +02:00
Callum Macrae
0d83e8725b [ticket/10272] Made a JS selector less specific.
Now, style authors can change the posts to not be divs without the code
breaking!

PHPBB3-10272
2012-03-31 02:09:22 +02:00
Callum Macrae
7e88dd0ba6 [ticket/10272] Added a space to the beginning of a comment.
PHPBB3-10272
2012-03-31 02:09:22 +02:00
Callum Macrae
e374678d7e [ticket/10272] Renamed a JavaScript variable.
PHPBB3-10272
2012-03-31 02:09:21 +02:00
Callum Macrae
6d8ecd7104 [ticket/10271] Added a comment to the AJAXification of quick-mod tools.
The comment clarifies which make_ functions use AJAX.

PHPBB3-10271
2012-03-31 02:09:21 +02:00