Fyorl
580cec619b
[ticket/10941] Added subdirectory for file operations
...
Also removed common.php as it was unnecessary.
PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
d89af53f63
[ticket/10941] Added some comments for clarification
...
PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
af8020b388
[ticket/10941] Fixed a failing test
...
Since the is_image change, the filespec class no longer trusts the
browser's reported mimetype and instead checks the file itself. Thus
pretending a text file had the mimetype of an image will no longer
fail, the file will simply not be treated as an image.
PHPBB3-10941
2012-07-09 14:08:20 +01:00
Fyorl
682757c1cb
[ticket/10941] Refactored tearDown to stop iterating over the directory.
...
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
ff7e5d73f7
[ticket/10941] Refactored init_filespec to return new object.
...
Removed $filespec as a property of the filespec test and instead
just instantiate new objects.
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
61d74007a4
[ticket/10941] Minor typo fixes
...
Removed superfluous $user = null; that was left over from refactoring.
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
1bb64ab23e
[ticket/10941] Changed assertTrue to assertEquals
...
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
19405a7f47
[ticket/10941] Now actually checks for the value of errors.
...
Uses phpbb_mock_lang to return the key used when setting errors to
allow that key to be checked for during tests rather than just checking
if any error was set.
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
943af957e6
[ticket/10941] Re-arranged dataProvidor methods to be near their callers
...
PHPBB3-10941
2012-07-09 14:08:19 +01:00
Fyorl
f2bbbdaafa
[ticket/10941] tearDown() now uses explicit file list
...
Instances of $it also renamed for clarity.
PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
82ca2c8b08
[ticket/10941] Minor adjustments as per PR comments
...
Added some comments clarifying globals and lowercased fixture filenames
PHPBB3-10941
2012-07-09 14:08:18 +01:00
Fyorl
fe4056c599
[ticket/10941] Finished filespec tests
...
PHPBB3-10941
2012-07-08 23:59:11 +01:00
Fyorl
d6bd8928b5
[ticket/10941] Minor adjustments as per PR comments
...
Switched from dirname(__FILE__) to just __DIR__.
Removed static definition from data provider methods.
PHPBB3-10941
2012-07-08 23:59:11 +01:00
Fyorl
33a13002af
[ticket/10941] Unit tests for filespec class
...
PHPBB3-10941
2012-07-08 23:59:11 +01:00
