Commit graph

288 commits

Author SHA1 Message Date
Joas Schilling
948bfcbe77 Merge remote-tracking branch 'remotes/phpbb/develop' into feature/softdelete-merge-develop
# By Oleg Pudeyev (45) and others
# Via Oleg Pudeyev (42) and others
* remotes/phpbb/develop: (289 commits)
  [ticket/10865] Use code tags for install/database_update.php.
  [ticket/10865] Should have been a slash.
  [ticket/10780] Use L_COLON on LDAP page.
  [ticket/10780] Use L_COLON on search backend ACP pages.
  [ticket/10780] Use L_COLON for "download all attachments".
  [ticket/10780] Use colon from language in ucp_pm_compose.php where possible.
  [ticket/10780] Replace colons in phpBB/adm/style/acp_ext_details.html.
  [ticket/10780] Replace colon usage in adm template output with {L_COLON}
  [ticket/10780] Replace colon usage in template output with {L_COLON}
  [ticket/11181] Bump PHP requirement to 5.3.3 (from 5.3.2) [develop-olympus]
  [ticket/11181] Bump PHP requirement to 5.3.3 (from 5.3.2)
  [ticket/10172] Show prosilver birthday list even if there are no birthdays.
  [ticket/11050] make all properties protected in all search backends
  [ticket/11050] get_common_words() returns empty array for sphinx
  [ticket/11050] fix tidied search query docblock language
  [ticket/11050] fix min/max length docblock language
  [ticket/11050] multi sentences separated by period in docblocks
  [ticket/11050] fix separated spelling in docblock
  [ticket/11050] fix split words doc block language
  [ticket/11050] remove class word from docblocks
  ...

Conflicts:
	phpBB/install/database_update.php
	phpBB/install/schemas/mssql_schema.sql
	phpBB/language/en/acp/permissions_phpbb.php
	phpBB/styles/prosilver/template/posting_editor.html
2012-11-10 12:27:19 +01:00
Andreas Fischer
f5b3adb296 [ticket/10780] Use L_COLON on search backend ACP pages.
PHPBB3-10780
2012-11-10 00:38:25 +01:00
Oleg Pudeyev
36da105a33 Merge PR #1043 branch 'dhruvgoel92/ticket/11177' into develop
* dhruvgoel92/ticket/11177:
  [ticket/11177] return no results when query has only negation
2012-11-09 14:23:25 -05:00
Dhruv
a509a8ed2d [ticket/11050] make all properties protected in all search backends
PHPBB-11050
2012-11-09 16:46:44 +01:00
Dhruv
c5c9bc5ada [ticket/11050] get_common_words() returns empty array for sphinx
PHPBB-11050
2012-11-09 16:46:37 +01:00
Dhruv
72245e41d0 [ticket/11050] fix tidied search query docblock language
PHPBB3-11050
2012-11-09 15:54:41 +01:00
Dhruv
0556959a6a [ticket/11050] fix min/max length docblock language
PHPBB3-11050
2012-11-09 15:54:40 +01:00
Dhruv
7c3cbc07cf [ticket/11050] multi sentences separated by period in docblocks
Starting of each sentence should be capitalized.

PHPBB3-11050
2012-11-09 15:54:39 +01:00
Dhruv
5a2cbc2417 [ticket/11050] fix separated spelling in docblock
PHPBB3-11050
2012-11-09 15:54:38 +01:00
Dhruv
6ae64f1c1e [ticket/11050] fix split words doc block language
PHPBB3-11050
2012-11-09 15:54:38 +01:00
Dhruv
b7dae379d5 [ticket/11050] remove class word from docblocks
PHPBB3-11050
2012-11-09 15:54:37 +01:00
Dhruv
1ded6d94ac [ticket/11050] add missing @var in native search
PHPBB3-11050
2012-11-09 15:54:36 +01:00
Dhruv
8eed3591a9 [ticket/11050] replace user by phpbb_user
PHPBB3-11050
2012-11-09 15:54:35 +01:00
Dhruv
56395ea359 [ticket/11050] fix minor comment/docblocks issues
No comments should end with a period. All occurences like PostgreSQL
should have proper case.

PHPBB3-11050
2012-11-09 15:54:34 +01:00
Dhruv
5a7ed3c567 [ticket/11050] add access specifiers to native search properties
PHPBB3-11050
2012-11-09 15:54:33 +01:00
Dhruv
3dc42c67d3 [ticket/11050] fix docblocks with description before @var
PHPBB3-11050
2012-11-09 15:54:32 +01:00
Dhruv
4172a9d797 [ticket/11050] add missing @var
PHPBB3-11050
2012-11-09 15:54:31 +01:00
Dhruv
fd20e73b74 [ticket/11050] remove common_words property from sphinx
common_words property is never used in sphinx class hence removed.

PHPBB3-11050
2012-11-09 15:54:30 +01:00
Dhruv
505a713349 [ticket/11050] add access specifiers to sphinx search properties
PHPBB3-11050
2012-11-09 15:54:29 +01:00
Dhruv
db9351d0f6 [ticket/11050] add access specifiers to mysql search properties
PHPBB3-11050
2012-11-09 15:54:28 +01:00
Dhruv
26a9ccab59 [ticket/11050] add access specifiers to pgsql search properties
PHPBB3-11050
2012-11-09 15:54:27 +01:00
Dhruv
01eebd6511 [ticket/11177] return no results when query has only negation
If search query has only -foo then instead of displaying all results that
do not have foo, should display no results found.

PHPBB3-11177
2012-11-09 13:37:01 +01:00
Oleg Pudeyev
18a922c036 [ticket/11174] Started on search tests - keyword splitting.
PHPBB3-11174
2012-11-08 10:14:29 -05:00
Oleg Pudeyev
f1a692a5f4 Merge PR #956 branch 'dhruvgoel92/ticket/11051' into develop
* dhruvgoel92/ticket/11051:
  [ticket/11051] fix spaces
  [ticket/11051] add common_words variable
  [ticket/11051] remove unnecessary comment
  [ticket/11051] add get_word_len() in sphinx search
  [ticket/11051] use get_word_length in search backend
  [ticket/11051] use get_common_words in search backend
  [ticket/11051] function instead of accessing property in search
  [ticket/11051] add public functions for public properties
2012-10-10 00:39:29 -04:00
Dhruv
305abfde96 [ticket/11051] fix spaces
PHPBB3-11051
2012-10-08 10:58:04 +05:30
Joas Schilling
3088855aa6 [feature/soft-delete] Fix SQL error in search
PHPBB3-9567
2012-10-05 17:46:29 +02:00
Dhruv
52b25aaf20 [ticket/11051] add get_word_len() in sphinx search
get_word_len() for sphinx search backend returns false always and
triggers proper error.

PHPBB3-11051
2012-10-04 01:51:57 +05:30
Joas Schilling
a6d3432f8b [feature/soft-delete] Update search to use $post_visibility
Todo: Sphinx currently does not respect this setting at all.

PHPBB3-9657
2012-08-30 22:20:52 +02:00
Joas Schilling
5b54ec2d64 [feature/soft-delete] Try to fix search.php
at least it's running now, but the performance is not very good.

PHPBB3-9657
2012-08-30 19:47:16 +02:00
Josh Woody
b8c55291ed [feature/soft-delete] Lay the groundwork for a soft-delete feature
So far, I've added no new functionality.  The biggest change here is adjusting the DB column names to "visibility" rather than "approved".  Some things here are pretty likely to change, for example the name and location of the topic_visibility class. Happy birthday phpBB :)

PHPBB3-9657
2012-08-29 17:49:37 +02:00
Oleg Pudeyev
89d334ee6a Merge PR #954 branch 'dhruvgoel92/ticket/11032' into develop
* dhruvgoel92/ticket/11032:
  [ticket/11032] fix language of error displayed
2012-08-18 22:26:58 -04:00
Dhruv
d4f1e71d5e [ticket/11032] fix language of error displayed
Language of the error displayed is modified.

PHPBB3-11032
2012-08-15 22:57:02 +05:30
Dhruv
6f61169e41 [ticket/11051] add public functions for public properties
public retrieval functions for all public properties and change the
properties to protected in all search backends.

PHPBB3-11051
2012-08-15 14:13:31 +05:30
Andreas Fischer
64ff06cf87 Merge remote-tracking branch 'dhruvgoel92/ticket/11048' into develop
* dhruvgoel92/ticket/11048:
  [ticket/11048] use protected instead of private in pgsql fulltext
  [ticket/11048] use protected instead of private in native search
  [ticket/11048] remove @access from all docblocks
  [ticket/11048] use protected instead of private in mysql fulltext
  [ticket/11048] use protected instead of private in sphinx
  [ticket/11048] add access specifiers to phpbb native search properties
  [ticket/11048] add access specifiers to sphinx search
  [ticket/11048] add access specifiers to phpbb native search
  [ticket/11048] add access specifiers to mysql search
  [ticket/11048] add access specifiers to pgsql search
2012-08-14 14:38:19 +02:00
Dhruv
a9fd98c136 [ticket/11048] use protected instead of private in pgsql fulltext
PHPBB3-11048
2012-08-14 17:47:01 +05:30
Dhruv
469d808365 [ticket/11048] use protected instead of private in native search
PHPBB3-11048
2012-08-14 17:46:17 +05:30
Dhruv
8e8e94ec4c [ticket/11048] remove @access from all docblocks
PHPBB3-11048
2012-08-14 17:43:01 +05:30
Dhruv
5698d03ead [ticket/11048] use protected instead of private in mysql fulltext
PHPBB3-11048
2012-08-14 17:35:24 +05:30
Dhruv
d0cdf445fb [ticket/11048] use protected instead of private in sphinx
PHPBB3-11048
2012-08-14 17:33:44 +05:30
Dhruv
17b8719144 [ticket/11032] sphinx retries before triggering error
Sphinx connection retries should be done before error is triggered.

PHPBB3-11032
2012-08-11 01:06:07 +05:30
Dhruv
a3a359d80a [ticket/11048] add access specifiers to phpbb native search properties
PHPBB3-11048
2012-08-10 16:35:06 +05:30
Dhruv
42d6e0715f [ticket/11048] add access specifiers to sphinx search
PHPBB3-11048
2012-08-10 14:06:25 +05:30
Dhruv
dd56c401af [ticket/11048] add access specifiers to phpbb native search
PHPBB3-11048
2012-08-10 12:23:25 +05:30
Dhruv
de8b7c0b7d [ticket/11048] add access specifiers to mysql search
PHPBB3-11048
2012-08-10 11:35:50 +05:30
Dhruv
b2e166dbfa [ticket/11048] add access specifiers to pgsql search
PHPBB3-11048
2012-08-10 11:30:02 +05:30
Dhruv
698b7999c4 [ticket/11032] trigger error in case search fails
Admins are shown actual error while users are shown a search failed error
in case sphinx search fails.

PHPBB3-11032
2012-08-10 10:46:32 +05:30
Oleg Pudeyev
7c6e1ba109 Merge PR #916 branch 'dhruvgoel92/ticket/11011' into develop
* dhruvgoel92/ticket/11011:
  [ticket/11011] rename property phpEx to php_ext
  [ticket/11011] pass $auth to search backend constructor
  [ticket/11011] remove global keyword from sphinx
  [ticket/11011] pass global variables in construct
  [ticket/11011] passing global variables
  [ticket/11011] remove global keyword in native search
  [ticket/11011] remove global keyword in pgsql search
  [ticket/11011] global variables as constructor parameters
  [ticket/11011] add access specifiers and docblocks
2012-08-08 03:19:00 -04:00
Dhruv
a422ddfe31 [ticket/11011] rename property phpEx to php_ext
PHPBB3-11011
2012-08-08 11:16:46 +05:30
Dhruv
794d6ec443 [ticket/11011] pass $auth to search backend constructor
$auth global var is passed to search backend constructor, as it is used
by sphinx backend.

PHPBB3-11011
2012-08-08 11:07:47 +05:30
Dhruv
9358bf3de5 [ticket/11032] use method GetLastError to get error
Instead of using _error property, use method GetLastError to retrieve
the error as sphinx API documentation states.

PHPBB3-11032
2012-08-01 22:23:51 +05:30