David M
7b262babcd
Alright, this should give some improved performance :)
...
This is the end of random seek access to rows. If you have a compelling reason as to why they should stay, contact me. Else, they are gone forevermore...
The following API calls are deprecated:
acm::sql_rowseek() -> no replacement
$db->sql_fetchfield($field, $rownum = false, $query_id = false) -> $db->sql_fetchfield($field, $query_id = false)
Initial tests show that phpBB3 over four percent of memory against phpBB3.1 on an empty board. So far so good :)
Other cool things:
db2, MS SQL ODBC and MS SQL 2005 all use less memory because they do not need to reference the last executed query to handle random access seeks :)
P.S.
The crazy people using SVN: please report any issues with the new way we itterate through caches, I do not want to miss anything :)
git-svn-id: file:///svn/phpbb/trunk@8372 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-02-03 10:19:04 +00:00
Meik Sievertsen
1407460895
Merging revisions #r8346, #r8347 and #r8348
...
git-svn-id: file:///svn/phpbb/trunk@8349 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-29 15:57:56 +00:00
David M
5195509f3b
#19285
...
git-svn-id: file:///svn/phpbb/trunk@8324 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-13 08:46:37 +00:00
David M
9dcb557a5e
I suppose I should fix this :P
...
git-svn-id: file:///svn/phpbb/trunk@8322 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-13 07:47:41 +00:00
David M
b9da54ba91
arg, the voices in my head won't let me focus :P
...
git-svn-id: file:///svn/phpbb/trunk@8321 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-11 06:25:28 +00:00
David M
24a359e9f5
db tools can now drop tables
...
git-svn-id: file:///svn/phpbb/trunk@8320 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-11 06:17:46 +00:00
David M
cbb4db46b2
- use proper OOP for db_tools
...
- made it all static. If one of you disagree, you are free to change it. I just couldn't think of a reason of having it otherwise...
git-svn-id: file:///svn/phpbb/trunk@8319 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-11 05:07:33 +00:00
David M
35f59ceb9a
we enter a brave new world...
...
- fix schema data so that it can now be used
- replace the current system of packaging schemas with phpBB with a new system that dynamically generates the schemas on the fly
- give the db tools package the power to create databases
git-svn-id: file:///svn/phpbb/trunk@8318 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-10 21:46:46 +00:00
David M
b9b46a8b45
- phpBB now uses a less ancient version of Oracle
...
git-svn-id: file:///svn/phpbb/trunk@8317 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-09 00:21:29 +00:00
David M
370e189f15
- make viewforum work again
...
- remove the lower case functions, they were stupid anyway
- added some indexes
- added a group_name_clean column
git-svn-id: file:///svn/phpbb/trunk@8315 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-08 06:44:05 +00:00
David M
2928574ed4
- a few tiny clean ups
...
- a new MS SQL DBAL, it does not work so hot because of issues with the extension it depends on
git-svn-id: file:///svn/phpbb/trunk@8313 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-07 15:19:38 +00:00
David M
2f08a36062
- add DB2 support
...
/me takes a nap
git-svn-id: file:///svn/phpbb/trunk@8308 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-06 13:46:20 +00:00
David M
57645ad5bc
the end of an era...
...
- MySQL < 4.1.3 support is removed
- renamed mysql4 to mysql, no need to cause confusion
- changed the cfg cacher, reduces file system lookups and include count by two on every page load
git-svn-id: file:///svn/phpbb/trunk@8307 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-06 02:21:44 +00:00
David M
af738dbc2a
Ch-ch-ch-changes
...
- Made us more DB independent by making many queries capability based instead of DB specific
- Finished PHP5ifying of the acm_file class, now with some (hopefully) enhancements to its performance
- Sped up viewforum considerably (also goes towards mcp_forum)
I really hope I didn't explode CVS...
git-svn-id: file:///svn/phpbb/trunk@8301 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-04 18:35:49 +00:00
David M
85055ac97f
oh boy...
...
- Migrate code base to PHP 5.1+
git-svn-id: file:///svn/phpbb/trunk@8295 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-01-03 17:00:40 +00:00
Meik Sievertsen
718b3f9df6
commit all transactions on closing the db (there is only one, but we support inner transactions - logically speaking)
...
git-svn-id: file:///svn/phpbb/trunk@8271 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-12-06 12:27:53 +00:00
Meik Sievertsen
8cf535f5cf
- on database update, execute garbage_collection(). This ensures a proper closed db and written cache
...
- on sql errors returning (and not triggering an error) execute the rollback too
both "bugs" resulted in transactions left open if a query returned an error on database update preventing a clean update. Symptoms being for example oracle users not having all database info updated, the version number not changing or config variables not written.
git-svn-id: file:///svn/phpbb/trunk@8270 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-12-06 08:55:19 +00:00
Meik Sievertsen
c698a2571a
further updates
...
git-svn-id: file:///svn/phpbb/trunk@8248 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-11-19 16:44:30 +00:00
Meik Sievertsen
a4d0eba781
hopefully fixing bug #14890 - need to test later
...
git-svn-id: file:///svn/phpbb/trunk@8247 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-11-19 13:33:29 +00:00
David M
aee82d3a30
MSSQL works properly with SQL update related tools
...
git-svn-id: file:///svn/phpbb/trunk@8198 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-16 14:59:39 +00:00
Meik Sievertsen
6b334d8b7c
small fix
...
- david: please review the mssql change
git-svn-id: file:///svn/phpbb/trunk@8165 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-12 10:04:44 +00:00
Meik Sievertsen
7de5bb3498
dumdidum... sorry. ;)
...
git-svn-id: file:///svn/phpbb/trunk@8147 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-05 14:36:34 +00:00
David M
6ea4a146af
misc SQLite bugs
...
git-svn-id: file:///svn/phpbb/trunk@8101 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-09-22 21:58:04 +00:00
Meik Sievertsen
685282c2cb
- some language tweaks suggested by John
...
- some bug fixes
- finally adding db_tools...
git-svn-id: file:///svn/phpbb/trunk@8088 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-09-13 15:01:15 +00:00
Meik Sievertsen
e503216834
some tiny fixes...
...
git-svn-id: file:///svn/phpbb/trunk@8087 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-09-12 15:32:11 +00:00
Meik Sievertsen
1d004b925f
necessary changes...
...
git-svn-id: file:///svn/phpbb/trunk@8072 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-08-30 21:21:16 +00:00
David M
4d0b422884
#14207
...
git-svn-id: file:///svn/phpbb/trunk@8069 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-08-24 18:09:59 +00:00
David M
4c50481379
#14211
...
- doing is_null on Oracle is not good, we return empty strings instead
git-svn-id: file:///svn/phpbb/trunk@8068 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-08-24 18:00:28 +00:00
Meik Sievertsen
445a0631e5
patch by david for #14182
...
git-svn-id: file:///svn/phpbb/trunk@8066 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-08-24 16:36:23 +00:00
Meik Sievertsen
521dfdbb05
increase the odbc limit (64k is too low, the theme data itself is >64k)
...
git-svn-id: file:///svn/phpbb/trunk@8038 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-08-16 15:38:13 +00:00
David M
8ab583dce0
turn on strict mode for databases that support it
...
git-svn-id: file:///svn/phpbb/trunk@8029 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-08-14 12:27:35 +00:00
David M
f684da8e93
#13916
...
git-svn-id: file:///svn/phpbb/trunk@7995 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-08-02 05:05:44 +00:00
David M
35152dcd53
#13874
...
git-svn-id: file:///svn/phpbb/trunk@7981 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-30 03:16:31 +00:00
Meik Sievertsen
306581d905
this should work fine now...
...
git-svn-id: file:///svn/phpbb/trunk@7937 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-24 15:17:47 +00:00
David M
8f7a4d27c6
#13151
...
git-svn-id: file:///svn/phpbb/trunk@7849 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-09 15:33:38 +00:00
David M
d3468832bb
#13033
...
git-svn-id: file:///svn/phpbb/trunk@7835 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-05 15:45:24 +00:00
David M
20fe34157e
Firebird too
...
git-svn-id: file:///svn/phpbb/trunk@7791 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-24 15:34:46 +00:00
Meik Sievertsen
5aa220bcd2
tweak the sql_like_expression feature a little bit to allow correct escaping
...
git-svn-id: file:///svn/phpbb/trunk@7789 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-24 12:49:13 +00:00
Meik Sievertsen
318418b0f2
new wrapper for LIKE expressions to streamline the fixes. We actually need to adjust them for different DBMS as well as SQLite2 not supporting escaping characters in LIKE statements (which is a reason why we think about dropping sqlite support completely).
...
git-svn-id: file:///svn/phpbb/trunk@7788 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-23 12:16:20 +00:00
David M
f81bb91eca
#12415
...
git-svn-id: file:///svn/phpbb/trunk@7778 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-18 16:21:51 +00:00
David M
eaed6d806e
- tiny changes
...
git-svn-id: file:///svn/phpbb/trunk@7773 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-18 12:05:58 +00:00
David M
367f5103d9
- Oracle can't handle IN clauses with more than 1000 elements (Bug #12449 )
...
- Firebird can now work properly in PHP4
git-svn-id: file:///svn/phpbb/trunk@7767 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-16 13:49:49 +00:00
Meik Sievertsen
6160b613bc
correctly re-assign query result
...
git-svn-id: file:///svn/phpbb/trunk@7753 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-12 21:24:22 +00:00
David M
f31c53963a
- Oracle gives us null instead of '', this is now fixed (thanks APTX)
...
- Oracle can now explain queries
git-svn-id: file:///svn/phpbb/trunk@7741 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-09 14:58:50 +00:00
Meik Sievertsen
455536773f
ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)
...
git-svn-id: file:///svn/phpbb/trunk@7736 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-09 11:11:20 +00:00
David M
dd9c236e6a
- Oracle, woe is you... I will say this much, this fixes Oracle's handling of empty strings... We also fix custom profiles and now provide database size for Oracle...
...
git-svn-id: file:///svn/phpbb/trunk@7721 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-07 05:58:45 +00:00
David M
17315b69c6
d'oh!
...
git-svn-id: file:///svn/phpbb/trunk@7676 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-25 12:25:46 +00:00
David M
49d351be1d
- added support for Oracle's easy connect naming
...
git-svn-id: file:///svn/phpbb/trunk@7671 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-23 23:47:59 +00:00
David M
3899e337e6
#11255
...
#11259
#11291
#11335
#11457
#11473
#11475
#11511
#11523
#11527
git-svn-id: file:///svn/phpbb/trunk@7663 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-22 21:32:26 +00:00
Meik Sievertsen
456586475b
oh my god - what did he do? Adding attachment display to post/topic review, queue, reports, post details, mcp topic view... fixing other tiny things along the line.
...
git-svn-id: file:///svn/phpbb/trunk@7642 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-19 12:04:22 +00:00