Commit graph

2856 commits

Author SHA1 Message Date
Nils Adermann
9a2c29a175 [ticket/11700] DI container test needs namespaces to work properly
PHPBB3-11700
2013-09-16 00:40:27 +02:00
Nils Adermann
d122d84050 [ticket/11700] Use underscores for generated search test wrappers
PHPBB3-11700
2013-09-16 00:39:36 +02:00
Nils Adermann
2a1207b14f [ticket/11700] Correclty use namespaces in notifications
PHPBB3-11700
2013-09-16 00:39:34 +02:00
Nils Adermann
239381b946 [ticket/11700] Fix expected class name output from dbms convert
PHPBB3-11700
2013-09-16 00:39:32 +02:00
Nils Adermann
e10c3d8c08 [ticket/11700] Fix config namespace mishap in cache tests
PHPBB3-11700
2013-09-16 00:39:30 +02:00
Nils Adermann
76dfe153fc [ticket/11700] Fix class loader tests for namespaces
PHPBB3-11700
2013-09-16 00:39:27 +02:00
Nils Adermann
97012dd851 [ticket/11700] Fix dbal tests after config namespace mishap
PHPBB3-11700
2013-09-16 00:39:22 +02:00
Nils Adermann
1a6202d517 [ticket/11700] Fix config db tests after namespace mishap
PHPBB3-11700
2013-09-16 00:39:08 +02:00
Nils Adermann
43c5ed570f [ticket/11700] Fix avatar tests
PHPBB3-11700
2013-09-16 00:29:14 +02:00
Nils Adermann
b95fdacdd3 [ticket/11700] Move all recent code to namespaces
PHPBB3-11700
2013-09-16 00:25:27 +02:00
Marc Alexander
19512b2595 [feature/passwords] Rename "crypto" files to "passwords" files
PHPBB3-11610
2013-09-14 14:04:48 +02:00
Marc Alexander
b810957c4b [feature/passwords] Properly set convert_flag and add test for it
PHPBB3-11610
2013-09-14 13:55:53 +02:00
Marc Alexander
8b9370c6a9 [feature/passwords] Define default hashing algorithm in container file
The default hashing algorithm type is defined as a parameter in the service
definition file for the password hashing system. This will allow us to change
this in the future but it will also prevent unexperienced admins from changing
the hashing algorithm.

PHPBB3-11610
2013-09-14 13:55:45 +02:00
Marc Alexander
9b24fda5cd [feature/passwords] Move files after namespacing changes
PHPBB3-11610
2013-09-14 13:55:28 +02:00
Marc Alexander
2e453eb2cb [feature/passwords] Add legacy support for md5 passwords
PHPBB3-11610
2013-09-14 13:55:23 +02:00
Marc Alexander
bd4664807f [feature/passwords] Increase code coverage in bcrypt driver
PHPBB3-11610
2013-09-14 13:55:18 +02:00
Marc Alexander
3a776ed0af [feature/passwords] Increase test coverage of salted_md5 driver
PHPBB3-11610
2013-09-14 13:55:13 +02:00
Marc Alexander
b6473a515b [feature/passwords] Increase manager test coverage to cover all methods
All methods in the manager are now fully covered.

PHPBB3-11610
2013-09-14 13:55:00 +02:00
Marc Alexander
fcb7130823 [feature/passwords] Use randomly generated password for tests
The password will start with 'foobar' and then continue with random
characters that will be appended every iteration.

PHPBB3-11610
2013-09-14 13:54:33 +02:00
Marc Alexander
ddc207fae8 [feature/passwords] Fix tests on PHP versions < 5.3.7
PHPBB3-11610
2013-09-14 13:54:27 +02:00
Marc Alexander
cfbd858bd7 [feature/passwords] Properly treat duplicates in combined hashes
PHPBB3-11610
2013-09-14 13:54:21 +02:00
Marc Alexander
6f33ca85a2 [feature/passwords] Add tests for combined hashing of passwords
PHPBB3-11610
2013-09-14 13:54:06 +02:00
Marc Alexander
4b81b93d10 [feature/passwords] Make sure hash has the required length
Also added tests to make sure that crypto drivers are enforcing the hash
length.

PHPBB3-11610
2013-09-14 13:53:08 +02:00
Marc Alexander
e7b3daeb29 [feature/passwords] Add tests for manager check_hash() method
Tests cover all supported hashing algorithms.

PHPBB3-11610
2013-09-14 13:52:57 +02:00
Marc Alexander
13d25e6a32 [feature/passwords] Fix tests for PHP version < 5.3.7
PHPBB3-11610
2013-09-14 13:52:52 +02:00
Marc Alexander
33725f6e2f [feature/passwords] Include driver helper in manager_test
PHPBB3-11610
2013-09-14 13:52:33 +02:00
Marc Alexander
61e98fbd63 [feature/passwords] Add driver helper class for additional functions
Functions for the helper class might be used in other drivers as well and
therefore shouldn't be limited to just one driver.

PHPBB3-11610
2013-09-14 13:52:25 +02:00
Marc Alexander
c9fafcefd3 [feature/passwords] Add basic passwords manager test file
PHPBB3-11610
2013-09-14 13:52:15 +02:00
Nathan Guse
b8bb16f8e7 Merge remote-tracking branch 'remotes/upstream/develop-olympus' into develop
* remotes/upstream/develop-olympus:
  [ticket/11831] getAttribute was replaced with attr
  [ticket/11831] Update fabpot/goutte to 1.0.*

Conflicts:
	phpBB/composer.lock
2013-09-13 15:56:28 -05:00
Nathan Guse
b4a374dc73 [ticket/11832] Fix INCLUDE(JS/CSS)
PHPBB3-11832
2013-09-13 10:58:03 -05:00
Nathan Guse
21624e79fc [ticket/11832] Fix constructions of phpbb_filesystem
PHPBB3-11832
2013-09-13 10:04:35 -05:00
Nathan Guse
aa710df2db [ticket/11832] Create phpbb_symfony_request to handle initiating symfony_request
Now symfony_request is also a service (removed the function
phpbb_create_symfony_request).

Inject symfony request into filesystem

Cleanup for the tests

PHPBB3-11832
2013-09-13 09:52:02 -05:00
Joas Schilling
958f3e9503 Merge remote-tracking branch 'imkingdavid/ticket/11824' into develop 2013-09-13 16:48:28 +02:00
Nathan Guse
a194e6ce7a Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11832
# By Nathan Guse (22) and others
# Via Nathan Guse (10) and others
* 'develop' of github.com:phpbb/phpbb3: (39 commits)
  [ticket/11843] Added newlines and included numbers in the DEFINE vars test
  [ticket/11843] Add checking DEFINE variables with underscores to template_test
  [ticket/11843] The twig lexer fixes DEFINE variables with underscores again
  [ticket/11727] Fix indentation
  [ticket/11727] Fix indentation
  [ticket/11745] Correct language, coding guidelines
  [ticket/11828] Fix greedy operators in lexer
  [ticket/11833] Prevent Twig errors from invalid template loops using BEGINELSE
  [ticket/11833] Fix bad template loop
  [ticket/11816] !$DOESNT_EXIST test
  [ticket/9550] Add the core.viewtopic_post_rowset_data event to viewtopic.php
  [ticket/11829] Use report_closed to determine status in MCP report_details
  [ticket/11816] Test !$DEFINITION
  [ticket/11822] Use namespace lookup order for asset loading
  [ticket/11727] Template loader support for safe directories to load files from
  [ticket/11816] Fix define/loop checks in IF statements containing parenthesis
  [ticket/11373] Use inheritdoc
  [ticket/11637] generate_text_for_display on search.php
  [ticket/11744] Cast to int
  [ticket/11744] Inheritdoc
  ...
2013-09-13 09:15:23 -05:00
rechosen
658f6e2045 [ticket/11843] Added newlines and included numbers in the DEFINE vars test
Per suggestion of nickvergessen, I added newlines in the DEFINE variables with
underscores test. Now if the test fails, it's easier to spot which part is
failing. Also added a test for DEFINE variables containing numbers.

PHPBB3-11843
2013-09-13 13:53:39 +02:00
rechosen
45ecbae1ed [ticket/11843] Add checking DEFINE variables with underscores to template_test
To prevent the underscore in DEFINE variables from being forgotten again,
the template tests now test INCLUDEing a file based on the contents of a
DEFINE variable with underscores in it.

PHPBB3-11843
2013-09-13 12:27:07 +02:00
David King
f22b959257 Merge pull request #1620 from EXreaction/ticket/11745
Group join approved notification
2013-09-12 21:25:00 -07:00
David King
d629738675 Merge pull request #1617 from EXreaction/ticket/11744
[ticket/11744] Group join request notification
2013-09-12 21:24:11 -07:00
Nathan Guse
bcb1392351 Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11816
# By Joseph Warner (187) and others
# Via Nathan Guse (6) and others
* 'develop' of github.com:phpbb/phpbb3: (195 commits)
  [ticket/11828] Fix greedy operators in lexer
  [ticket/11835] Fix ucp_auth_link adding in migration
  [prep-release-3.0.12] Remove changelog entry for ticket that was not resolved.
  [ticket/develop/11832] Fix path detection
  [feature/oauth] Fix tabindex
  [ticket/9550] Add the core.viewtopic_post_rowset_data event to viewtopic.php
  [ticket/11829] Use report_closed to determine status in MCP report_details
  [feature/oauth] Fix bug on ucp_auth_link related to error display
  [feature/oauth] More small fixes
  [feature/oauth] More minor changes from review
  [feature/oauth] Fix small bug introduced by update in OAuth library
  [feature/oauth] Fix small issues on ucp pages
  [feature/oauth] Fix typo in OAuth logout method
  [feature/oauth] Make token storage service ignorant
  [feature/oauth] Update oauth::logout() to use clearAllTokens()
  [feature/oauth] Update storage implementation due to inteface change
  [feature/oauth] Update lusitanian/oauth to stable branch
  [ticket/11822] Use namespace lookup order for asset loading
  [feature/oauth] Update comment on oauth service exception
  [feature/oauth] Forgot to remove placeholder comment
  ...

Conflicts:
	phpBB/phpbb/template/twig/lexer.php
	tests/template/template_test.php
2013-09-12 22:56:54 -05:00
Nathan Guse
8c2f73bb09 [ticket/11828] Fix greedy operators in lexer
Use lazy operators and use stricter validation

PHPBB3-11828
2013-09-12 14:15:41 -05:00
Nathan Guse
baa73f6933 Merge remote-tracking branch 'remotes/imkingdavid/ticket/11824' into ticket/11832
* remotes/imkingdavid/ticket/11824:
  [ticket/11824] Revert changes in functions.php
  [ticket/11824] Reorganize test file
  [ticket/11824] Update language string for board settings
  [ticket/11824] Revert changes to functions_content.php
  [ticket/11824] Add tests for urls with mod_rewrite enabled
  [ticket/11824] Correct a comment
  [ticket/11824] Change copyright year in migration file
  [ticket/11824] Remove unused globals
  [ticket/11824] Fix smilies
  [ticket/11824] Fix logic
  [ticket/11824] Add option for mod_rewrite
2013-09-12 12:45:17 -05:00
Nathan Guse
d9fdf41ad8 Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11832
# By Joseph Warner (187) and others
# Via Andreas Fischer (2) and others
* 'develop' of github.com:phpbb/phpbb3: (189 commits)
  [ticket/11835] Fix ucp_auth_link adding in migration
  [prep-release-3.0.12] Remove changelog entry for ticket that was not resolved.
  [feature/oauth] Fix tabindex
  [feature/oauth] Fix bug on ucp_auth_link related to error display
  [feature/oauth] More small fixes
  [feature/oauth] More minor changes from review
  [feature/oauth] Fix small bug introduced by update in OAuth library
  [feature/oauth] Fix small issues on ucp pages
  [feature/oauth] Fix typo in OAuth logout method
  [feature/oauth] Make token storage service ignorant
  [feature/oauth] Update oauth::logout() to use clearAllTokens()
  [feature/oauth] Update storage implementation due to inteface change
  [feature/oauth] Update lusitanian/oauth to stable branch
  [feature/oauth] Update comment on oauth service exception
  [feature/oauth] Forgot to remove placeholder comment
  [feature/oauth] OAuth service exception
  [feature/oauth] A few more minor changes
  [feature/oauth] Changes due to code review
  [feature/oauth] Fix redirects
  [feature/oauth] Fix issues on ucp_login_link from review
  ...
2013-09-12 11:56:36 -05:00
David King
2f91fc9f6c [ticket/11824] Reorganize test file
PHPBB3-11824
2013-09-12 09:22:51 -07:00
Nathan Guse
b06c8a80d1 [ticket/11832] Fix the web path corrections
Add some real life examples to test

PHPBB3-11832
2013-09-12 10:25:49 -05:00
Nathan Guse
3a4efa7959 [ticket/11832] More extensive testing
PHPBB3-11832
2013-09-10 11:15:24 -05:00
Nathan Guse
c46637990e [ticket/11832] Use dirname(__FILE__)
PHPBB3-11832
2013-09-10 10:14:57 -05:00
Nathan Guse
3684d8e971 [ticket/11832] Use $phpbb_filesystem instead of the container in append_sid
PHPBB3-11832
2013-09-10 10:13:26 -05:00
Nathan Guse
d5f93f5ce4 Revert "[ticket/11832] Make $phpbb_container a global initiated by the framework"
This reverts commit 5e09afa0bc.
2013-09-10 10:06:13 -05:00
Nathan Guse
5e09afa0bc [ticket/11832] Make $phpbb_container a global initiated by the framework
Setup common items needed from the container (e.g. filesystem)

PHPBB3-11832
2013-09-09 18:47:25 -05:00
Nathan Guse
289bc2a411 [ticket/11832] Fix log tests
PHPBB3-11832
2013-09-09 18:27:12 -05:00