There is no reason not to use request_var() here because it is available anyway
since 3afd2c6948.
This change especially prevents submitting an array which might then throw an
error in one of the string functions substr() or strpos() later on.
PHPBB3-10038
* develop-olympus:
[ticket/10029] Use $_SERVER['SERVER_PROTOCOL'] for determining HTTP version.
[ticket/9805] Setup security repository for developers.
[ticket/9805] Move check lower down.
[ticket/9805] Better support for already existing repositories.
[ticket/9805] Add dry-run option.
[ticket/9805] Use getopt(), add a few options, extend show_usage().
[ticket/9805] Script for easily cloning a whole github network.
* ticket/p/10013:
[ticket/10013] Use mkdir to create directory trees.
[ticket/10013] Fixed cache test to create intermediate directories.
[ticket/10013] Changed cache test to use tests/tmp/cache as cache directory
This is the first step of making the test suite use a single directory
for writing files to, this directory being tests/tmp.
The cache test, instead of tests/cache/tmp, now writes to tests/tmp/cache.
Also remove cache directory in setUp method, in case an earlier test run
did not complete successfully and the cache directory was not cleaned up.
Finally, this change makes the cache test take responsibility over the entire
contents of its cache directory.
PHPBB3-10013
* ticket/nickvergessen/9823:
[ticket/9823] Replace 0x80000000 with -2147483648 in tests.
[ticket/9823] Move mock file into the mock/ folder.
[ticket/9823] Update Unit tests to the new system and correct some minor issues
[ticket/9823] Update copyright year and add newline at the end of the file.
[ticket/9823] Correct unit-tests to use self:: instead of the class-name.
[ticket/9823] Unit tests for validate_config_vars.
[ticket/9823] Unit tests for build_cfg_template.
[ticket/9823] Unit tests for validate_rang.
[ticket/9823] Unit tests for h_radio.
[ticket/9823] Moving the functions. Unit tests for build_select.
Conflicts:
phpBB/adm/index.php
On 32-bit php, -2147483648, despite fitting in the int type,
is for some reason made into a floating-point value. Use an
explicit cast to make it an integer.
PHPBB3-10020
Due to the usage of `__DIR__` for the file includes the tests can't
be ran on systems with PHP < 5.3. Replace all occurances of
`__DIR__` with `dirname(__FILE__)`.
PHPBB3-10011
* develop-olympus:
[ticket/9985] 3D Wave CAPTCHA: Pass min/max in the correct order to mt_rand().
[ticket/9989] Skip PM popup in overall_header.html, if there are no new PMs.
The comment in the code says: "We now get the first number passed and will
select the key based upon this number". But the loop over the arguments is not
left and therefore it uses the last int-value not the first one.
PHPBB3-9949
