Commit graph

13448 commits

Author SHA1 Message Date
David King
8e480a8725 [feature/controller] Move include to app.php
PHPBB3-10864
2012-11-16 17:05:46 -05:00
David King
db1d49d559 [feature/controller] Rename get_paths to import_paths_from_finder
Also removed unused variable from url_matcher function

PHPBB3-10864
2012-11-16 17:05:46 -05:00
David King
b4eff4f06a [feature/controller] Remove URL Base from helper class
I had forgotten that the container sends the same instance of objects to all
services that request it, so in this case all controllers would share the same
base url path, which is not desired.

PHPBB3-10864
2012-11-16 17:05:45 -05:00
David King
aead33432a [feature/controller] Remove dumped container when cache is purged
PHPBB3-10864
2012-11-16 17:05:44 -05:00
David King
c54c3ee422 [feature/controller] A few minor nitpickings
PHPBB3-10864
2012-11-16 17:05:44 -05:00
David King
fa43edd877 [feature/controller] Further separate url matcher functionality
PHPBB3-10864
2012-11-16 17:05:43 -05:00
David King
4cb9ec522c [feature/controller] Separate Kernel listeners into their own classes
PHPBB3-10864
2012-11-16 17:05:42 -05:00
David King
196c2d4bc3 [feature/controller] Move new functions to their own file
PHPBB3-10864
2012-11-16 17:05:41 -05:00
David King
269a56e2c3 [feature/controller] Undo removal of period in ext.finder service definition
PHPBB3-10864
2012-11-16 17:05:41 -05:00
David King
d3aa8823b2 [feature/controller] Use a dumped url matcher class to improve performance
PHPBB3-10864
2012-11-16 17:05:40 -05:00
David King
5877bf1b1b [feature/controller] Update helper service given constructor change
PHPBB3-10864
2012-11-16 16:47:32 -05:00
David King
c6a5699325 [feature/controller-new] Fix line endings
PHPBB3-10864
2012-11-16 16:47:31 -05:00
David King
2e59450459 [feature/controller] Use assign_display() instead of return_display()
The latter was deemed unnecessary at the moment.

PHPBB3-10864
2012-11-16 16:47:30 -05:00
David King
6900456e90 [feature/controller] Revert changes to template class
As per IRC, assign_display() effectively does what return_display() was added
to do, so no change was needed.

PHPBB3-10864
2012-11-16 16:47:29 -05:00
David King
ef46af8298 [feature/controller] Don't attempt to assign if no variable is give
PHPBB3-10864
2012-11-16 16:47:29 -05:00
David King
b5255d4ea4 [feature/controller] Fix syntax error in template code
PHPBB3-10864
2012-11-16 16:47:28 -05:00
David King
ac29c7e9d9 [feature/controller] Rework assign_display(), use exceptions instead of return
PHPBB3-10864
2012-11-16 16:47:22 -05:00
David King
4b6d538b06 [feature/controller] Rename kernel pass class properly
PHPBB3-10864
2012-11-16 16:45:29 -05:00
David King
7687f06961 [feature/controller] Inject dependencies instead of container
PHPBB3-10864
2012-11-16 16:45:28 -05:00
David King
6e647cf6e1 [feature/controller] Resolve trivial conflict I missed during rebase
PHPBB3-10864
2012-11-16 16:45:27 -05:00
David King
dd1f8a0e55 [feature/controller-new] Call pass to subscribe the Kernel event listener
PHPBB3-10864
2012-11-16 16:45:26 -05:00
David King
cba0be96a9 [feature/controller] Fix 403 Forbidden error 2012-11-16 16:25:16 -05:00
David King
4e1f17a87d [feature/controller] includes/functions.php is included by default
PHPBB3-10864
2012-11-16 16:25:15 -05:00
David King
97957d6792 [feature/controller-new] Rename kernel compiler pass class
PHPBB3-10864
2012-11-16 16:25:14 -05:00
David King
5c86a1660d [feature/controller] Don't allow a kernel listener to be added with no method
PHPBB3-10864
2012-11-16 16:25:12 -05:00
David King
067a770730 [feature/controller] Transfer kernel-related stuff from container PR
PHPBB3-10864
2012-11-16 16:25:10 -05:00
David King
06158693c7 [feature/controller] Implement a front controller
PHPBB3-10864
2012-11-16 16:25:09 -05:00
David King
ca09eb94e3 [ticket/11211] Fix typo in phpbb_realpath() method name
PHPBB3-11211
2012-11-16 14:38:53 -05:00
Oleg Pudeyev
1a2dfa6d4c Merge PR #1074 branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11192] Merge dataProvider arrays because the test is the same now.
  [ticket/11192] Update $value parameter description to support other types.
  [ticket/11192] Mark negative byte numbers as unsupported.
  [ticket/11192] Test strings not converted to int/float before.
  [ticket/11192] Also test strings, e.g. sums returned by the database.
  [ticket/11192] Also test powers of 10 / 1000.
  [ticket/11192] Add tests.
  [ticket/11192] Add Tebibyte to get_formatted_filesize().
2012-11-16 10:29:22 -05:00
Oleg Pudeyev
af5d8b502e Merge PR #1074 branch 'bantu/ticket/11192' into develop-olympus
* bantu/ticket/11192:
  [ticket/11192] Merge dataProvider arrays because the test is the same now.
  [ticket/11192] Update $value parameter description to support other types.
  [ticket/11192] Mark negative byte numbers as unsupported.
  [ticket/11192] Test strings not converted to int/float before.
  [ticket/11192] Also test strings, e.g. sums returned by the database.
  [ticket/11192] Also test powers of 10 / 1000.
  [ticket/11192] Add tests.
  [ticket/11192] Add Tebibyte to get_formatted_filesize().
2012-11-16 10:25:06 -05:00
Andreas Fischer
efd6f1df63 [ticket/11192] Update $value parameter description to support other types.
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Andreas Fischer
7cbd440e7a [ticket/11192] Mark negative byte numbers as unsupported.
PHPBB3-11192
2012-11-16 14:56:15 +01:00
Oleg Pudeyev
9c86f70b4a Merge PR #1041 branch 'cyberalien/ticket/11175' into develop
* cyberalien/ticket/11175:
  [ticket/11175] Add microdata to prosilver
  [ticket/11175] Add microdata to subsilver2
2012-11-15 22:09:52 -05:00
Igor Wiedler
d061a5abf8 [ticket/11206] Remove includes to non-existent files from download/file.php
This makes avatars work again.

PHPBB3-11206
2012-11-16 00:34:08 +01:00
Oleg Pudeyev
5d0796624f [ticket/11205] Fix merge conflict in readme.html.
PHPBB3-11205
2012-11-15 17:45:00 -05:00
Oleg Pudeyev
ceae276cd6 Merge PR #1085 branch 'nickvergessen/ticket/11198' into develop
* nickvergessen/ticket/11198:
  [ticket/11198] Remove additional asterix as /** is doc-block only
  [ticket/11198] Store the swapping partners in vars and simplify the logic
  [ticket/11198] Correctly set links after an item is moved up/down with AJAX
2012-11-15 11:20:27 -05:00
Joas Schilling
132163d4ec [ticket/11198] Remove additional asterix as /** is doc-block only
PHPBB3-11198
2012-11-15 16:26:36 +01:00
Oleg Pudeyev
c30b38ba10 Merge PR #1088 branch 'igorw/ticket/11199' into develop
* igorw/ticket/11199:
  [ticket/11199] Match cache purge container files against container_*
  [ticket/11199] Purge dumped container correctly on cache purge.
2012-11-15 09:07:41 -05:00
Oleg Pudeyev
f2cffd6a6c [ticket/11200] Add a reminder comment.
PHPBB3-11200
2012-11-15 08:50:04 -05:00
Igor Wiedler
31843ecd8c [ticket/11200] Make cache available during container construction
Fixes fatal errors in the dbal.

PHPBB3-11200
2012-11-15 05:00:24 +01:00
Igor Wiedler
a0cc2878a3 [ticket/11199] Match cache purge container files against container_*
Previously it was matching against only container*, checking for the
underscore is consistent with the other checks.

PHPBB3-11199
2012-11-15 02:30:43 +01:00
Igor Wiedler
73ce1a5a97 [ticket/11199] Purge dumped container correctly on cache purge.
This patch changes the dumped container suffix to a prefix instead which
makes the existing code for purging 'cache/container_*' files work
as intended.

PHPBB3-11199
2012-11-15 01:56:33 +01:00
Oleg Pudeyev
30e9d2d600 [ticket/11199] Revert merge of 'marc1706/ticket/11199' into develop
This reverts commit 303fc646ad, reversing
changes made to 9c28470ad7.

The correct fix should be to alter the container file name to start with
container_ prefix.

PHPBB3-11199
2012-11-14 19:07:28 -05:00
Marc Alexander
d982d432eb [ticket/11199] Cache purge does not remove dumped container
PHPBB3-11199
2012-11-14 23:34:28 +01:00
Joas Schilling
e39947e57e [ticket/11198] Store the swapping partners in vars and simplify the logic
PHPBB3-11198
2012-11-14 23:30:29 +01:00
Joas Schilling
857298e748 [ticket/11198] Correctly set links after an item is moved up/down with AJAX
PHPBB3-11198
2012-11-14 16:31:46 +01:00
Marc Alexander
5f15c98c1d [ticket/11197] Prefix the css classes for the small arrow with "arrow"
It does not make sense to have classes named "right" and "left" produce a
small arrow next to text. It should be made clear that an arrow will
appear.

PHPBB3-11197
2012-11-13 20:57:34 +01:00
Andreas Fischer
607865d97a Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10879] Remove arrow icon from attachment link in editor
2012-11-13 20:36:18 +01:00
Marc Alexander
170967c48a [ticket/10879] Remove arrow icon from attachment link in editor
If you upload a file with a long filename the filename will partially
cover the arrow icon background image. Remove the icon as it's not needed
anyways.

PHPBB3-10879
2012-11-13 20:26:49 +01:00
David King
d33aaac199 [ticket/11195] Condense logic, remove improperly formatted if()
PHPBB3-11195
2012-11-12 16:16:40 -05:00