Commit graph

8798 commits

Author SHA1 Message Date
Stanislav Atanasov
992fb8e452 [ticket/12691] Comment change
Change a bit the core event comment

PHPBB3-12691
2014-06-22 22:03:01 +03:00
Stanislav Atanasov
e8dd7904e9 [ticket/12691] Change event to core.delete_pm_before
Just a requested change by nickvergessen

PHPBB3-12691
2014-06-22 22:03:00 +03:00
Stanislav Atanasov
cd31aea4be [ticket/12691] Add core.delete_pm to funtion delete_pm
Add core.delete_pm to funtion delete_pm.
Event will return:
int $user_id - ID of the user requested the message delete
array $msg_ids - array of all messages to be deleted
int $folder_id - ID of the user folder where the messages are stored
Justification:
Allow extensions to capture this event
and act as intended by ext author

PHPBB3-12691
2014-06-22 22:03:00 +03:00
Tristan Darricau
32a2c95f90 [ticket/12723] Add Sniff ensuring PHP files use the correct file header
PHPBB3-12723
2014-06-22 00:45:34 +02:00
Joas Schilling
b855f5fc6a Merge pull request #2566 from marc1706/ticket/11711
[ticket/11711] Inform user of unsupported characters while posting

* marc1706/ticket/11711:
  [ticket/11711] Improve coding and comments of character check
  [ticket/11711] Reduce size of tests and also test topic titles
  [ticket/11711] Improve checks for unsupported characters and check subject
  [ticket/11711] Inform user of unsupported characters while posting
2014-06-20 10:51:58 +02:00
Dhruv Goel
7ee3e3f73f Merge pull request #2588 from nickvergessen/ticket/12705
Ticket/12705 Fix make_clickable when called with different server_urls
2014-06-17 14:56:55 +05:30
Tristan Darricau
afcca62784 [ticket/12721] Update rules descriptions
PHPBB3-12721
2014-06-16 23:07:28 +02:00
Tristan Darricau
a94581e7ca [ticket/12721] Add Squiz.ControlStructures.ForLoopDeclaration in legacy
PHPBB3-12721
2014-06-16 22:35:44 +02:00
Tristan Darricau
09fc008e62 [ticket/12721] Add Squiz.ControlStructures.ElseIfDeclaration in legacy
PHPBB3-12721
2014-06-16 22:35:41 +02:00
Tristan Darricau
34a4ba36cd [ticket/12721] Add Squiz.Arrays.ArrayBracketSpacing in the legacy ruleset
PHPBB3-12721
2014-06-16 22:35:12 +02:00
Tristan Darricau
ca3cdadd08 [ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
PHPBB3-12722
2014-06-16 19:05:09 +02:00
Tristan Darricau
5a320adc75 [ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset
PHPBB3-12724
2014-06-16 01:26:59 +02:00
Dhruv Goel
587759bd6a Merge pull request #2431 from Nicofuma/ticket/12109
[ticket/12109] Bug when setting permissions with "Select all users"
2014-06-15 13:04:35 +05:30
Andreas Fischer
0260c0ccaf [ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.
PHPBB3-12707
2014-06-14 12:28:47 +02:00
Joas Schilling
f1adf82aea [ticket/12705] Store the regular expression matches based on server_url
PHPBB3-12705
2014-06-14 11:35:27 +02:00
Andreas Fischer
a262bfc78f Merge pull request #2570 from Nicofuma/ticket/12687
[ticket/12687] Add a constant to display the load time without DEBUG

* Nicofuma/ticket/12687:
  [ticket/12687] Remove french spaces
  [ticket/12687] Display the number of cached queries
  [ticket/12687] Don't check if memory_get_peak_usage() exists
  [ticket/12687] Wrap $GLOBALS['starttime'] in a if
  [ticket/12687] Fix the namespace of $request
  [ticket/12687] Update doc block
  [ticket/12687] Use microtime(true)
  [ticket/12687] Remove globals
  [ticket/12687] Return a string and move the displaying of the sql report
  [ticket/12687] Rename DISPLAY_LOAD_TIME to PHPBB_DISPLAY_LOAD_TIME
  [ticket/12687] Display the explain link only when DEBUG is set
  [ticket/12687] Add a constant to display the load time without DEBUG
2014-06-13 16:28:19 +02:00
Tristan Darricau
8e9b27314b [ticket/12687] Remove french spaces
PHPBB3-12687
2014-06-13 14:56:55 +02:00
Tristan Darricau
bbc63456f9 [ticket/12687] Display the number of cached queries
PHPBB3-12687
2014-06-13 14:55:29 +02:00
Tristan Darricau
c605e8f423 [ticket/12687] Don't check if memory_get_peak_usage() exists
PHPBB3-12687
2014-06-13 14:54:13 +02:00
Tristan Darricau
dc4132a494 [ticket/12687] Wrap $GLOBALS['starttime'] in a if
PHPBB3-12687
2014-06-13 14:53:30 +02:00
Tristan Darricau
f7f65fe6c2 [ticket/12687] Fix the namespace of $request
PHPBB3-12687
2014-06-13 00:03:27 +02:00
Tristan Darricau
d70554760f [ticket/12687] Update doc block
PHPBB3-12687
2014-06-12 23:43:01 +02:00
Tristan Darricau
b93269f7bb [ticket/12687] Use microtime(true)
PHPBB3-12687
2014-06-12 23:35:55 +02:00
Tristan Darricau
6c0fd61b1d [ticket/12687] Remove globals
PHPBB3-12687
2014-06-12 23:27:19 +02:00
Tristan Darricau
ceef85ee0e [ticket/12687] Return a string and move the displaying of the sql report
PHPBB3-12687
2014-06-12 14:33:00 +02:00
Marc Alexander
afbf4ba296 [ticket/12694] Remove whitespace at end of line from acp_groups
PHPBB3-12694
2014-06-11 19:03:36 +02:00
Nils Adermann
694f8391c9 Merge remote-tracking branch 'github-marc1706/ticket/12352' into develop-ascraeus
* github-marc1706/ticket/12352: (33 commits)
  [ticket/12352] Do not check hashes that don't have the necessary length
  [ticket/12352] Update file headers to fit new format
  [ticket/12352] Use custom provider collection for auth providers
  [ticket/12352] Add checks for existing user_pass_convert to migrations
  [ticket/12352] Remove usages of user_pass_convert column
  [ticket/12352] Update schema json file
  [ticket/12352] Remove user_pass_convert column from database
  [ticket/12352] Check each newly added passwords driver in manager_test
  [ticket/12352] Add get_settings_only method to passwords driver base
  [ticket/12352] Add passwords driver for xenforo 1.0, 1.1 passwords
  [ticket/12352] Add tests for wcf1 and wcf2 drivers
  [ticket/12352] Add driver for woltlab community framework 1 passwords
  [ticket/12352] Add driver for woltlab community framework 2 passwords
  [ticket/12352] Add missing $ to md5_mybb and md5_vb driver
  [ticket/12352] Fix spacing in passwords tests
  [ticket/12352] Add passwords driver for vB passwords
  [ticket/12352] Use correct hashing method in md5_mybb driver
  [ticket/12352] Add driver for myBB md5 passwords
  [ticket/12352] Rename phpbb2_md5 driver to fit filenames of other drivers
  [ticket/12352] Add passwords driver for sha1 password hashes
  ...
2014-06-11 14:27:57 +02:00
Tristan Darricau
06e6c91513 [ticket/12687] Rename DISPLAY_LOAD_TIME to PHPBB_DISPLAY_LOAD_TIME
PHPBB3-12687
2014-06-11 14:27:11 +02:00
Joas Schilling
d7ebc2c1fc [ticket/12688] Correctly use web root path instead of phpbb root path
PHPBB3-12688
2014-06-10 21:24:24 +02:00
Tristan Darricau
1e769ba87f [ticket/12687] Display the explain link only when DEBUG is set
PHPBB3-12687
2014-06-10 17:52:41 +02:00
Tristan Darricau
39b76a628b [ticket/12687] Add a constant to display the load time without DEBUG
PHPBB3-12687
2014-06-10 16:13:09 +02:00
Marc Alexander
5ee7f20f4e [ticket/11711] Improve coding and comments of character check
PHPBB3-11711
2014-06-10 15:51:25 +02:00
Joas Schilling
d45c681b40 [ticket/12508] Fix usages of the finder
PHPBB3-12508
2014-06-10 11:47:39 +02:00
Joas Schilling
456ff2559a Merge pull request #2518 from Pico88/ticket/12606
[ticket/12606] Add ACP group core events

* Pico88/ticket/12606:
  [ticket/12606] Add ACP group core events
2014-06-10 00:13:11 +02:00
Joas Schilling
771cbb2b3a Merge pull request #2434 from Nicofuma/ticket/8610
[ticket/8610] Merging topics does not handle bookmarks correctly

* Nicofuma/ticket/8610:
  [ticket/8610] Use css selector instead of xPath
  [ticket/8610] Add functional test when two topics are merged
  [ticket/8610] Throw an error when the dest topic isn't set
  [ticket/8610] Fix bookmarks when merging all the posts of a topic
  [ticket/8610] Merging topics does not handle bookmarks correctly
2014-06-09 22:57:27 +02:00
Marc Alexander
b8151b1299 [ticket/11711] Improve checks for unsupported characters and check subject
PHPBB3-11711
2014-06-09 18:56:13 +02:00
Pico88
74842b2354 [ticket/12606] Add ACP group core events
PHPBB3-12606
2014-06-09 18:56:04 +02:00
Nils Adermann
b6232aa9b2 Merge remote-tracking branch 'github-nickvergessen/ticket/10073' into develop-ascraeus
* github-nickvergessen/ticket/10073: (36 commits)
  [ticket/10073] Fix button descriptions
  [ticket/10073] Do not check disable boxes by default
  [ticket/10073] Store values with config_text in the ACP
  [ticket/10073] Move config values to config_text
  [ticket/10073] Fix request usage
  [ticket/10073] Deduplicate template variable names
  [ticket/10073] Get service from container
  [ticket/10073] Fix more "Contact Us" strings
  [ticket/10073] Move template code into the template
  [ticket/10073] Make contact page available when board is disabled
  [ticket/10073] Change name of the ACP module
  [ticket/10073] Deduplicate posting buttons code in ACP
  [ticket/10073] Use phpbb_validate_email to verify email address
  [ticket/10073] Add tests for new validate_email()
  [ticket/10073] Split email validation from email ban and taken checks
  [ticket/10073] Deduplicate the if statement
  [ticket/10073] Fallback to board_contact when contact page is disabled
  [ticket/10073] Remove language string from rebase conflict
  [ticket/10073] Add ACP module to add bbcode text for contact admin info
  [ticket/10073] Add new configs to the schema
  ...
2014-06-09 17:55:25 +02:00
Marc Alexander
89f7067377 [ticket/11711] Inform user of unsupported characters while posting
PHPBB3-11711
2014-06-09 17:48:06 +02:00
rxu
1ee39d8c93 [ticket/12668] Add subforums_row to core.display_forums_modify_template_vars
Add subforums template data array to
'core.display_forums_modify_template_vars' event
to allow extensions to modify it if needed.

PHPBB3-12668
2014-06-09 22:22:54 +08:00
Joas Schilling
41a5c3bf2b Merge pull request #2554 from rxu/ticket/12669
[ticket/12669] Add core event to the function display_forums()

* rxu/ticket/12669:
  [ticket/12669] Add core event to the function display_forums()
2014-06-09 16:09:23 +02:00
Knecht Ruprecht
4d3fcd19ac [ticket/12677] Replace ‘thread’ with ‘topic’ in functions_display comment
PHPBB3-12677
2014-06-09 15:42:14 +02:00
Dhruv
5e9cb35457 Merge branch 'develop-olympus' into develop-ascraeus
# By Andreas Fischer
# Via Andreas Fischer (1) and Dhruv Goel (1)
* develop-olympus:
  [ticket/12660] Improve check for when phpinfo() is disabled.
2014-06-09 13:23:49 +05:30
Andreas Fischer
a0c442d16e [ticket/12660] Improve check for when phpinfo() is disabled.
PHPBB3-12660
2014-06-09 03:28:57 +02:00
Joas Schilling
e3c3a5d2a7 [ticket/10073] Do not check disable boxes by default
PHPBB3-10073
2014-06-09 01:36:19 +02:00
Marc Alexander
e8174f3d66 [ticket/12675] Fix code sniffer complaints introduced by recent commits
PHPBB3-12675
2014-06-09 00:51:01 +02:00
Andreas Fischer
ae35c4b05c [ticket/12673] IMAGETYPE_SWC might be missing when SWC is not supported.
PHPBB3-12673
2014-06-08 16:46:55 +02:00
rxu
d5865e316c [ticket/12669] Add core event to the function display_forums()
Add core event to the function display_forums()
in includes/functions_display.php to allow assigning additional template data
for every forum, f.e. additional forumrow subloops.

PHPBB3-12669
2014-06-08 16:32:28 +08:00
Andreas Fischer
f9c0a6b96e Merge pull request #2526 from Nicofuma/ticket/12639
[ticket/12639] Delete entry in admin-log leads to mysql-error

* Nicofuma/ticket/12639:
  [ticket/12639] Add a space in the code generated by generate_sql_keyword()
  [ticket/12639] Handle $conditions['keywords'] outside of the loop
  [ticket/12639] Don't make a copy of $marked when deleting logs in acp_logs
  [ticket/12639] Send a correct IN entry when deleting marked logs
  [ticket/12639] Use assertSame
  [ticket/12639] Remove old commented tests
  [ticket/12639] Order the results correctly in the test
  [ticket/12639] Fix tests on postgres
  [ticket/12639] Update tests to use a dataProvider
  [ticket/12639] Add a test case with an empty keywords list
  [ticket/12639] Delete entry in admin-log leads to mysql-error
2014-06-04 23:59:20 +02:00
Tristan Darricau
3e31764007 [ticket/12639] Don't make a copy of $marked when deleting logs in acp_logs
PHPBB3-12639
2014-06-02 23:22:36 +02:00