Commit graph

16438 commits

Author SHA1 Message Date
Joas Schilling
0f204595d9 [ticket/11405] Fix "only variables should be passed by reference"
PHPBB3-11405
2013-03-26 20:17:24 +01:00
Joas Schilling
81cf02e057 [ticket/11405] Order users in bookmark, in order to pass postgres tests
PHPBB3-11405
2013-03-26 13:54:33 +01:00
Marc Alexander
34cdbd0360 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11314
Conflicts:
	phpBB/styles/prosilver/template/timezone.js
2013-03-26 13:18:54 +01:00
Marc Alexander
f0b0978538 [ticket/11314] Modify files to comply with coding standards
PHPBB3-11314
2013-03-26 13:13:33 +01:00
Joas Schilling
e20b0a4234 [ticket/11405] Use different fixtures so it's not a total mess
PHPBB3-11405
2013-03-26 13:06:04 +01:00
Joas Schilling
7e2f80ec0a [ticket/11405] Add unit tests for bookmarking
PHPBB3-11405
2013-03-26 12:59:35 +01:00
Joas Schilling
cdd45cb8ba [ticket/11405] Move test to submit_post_base.php and use data sets for testing
PHPBB3-11405
2013-03-26 12:58:14 +01:00
Marc Alexander
4870387f3a [ticket/11314] Fix JSHint issues in adm editor.js
This time without changing the behavior.

PHPBB3-11314
2013-03-26 11:19:03 +01:00
Marc Alexander
36168b311e [ticket/11314] Fix issues mentioned in jshint report
Additionally, the editor.js files are now the same file in both
subsilver2, prosilver, and the acp.

PHPBB3-11314
2013-03-26 10:31:28 +01:00
Andreas Fischer
fc8bf3f3c7 [ticket/11469] Add comment about using sql_multi_insert when not buffering.
PHPBB3-11469
2013-03-25 17:01:44 +01:00
Joas Schilling
053c75543d [ticket/11405] Correctly prefill the tables (missed the posts and not-types)
PHPBB3-11405
2013-03-25 15:34:18 +01:00
Joas Schilling
060876e627 [ticket/11405] Add a base class to avoid duplicated setUp() code
PHPBB3-11405
2013-03-25 15:16:29 +01:00
Joas Schilling
1259117d21 [ticket/11405] Sort $users array in order to prevent issues on postgres
PHPBB3-11405
2013-03-25 15:07:06 +01:00
Joas Schilling
499eded880 [ticket/11405] Add unit tests for quoted users notifications
PHPBB3-11405
2013-03-25 15:07:05 +01:00
Joas Schilling
7d5949ae3d [ticket/11405] Fix some coding style issues
PHPBB3-11405
2013-03-25 14:37:22 +01:00
Joas Schilling
a91ffe06c7 [ticket/11405] Send post notifications to forum subscribers
Like in 3.0 we should also send notifications about new posts to users
that subscribed to the forum. (Subscriptions are verbose)

PHPBB3-11405
2013-03-25 09:28:53 +01:00
Andreas Fischer
d3decaeedf [ticket/11460] Add default behaviour tests for notification and email types.
PHPBB3-11460
2013-03-24 23:42:13 +01:00
Joas Schilling
bc5f8e30d0 [ticket/11405] Add some basic tests for notifications in submit_post()
Poster, should NOT receive a notification
Topic subscribed, should receive a notification
Topic subscribed, but unauthed to read, should NOT receive a notification
Topic subscribed, but already notified, should NOT receive a new notification
Topic and forum subscribed, should receive ONE notification
Forum subscribed, should receive a notification
Forum subscribed, but already notified, should NOT receive a new notification

PHPBB3-11405
2013-03-23 13:20:32 +01:00
Andreas Fischer
02817158fc [ticket/11460] Configure functional test board email using dummy SMTP data.
PHPBB3-11460
2013-03-22 22:42:05 +01:00
Andreas Fischer
69df6b49db [ticket/11460] Add test for whether post_email and topic_email are checked.
PHPBB3-11460
2013-03-22 22:16:24 +01:00
Matt Friedman
73d6855edf [ticket/10155] Make effectively installed test more specific
PHPBB3-10155
2013-03-22 11:22:25 -07:00
Andreas Fischer
16a6025372 [ticket/11469] Add SQL insert buffer allowing easier handling of multi inserts.
1. Tries to prevent going over max packet size by flushing to the database
   after a certain number of rows have been added.
2. Because of 1., it is less likely to reach a connection timeout when
   inserting a huge number of rows.
3. By flushing the buffer when a certain size is reached, memory usage should
   be lower compared to building the whole insert row set first.

PHPBB3-11469
2013-03-21 23:12:31 +01:00
Andreas Fischer
15aec0bbb2 [ticket/11460] Add methods for checkbox handling to phpbb_functional_test_case.
PHPBB3-11460
2013-03-21 03:07:50 +01:00
Matt Friedman
940d16b585 [ticket/11463] Add title attribute to topics in search results
We use this title attribute in viewforum_body.html, but not in
search_results.html. Perhaps we should, as this will maintain
consitency between all these topic view pages.

PHPBB3-11463
2013-03-20 11:39:06 -07:00
Oleg Pudeyev
8b464e87f0 Merge PR #1298 branch 'nickvergessen/ticket/11438' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/11438:
  [ticket/11438] Add spaces after # comment start and before \ line breaks
  [ticket/11438] Add helpful comments from sample config to ACP output
  [ticket/11438] Add empty sql_query_pre to delta-source
  [ticket/11438] Move backslash to concatenate the query strings correctly
  [ticket/11438] Update sphinx.sample.conf to one provided by config_generate()
2013-03-20 11:43:14 -04:00
Matt Friedman
3089f5d0bb [ticket/11461] cut doc entry to 79 cols
PHPBB3-11461
2013-03-19 13:32:48 -07:00
Matt Friedman
578ed03b7e [ticket/11461] Further clarify doc for viewtopic_body_footer_before
PHPBB3-11461
2013-03-19 13:32:48 -07:00
Matt Friedman
c9da6c5952 [ticket/11461] Add viewtopic_body_footer_before to the event docs
PHPBB3-11461
2013-03-19 13:32:42 -07:00
Matt Friedman
433fbfd4d9 [ticket/11461] Add template event in the footer of view topic pages
PHPBB3-11461
2013-03-19 13:32:17 -07:00
Andreas Fischer
1ac94699e4 [ticket/11460] Drop incorrect phpbb_notification_{type,method}_ prefix.
PHPBB3-11460
2013-03-19 19:25:34 +01:00
Joas Schilling
b51a66b60b Merge remote-tracking branch 'bantu/ticket/11457' into develop
* bantu/ticket/11457:
  [ticket/11457] Remove check and include for set_var function. It's not used.
2013-03-18 13:51:30 +01:00
Joas Schilling
99d0c7e62b Merge remote-tracking branch 'bantu/ticket/11455' into develop
* bantu/ticket/11455:
  [ticket/11455] Restore alphabetic order (underscore first) in config/tables.yml
2013-03-18 10:42:51 +01:00
Matt Friedman
ac26be98c6 [ticket/10155] Use more descriptive title for migration file
PHPBB3-10155
2013-03-17 17:01:38 -07:00
Andreas Fischer
58d7acbf5a [ticket/11452] Now notification_method_email checks whether user has address.
Make sure the user has an email address set before offering email
notifications. The address could be missing for whatever reason, e.g. external
authentication. This is also consistent with XMPP/Jabber now.

PHPBB3-11452
2013-03-17 19:54:32 +01:00
Andreas Fischer
3c99a33e87 [ticket/11457] Remove check and include for set_var function. It's not used.
PHPBB3-11457
2013-03-17 18:58:43 +01:00
Andreas Fischer
76262f186f [ticket/11455] Restore alphabetic order (underscore first) in config/tables.yml
PHPBB3-11455
2013-03-17 18:31:49 +01:00
Andreas Fischer
c9e7247ab4 [ticket/11445] Add abstract class phpbb_notification_method_messenger_base.
PHPBB3-11445
2013-03-16 21:50:30 +01:00
Andreas Fischer
51c1ba12c1 Merge remote-tracking branch 'nickvergessen/ticket/11443' into develop
* nickvergessen/ticket/11443:
  [ticket/11443] Fix Migrator Modules Tool by creating a phpbb_log object
  [ticket/11443] Add _test suffix to migration test filenames
2013-03-16 01:44:36 +01:00
Joas Schilling
4168cfd7e6 [ticket/11443] Fix Migrator Modules Tool by creating a phpbb_log object
PHPBB3-11443
2013-03-16 01:24:50 +01:00
Joas Schilling
c50af28077 [ticket/11438] Add spaces after # comment start and before \ line breaks
PHPBB3-11438
2013-03-16 01:18:15 +01:00
erangamapa
21a9462553 [ticket/11106] Added missing line breaks.
Added two missing line breaks into 'edited by' message.

PHPBB3-11106
2013-03-16 00:05:12 +05:30
Joas Schilling
afd3681208 Merge remote-tracking branch 'bantu/ticket/11441' into develop
* bantu/ticket/11441:
  [ticket/11441] Split user loader tests into multiple test methods.
  [ticket/11441] Use setUp() in phpbb_user_loader_test.
  [ticket/11441] Update/correct copyright year of user loader test.
  [ticket/11441] Correct/fix class name of user loader test.
  [ticket/11441] Add _test prefix to user loader test filename.
2013-03-15 19:06:54 +01:00
Matt Friedman
56914e72b7 [ticket/10155] Use new migration file for jQuery config update 2013-03-15 09:51:34 -07:00
David King
aaee4c69d9 Merge pull request #7 from nickvergessen/ticket/imkingdavid/11334-2
[ticket/11334] Allow parameters to be specified in the route
2013-03-15 09:49:26 -07:00
Joas Schilling
3b0cdc5362 [ticket/11334] Allow parameters to be specified in the route
PHPBB3-11334
2013-03-15 15:21:15 +01:00
Joas Schilling
9157095cda [ticket/11334] Fix copyright year in test file
PHPBB3-11334
2013-03-15 09:18:15 -04:00
Joas Schilling
076711d9a9 [ticket/11334] Use mocks instead of making parameters optional
PHPBB3-11334
2013-03-15 09:18:14 -04:00
Joas Schilling
9259e635ca [ticket/11334] Move unit tests for helper->url() into own file
PHPBB3-11334
2013-03-15 09:18:13 -04:00
Joas Schilling
ff9a0e4ef4 [ticket/11334] Expand functionality of helper->url()
Expanded the functionality of helper->url() to support all parameters of
append_sid() itself.

PHPBB3-11334
2013-03-15 09:18:12 -04:00
Joas Schilling
cd697e6812 [ticket/11334] Include functions.php and fix class name in tests
PHPBB3-11334
2013-03-15 09:18:11 -04:00