Commit graph

8183 commits

Author SHA1 Message Date
Joas Schilling
b334a2ce0f [ticket/11495] Move classes to tree/ as they all implement a tree
PHPBB3-11495
2013-04-25 17:04:37 +02:00
Joas Schilling
c72f5bf487 [ticket/11495] Explain use of set_subset_zero on remove_subset()
PHPBB3-11495
2013-04-25 16:24:31 +02:00
Joas Schilling
804f139be0 [ticket/11495] Use default exceptions
PHPBB3-11495
2013-04-25 16:17:58 +02:00
Joas Schilling
9d7d962c0d [ticket/11495] Explain what "given item" means
PHPBB3-11495
2013-04-25 14:08:06 +02:00
Joas Schilling
fe97915fc9 [ticket/11495] Split get_branch_data into multiple methods
PHPBB3-11495
2013-04-25 14:05:41 +02:00
Joas Schilling
ab7054445f [ticket/11495] Rename set_parent to change_parent()
PHPBB3-11495
2013-04-25 13:48:19 +02:00
Joas Schilling
3efae6d8af [ticket/11495] Explain whether move_children prepends/appends/overwrittes
PHPBB3-11495
2013-04-25 13:44:52 +02:00
Joas Schilling
4bff28a0ee [ticket/11495] Rename fix function to regenerate_left_right_ids()
This method regenerates the left/right ids for the nested set based on the
parent/child relations. This function executes three queries per item, so
it should only be called, when the set has one of the following problems:
- The set has a duplicated value inside the left/right id chain
- The set has a missing value inside the left/right id chain
- The set has items that do not have a left/right is set

When regenerating the items, the items are sorted by parent id and their
current left id, so the current child/parent relationships are kept and
running the function on a working set will not change any orders.

PHPBB3-11495
2013-04-25 13:40:25 +02:00
Joas Schilling
61e72d3a10 [ticket/11495] Explain move() more
An item is only moved up/down within the same parent. If the delta is larger
then the number of children, the item is moved to the top/bottom of the list
of children within this parent.

PHPBB3-11495
2013-04-25 13:09:00 +02:00
Nils Adermann
7b144bbff2 Merge pull request #1369 from EXreaction/ticket/11335
Ticket/11335
2013-04-25 04:01:38 -07:00
Nils Adermann
6d0b183553 Merge pull request #1367 from EXreaction/ticket/11454
Ticket/11454 - Jabber notifications are not working at all
2013-04-25 03:59:34 -07:00
Joas Schilling
e8b192fa32 [ticket/11495] Do not compare to null anymore (left over from item class)
PHPBB3-11495
2013-04-25 12:57:21 +02:00
Nathaniel Guse
9c4553c41f [ticket/11335] Replace "$phpEx" with $phpEx
PHPBB3-11335
2013-04-24 20:39:24 -05:00
Nathaniel Guse
0d2d72e8ee [ticket/11454] Check if the fields are set
PHPBB3-11454
2013-04-24 20:28:35 -05:00
Nathan Guse
f49993766e [ticket/11335] (more) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:46:00 -05:00
Nathan Guse
14f1340903 [ticket/11335] (avatars) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:45:46 -05:00
Nathan Guse
df70b6ebe6 [ticket/11335] (kernel request subscriber) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:45:41 -05:00
Nathan Guse
fe89e56686 [ticket/11335] (hook finder) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:45:39 -05:00
Nathan Guse
ce230f8dea [ticket/11335] (extension manager/finder) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:45:36 -05:00
Nathan Guse
6ef363547a [ticket/11335] (controller/helper.php) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:45:33 -05:00
Nathan Guse
e870c04067 [ticket/11335] (class loader) Make php_ext 'php' not '.php'
PHPBB3-11335
2013-04-24 17:45:30 -05:00
Nathan Guse
fcdfe748b8 [ticket/11454] Use set_addresses in other applicable areas
This should fix some other bugs that may not have yet been recognized--some
areas only set to(), but sent according to user_notify_type, which is not
necessarily email.

PHPBB3-11454
2013-04-24 15:34:12 -05:00
Nathaniel Guse
ebb5169a46 [ticket/11454] Add messenger function set_addresses
Automatically fills to/im from a user row

Send messenger the Jabber address if using Jabber notifications

PHPBB3-11454
2013-04-24 15:19:37 -05:00
Nils Adermann
b8c2bf6ce4 Merge remote-tracking branch 'github-asperous/ticket/9975' into develop
* github-asperous/ticket/9975:
  [ticket/9975] Moved a few E_USER_ERROR errors to /language

Conflicts:
	phpBB/includes/user.php
2013-04-24 19:16:46 +02:00
Nils Adermann
b3497d955f Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/9975] Translate missing style error message

Conflicts:
	phpBB/includes/session.php
2013-04-24 19:13:47 +02:00
Nils Adermann
aaf109e07d Merge pull request #1326 from dhruvgoel92/ticket/11485
[ticket/11485] add columns to update_schema before adding data
2013-04-24 09:59:41 -07:00
Nils Adermann
81daf21dc0 Merge pull request #1324 from nickvergessen/ticket/10844-2
Ticket/10844 Extensions are not located when front-end file has a diffferent phpbb_root_path
2013-04-24 09:52:57 -07:00
Nils Adermann
3e32655c7f Merge pull request #1290 from nickvergessen/ticket/11362
Correctly sanitise the directory path in finder
2013-04-24 09:45:34 -07:00
Nathaniel Guse
212971a3a6 [ticket/11454] Correct jabber global available check
Copied from msg_jabber()

PBPBB3-11454
2013-04-24 10:37:53 -05:00
asperous
9f545a7f6b [ticket/9975] Moved a few E_USER_ERROR errors to /language
There were a few error messages that a user could experience that would, previously, be without any the ability to be localized. There are some more E_USER_ERRORs that I did not change to a constant, for example the error message that is displayed if there aren't any folders in /language.

PHPBB3-9975
2013-04-23 09:55:36 -07:00
Joas Schilling
16e70fa086 [ticket/11362] Use container when available instead of creating a new instance
PHPBB3-11362
2013-04-22 00:49:41 +02:00
Gaëtan Muller
802fbbb444 [ticket/9975] Translate missing style error message
The error message about missing style data was not
translated

PHPBB3-9975
2013-04-21 17:38:49 +02:00
Joas Schilling
87dc3b1e55 [ticket/11495] Use item ids instead of requiring all data
The data is grabbed again in most cases anyway, so it just makes the system
easier to use.

PHPBB3-11495
2013-04-19 21:07:42 +02:00
Joas Schilling
db5df5b6ac [ticket/10966] Introduce MSSQL base class for native and ODBC
PHPBB3-10966
2013-04-19 19:11:22 +02:00
Joas Schilling
f66b5323a7 [ticket/11495] Cast some values to int
PHPBB3-11495
2013-04-19 19:09:22 +02:00
Joas Schilling
3d54a81ed9 [ticket/11495] Use item_id only as parameter for delete() and remove()
The data is acquired again anyway

PHPBB3-11495
2013-04-19 16:19:01 +02:00
Joas Schilling
d24ff2329f [ticket/11495] Use item_id only as parameter for get_branch_data()
PHPBB3-11495
2013-04-19 16:18:03 +02:00
Joas Schilling
f3ff8b36be [ticket/11495] Fix Spacing and lowercase on docs
PHPBB3-11495
2013-04-19 01:14:38 +02:00
Joas Schilling
5cb7342dd3 [ticket/11495] Remove acquire locks from forum implementation
PHPBB3-11495
2013-04-18 22:17:05 +02:00
Joas Schilling
b28180be1d [ticket/11495] Acquire locks for operations that manipulate the tree
PHPBB3-11495
2013-04-18 22:16:14 +02:00
Joas Schilling
153b29c6c9 [ticket/11495] Remove item class as its no longer required
PHPBB3-11495
2013-04-18 19:31:08 +02:00
Joas Schilling
ccd4a725da [ticket/11362] Add compatibility function phpbb_clean_path() again
The function first depends on the container, but also works without it and
without autoload. The reason for this is, it might be used before that
stuff is set up, like it has been in our common.php

PHPBB3-11362
2013-04-18 09:53:02 +02:00
Joas Schilling
a183fc1118 [ticket/11495] Manually specify the table columns
PHPBB3-11495
2013-04-18 00:54:26 +02:00
Joas Schilling
514bcb2fac [ticket/11495] Move nestedset default values to new method
PHPBB3-11495
2013-04-18 00:50:30 +02:00
Joas Schilling
e0393a3062 [ticket/11495] Fix column variable names
PHPBB3-11495
2013-04-18 00:34:09 +02:00
Joas Schilling
86937e03ec [ticket/11495] Remove item classes
PHPBB3-11495
2013-04-18 00:15:02 +02:00
Joas Schilling
8c3443ba99 [ticket/11495] Use array directly instead of phpbb_nestedset_item_interface
PHPBB3-11495
2013-04-18 00:13:19 +02:00
Joas Schilling
5c379db085 [ticket/11495] Fix description of get_sql_where
PHPBB3-11495
2013-04-17 22:56:12 +02:00
Joas Schilling
f831e3c66e [ticket/11495] Use unique properties for the column names
PHPBB3-11495
2013-04-17 22:52:17 +02:00
Joas Schilling
e2875a7e17 [ticket/10966] Introduce MySQL base class
PHPBB3-10966
2013-04-17 21:25:35 +02:00