Commit graph

8183 commits

Author SHA1 Message Date
David King
7dfe26dd78 [task/functional] Allow tests to bypass certain restrictions with DEBUG_TEST
PHPBB3-10758
2012-09-01 10:37:44 -04:00
Unknown Bliss
f05a175e39 [ticket/10631] Fixing a few extension admin issues
PHPBB3-10631
2012-09-01 15:05:59 +01:00
Unknown Bliss
323bbf9b52 [ticket/10631] Adjust prefixes to be easier to understand
PHPBB3-10631
2012-09-01 15:05:57 +01:00
Nathan Guse
7b643fe8a5 [ticket/10631] Make failure to meet ext enable requirements clearer
Turn the blocks red on the details page if requirement is not met.

Also changing a how the errors come up when trying to enable/disable
an extension when they cannot be.

PHPBB3-10631
2012-09-01 15:05:56 +01:00
Nathan Guse
dce04b2d03 [ticket/10631] Various front-end fixes (extensions manager)
Add Back button from details

Add cancel button from actions

Correct language strings

PHPBB3-10631
2012-09-01 15:05:54 +01:00
Nathan Guse
36465c9a20 [ticket/10631] Functional acp_extensions test, cleanup
PHPBB3-10631
2012-09-01 15:05:49 +01:00
Nathan Guse
500879520c [ticket/10631] Metadata manager tests
PHPBB3-10631
2012-09-01 15:05:47 +01:00
Nathan Guse
747c16240f [ticket/10631] get_extension_metadata_manager -> create_extension_metadata_manager
PHPBB3-10631
2012-09-01 15:05:40 +01:00
Nathan Guse
2a7e129291 [ticket/10631] Simplify exceptions
PHPBB-10631
2012-09-01 15:05:36 +01:00
Nathan Guse
89f4cf6a8c [ticket/10631] Use exceptions for errors. Build action list dynamically.
PHPBB3-10631
2012-09-01 15:05:34 +01:00
Nathan Guse
106c105113 [ticket/10631] Fix some issues as noted in github comments, significantly simplified validation
PHPBB3-10631
2012-09-01 15:05:32 +01:00
Nathan Guse
2273ae2b34 [ticket/10631] Remove references to delete extension
PHPBB3-10631
2012-09-01 15:05:30 +01:00
Nathan Guse
8df9963fcc [ticket/10631] Additional validation
PHPBB3-10631
2012-09-01 15:05:26 +01:00
Nathan Guse
4314284de1 [ticket/10631] Remove code duplication
PHPBB3-10631
2012-09-01 15:05:24 +01:00
Nathan Guse
8bbab088dd [ticket/10631] Validation for extensions
PHPBB3-10631
2012-09-01 15:05:23 +01:00
Nathan Guse
74492b3cdd [ticket/10631] Use display name if available
PHPBB3-10631
2012-09-01 15:05:20 +01:00
Nathan Guse
28ca2d6a5f [ticket/10631] Stagger the enable/disable/purge for extensions
PHPBB3-10631
2012-09-01 15:05:18 +01:00
Nathan Guse
bf6e91b5f3 [ticket/10631] Fixing some more issues
PHPBB3-10631
2012-09-01 15:05:16 +01:00
Nathan Guse
6b12f71b94 [ticket/10631] Fix list_available_exts
PHPBB3-10631
2012-09-01 15:05:14 +01:00
Nathan Guse
3ba59c6362 [ticket/10631] Various tidbits and cleanup on the acp extensions manager
PHPBB3-10631
2012-09-01 15:05:12 +01:00
Michael Cullum
c45243a91e [ticket/10631] Fix so it installs the module in the correct place
PHPBB3-10631
2012-09-01 15:05:10 +01:00
Michael Cullum
0c18b16e28 [ticket/10631] Adding docblocks
PHPBB3-10631
2012-09-01 15:05:06 +01:00
Michael Cullum
dd4f07f9bb [ticket/10631] Template shouldn't be required
PHPBB3-10631
2012-09-01 15:05:04 +01:00
Michael Cullum
3e6761b026 [ticket/10631] Fixing and finishing the extension metadata class.
PHPBB3-10631
2012-09-01 15:05:03 +01:00
Michael Cullum
10cba1426d [ticket/10631] Some tidying up
PHPBB3-10631
2012-09-01 15:05:00 +01:00
Michael Cullum
ac883e2652 [ticket/10631] Remove the now un-used method
PHPBB3-10631
2012-09-01 15:04:58 +01:00
Michael Cullum
a0e283d7b0 [ticket/10631] Adding extension metadata manager class
PHPBB3-10631
2012-09-01 15:04:56 +01:00
Michael Cullum
4cbfa61753 [ticket/10631] A few more extension admin changes
PHPBB3-10631
2012-09-01 15:04:55 +01:00
Michael Cullum
7a954d352e [ticket/10631] Fixing some items mentioned in PR
PHPBB3-10631
2012-09-01 15:04:53 +01:00
Michael Cullum
3a5843959c [ticket/10631] Fixing some extension admin issues found
PHPBB3-10631
2012-09-01 15:04:50 +01:00
Michael Cullum
305b5fe939 [ticket/10631] Fixing some issues spotted in extensions admin
Removing whitespace, cast the items from the json file straight into template vars (not via variables) and fixing some double quotes to single quotes.

PHPBB3-10631
2012-09-01 15:04:39 +01:00
Michael Cullum
5e6b4c7192 [ticket/10631] Adding an extensions admin
PHPBB3-10631
2012-09-01 15:04:33 +01:00
Joas Schilling
c03d692a98 [feature/soft-delete] Fix some more usages of _approved column names
PHPBB3-9657
2012-08-30 22:57:00 +02:00
Joas Schilling
a6d3432f8b [feature/soft-delete] Update search to use $post_visibility
Todo: Sphinx currently does not respect this setting at all.

PHPBB3-9657
2012-08-30 22:20:52 +02:00
Joas Schilling
5b54ec2d64 [feature/soft-delete] Try to fix search.php
at least it's running now, but the performance is not very good.

PHPBB3-9657
2012-08-30 19:47:16 +02:00
Joas Schilling
1c043254c0 [feature/soft-delete] Add get_visibility_sql_forums based on global
The resulting query is 4-times faster, as the forum_id IN () arrays are
smaller and we need less AND/OR to build the hole query. The main difference
between those two functions is, that this one takes an array of included ids and
the _global one takes an array of excluded ids.

PHPBB3-9657
2012-08-30 18:07:00 +02:00
Joas Schilling
a1e0690b6b [feature/soft-delete] Simplification part2: user can see all item visibilities
If the user can see all visibilities, we can simply leave out the query part,
instead of adding a bunch of ANDs.

PHPBB3-9657
2012-08-29 22:12:33 +02:00
Joas Schilling
44ed05f567 [feature/soft-delete] Simplify the query output if the user has m_restore
PHPBB3-9657
2012-08-29 19:30:33 +02:00
Joas Schilling
8a036fa3e4 [feature/soft-delete] Update restoring feature to use ajax if requested.
Also fixes the mcp as a hole:
- displayes a success message
- gives a link to the post, if only one was restored

PHPBB3-9657
2012-08-29 18:42:14 +02:00
Joas Schilling
b774c09c7f [feature/soft-delete] Use the variable which holds the correct item status
PHPBB3-9657
2012-08-29 17:50:14 +02:00
Joas Schilling
1935568c3e [feature/soft-delete] Fix typo in column name topic_visibility
PHPBB3-9657
2012-08-29 17:50:13 +02:00
Joas Schilling
5ff35ccf72 [feature/soft-delete] Use autoloading for content_visibility class
PHPBB3-9657
2012-08-29 17:50:12 +02:00
Josh Woody
1ab41f8dc6 [feature/soft-delete] Fix some small bugs
To wit: using non-existing constant POST_DELETED in posting.php; first test
post was initially unapproved; soft delete checkbox appeared at post time
Links pointing to the wrong place.

PHPBB3-9657
2012-08-29 17:50:12 +02:00
Josh Woody
f570558a8d [feature/soft-delete] Add a processor for action == restore in mcp_queue.php
Restoring a post within mcp_queue.php didn't do anything before this commit.  Now it does, by way of a function which is very similar to approve_post.

PHPBB3-9657
2012-08-29 17:50:12 +02:00
Josh Woody
a80cfafdd9 [feature/soft-delete] Rename phpbb_visibility class to phpbb_content_visibility
Rename the class to more accurately reflect what it does.

PHPBB3-9657
2012-08-29 17:50:11 +02:00
Josh Woody
6739375135 [feature/soft-delete] Add unit tests for the phpbb_visibility class
Add unit tests for the phpbb_visibility class.  Adjust the phpbb_visibility class to pass those unit tests.  The changes are pretty small, actually.

PHPBB3-9657
2012-08-29 17:50:11 +02:00
Josh Woody
fb13ab83e4 [feature/soft-delete] Implement the ability to soft-delete and restore posts
The soft delete feature seems to work.  Tests are pending.  A real icon is pending.  Add the permissions and the interface to soft-delete posts.  Also able to restore posts via the MCP queue

PHPBB3-9657
2012-08-29 17:50:11 +02:00
Josh Woody
c32d760806 [feature/soft-delete] I told you I was going to rename the class!
Rename topic_visibility class to phpbb_visibility. Also a bit of work to the class itself, mostly cleanup and adding the comments that I'd previously written.

PHPBB3-9657
2012-08-29 17:49:38 +02:00
Josh Woody
244f6e2ddc [feature/soft-delete] Correct some mistakes in e8d47
Notably: Uncomment the die() in create_schema_files, and add the class that makes everything tick.

PHPBB3-9657
2012-08-29 17:49:37 +02:00
Josh Woody
b8c55291ed [feature/soft-delete] Lay the groundwork for a soft-delete feature
So far, I've added no new functionality.  The biggest change here is adjusting the DB column names to "visibility" rather than "approved".  Some things here are pretty likely to change, for example the name and location of the topic_visibility class. Happy birthday phpBB :)

PHPBB3-9657
2012-08-29 17:49:37 +02:00