Commit graph

14593 commits

Author SHA1 Message Date
Andreas Fischer
f4df152b4b Merge remote-tracking branch 'p/ticket/11162' into develop-olympus
* p/ticket/11162: (22 commits)
  [ticket/11162] Reformat.
  [ticket/11162] Rename tricky updates to database helper.
  [ticket/11162] Use empty($queries).
  [ticket/11162] Review comments fixed.
  [ticket/11162] Reformat.
  [ticket/11162] Newlines to LF.
  [ticket/11162] Use correct functions.
  [ticket/11162] Account for notify_status.
  [ticket/11162] This test really only works for bookmarks.
  [ticket/11162] The test is not at all trivial.
  [ticket/11162] Add includes.
  [ticket/11162] Move to a separate file to avoid blowing out functions.php.
  [ticket/11162] No whitespace changes in olympus.
  [ticket/11162] Fix inaccurately copy pasted comment.
  [ticket/11162] Use phpbb_update_rows_avoiding_duplicates in mcp.
  [ticket/11162] Clarify that only the two tables actually work.
  [ticket/11162] Uncomment transactions.
  [ticket/11162] An implementation that actually works.
  [ticket/11162] Make count function upper case.
  [ticket/11162] Rename count variable name to remaining_rows.
  ...
2012-12-14 02:55:07 +01:00
Nathan Guse
ddd874ba76 [ticket/11103] dbal -> phpbb_db_driver
PHPBB3-11103
2012-12-13 19:46:32 -06:00
Nathan Guse
1cdb0ecbf2 [ticket/11103] Add global $table_prefix
I have no idea how this worked previously...

PHPBB3-11103
2012-12-13 19:32:11 -06:00
Nathan Guse
d64eb0e575 Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11103
# By Oleg Pudeyev (21) and others
# Via Andreas Fischer (7) and others
* 'develop' of github.com:phpbb/phpbb3: (56 commits)
  [ticket/11015] Move comment in the right place.
  [ticket/11015] Correctly transform 'mysqli' etc. in phpbb_convert_30_dbms_to_31
  [ticket/11015] Fix 3.0 to 3.1 dbms conversion for mysqli.
  [ticket/11015] Change permission adding in database updater to new style.
  [ticket/11015] Change more docblocks to phpbb_db_driver.
  [ticket/11015] Installer still needs 3.0-style dbms name.
  [ticket/11262] Add .lock in cache directory to .gitignore
  [ticket/11015] Include functions.php because it is not always included.
  [ticket/11265] Add assertions for board installation success.
  [ticket/11263] Fix PHP Notice: Undefined variable: extension_manager
  [ticket/11015] Convert database drivers to new spelling in post setup sync.
  [ticket/11015] Convert connect test to the new syntax.
  [ticket/11015] Restore whitespace to avoid conflict when merging develop.
  [ticket/10975] Add a test for viewing a profile.
  [ticket/10975] Test restricting by first character.
  [ticket/10975] Avoid rewriting global config twice.
  [ticket/10975] Test memberlist, not user creation.
  [ticket/10975] Some quick tests to check the memberlist behaviour
  [ticket/10491] Make recreate_database static.
  [ticket/11088] Pass required objects in as arguments
  ...

Conflicts:
	phpBB/install/database_update.php
2012-12-13 19:21:29 -06:00
Nathan Guse
8e6f9b38fb Merge branch 'ticket/11103' of github.com:EXreaction/phpbb3 into ticket/11103
# By Oleg Pudeyev (42) and others
# Via David King (2) and others
* 'ticket/11103' of github.com:EXreaction/phpbb3: (58 commits)
  [ticket/11103] Revert changes to constants.php from my IDE
  [ticket/11243] Show download all link on all pages of topic with attachments
  [feature/template-events] Pass arguments in correct order.
  [feature/template-events] Pass arguments in correct order.
  [ticket/10972] Drop user deletion.
  [ticket/10972] Tweak user addition.
  [ticket/10972] Add destroy method to mock cache.
  [ticket/10972] Add mock null cache.
  [ticket/10972] Backport get_db from develop.
  [ticket/10972] Added explicit checks for creating duplicate users.
  [ticket/10972] Moved tests into appropriate places and added comments
  [ticket/10972] Added methods for creating and deleting basic users
  [feature/template-events] Order extensions in mock extension manager.
  [feature/template-events] Changes per imkingdavid's review.
  [feature/template-events] Make style names private on template.
  [feature/template-events] Test for event that is defined in parent style only.
  [feature/template-events] Specify style names, add inheritance tests.
  [feature/template-events] Normalize expected directory trees.
  [feature/template-events] Allow dataset to be correctly selectable.
  [feature/template-events] Dataset for template event testing with inheritance.
  ...
2012-12-13 19:19:57 -06:00
Nathan Guse
249f3c8885 [ticket/11103] Instantiate $phpbb_notifications as needed
https://github.com/phpbb/phpbb3/pull/992#discussion_r2413976

PHPBB3-11103
2012-12-13 19:19:40 -06:00
Oleg Pudeyev
89f069637c [ticket/11015] Move comment in the right place.
PHPBB3-11015
2012-12-13 19:21:23 -05:00
Andreas Fischer
ee7dc9e5a0 [ticket/11015] Correctly transform 'mysqli' etc. in phpbb_convert_30_dbms_to_31
PHPBB3-11015
2012-12-13 19:18:49 -05:00
Oleg Pudeyev
9e3fd3bf8e [ticket/11015] Fix 3.0 to 3.1 dbms conversion for mysqli.
PHPBB3-11015
2012-12-13 19:15:24 -05:00
Oleg Pudeyev
1a1ae1b663 [ticket/11015] Change permission adding in database updater to new style.
PHPBB3-11015
2012-12-13 18:00:29 -05:00
Oleg Pudeyev
12bc77d034 [ticket/11015] Change more docblocks to phpbb_db_driver.
PHPBB3-11015
2012-12-13 18:00:12 -05:00
Oleg Pudeyev
2d5ba0ebd7 Merge remote-tracking branch 'upstream/develop' into ticket/11015
* upstream/develop:
  [ticket/11262] Add .lock in cache directory to .gitignore
  [ticket/11265] Add assertions for board installation success.
  [ticket/11263] Fix PHP Notice: Undefined variable: extension_manager
  [ticket/10975] Add a test for viewing a profile.
  [ticket/10975] Test restricting by first character.
  [ticket/10975] Avoid rewriting global config twice.
  [ticket/10975] Test memberlist, not user creation.
  [ticket/10975] Some quick tests to check the memberlist behaviour
2012-12-13 17:43:57 -05:00
Marc Alexander
5919407a1d [ticket/10954] Fix scope of current_object
PHPBB3-10954
2012-12-13 20:43:38 +01:00
Nathan Guse
ec074eb97c [ticket/11263] Fix PHP Notice: Undefined variable: extension_manager
$extension_manager should be $phpbb_extension_manager

PHPBB3-11263
2012-12-13 13:10:26 -06:00
Marc Alexander
a3f18caacc [ticket/10954] Only call $(this) once and reduce number of DOM traversals
PHPBB3-10954
2012-12-13 17:56:09 +01:00
Oleg Pudeyev
aae7a81270 Merge remote-tracking branch 'upstream/develop' into ticket/11015
* upstream/develop: (101 commits)
  [ticket/10491] Make recreate_database static.
  [ticket/11088] Pass required objects in as arguments
  [ticket/11088] Globalize objects in new permission function
  [ticket/11088] Move permission creation to a function
  [ticket/11088] Copy a_styles permission for a_extensions
  [ticket/11088] Remove extraneous word from sentence in comment
  [ticket/11088] Changed "file extensions" to "attachment extensions"
  [ticket/11088] Fix the database updater to correctly manipulate the modules
  [ticket/11088] Put language pack module move below extension module creation
  [ticket/11088] Untested, progress on update script
  [ticket/11088] Fix typo (period instead of comma)
  [ticket/11088] Untested progress for update script
  [ticket/11088] Added missing comma
  [ticket/11088] Removed added space
  [ticket/11088] Move style, extension and language pack management to customise
  [ticket/11243] Show download all link on all pages of topic with attachments
  [feature/template-events] Pass arguments in correct order.
  [feature/template-events] Pass arguments in correct order.
  [ticket/10491] Install board once per test run.
  [ticket/11257] Do not require set_name() method to exist
  ...
2012-12-13 07:56:40 -05:00
Oleg Pudeyev
10ee54d028 [ticket/11015] Restore whitespace to avoid conflict when merging develop.
PHPBB3-11015
2012-12-13 07:56:23 -05:00
Oleg Pudeyev
e2c67a8e42 [ticket/11162] Rename tricky updates to database helper.
PHPBB3-11162
2012-12-12 21:46:38 -05:00
David King
a5783211c9 [ticket/11088] Pass required objects in as arguments
PHPBB3-11088
2012-12-12 20:19:06 -05:00
David King
5fc6752178 [ticket/11088] Globalize objects in new permission function
PHPBB3-11088
2012-12-12 20:04:20 -05:00
David King
13f8e64a33 [ticket/11088] Move permission creation to a function
PHPBB3-11088
2012-12-12 20:01:58 -05:00
David King
8e4c1526fc [ticket/11088] Copy a_styles permission for a_extensions
PHPBB3-11088
2012-12-12 19:39:48 -05:00
David King
61adfa5026 [ticket/11088] Remove extraneous word from sentence in comment
PHPBB3-11088
2012-12-12 19:37:39 -05:00
David King
6dc89d6e31 [ticket/11088] Changed "file extensions" to "attachment extensions"
PHPBB3-11088
2012-12-12 19:36:52 -05:00
Nathaniel Guse
ffd531e4fd [ticket/11103] Revert changes to constants.php from my IDE
Readd a blank line at the end of the file

PHPBB3-11103
2012-12-12 16:33:30 -06:00
Nathaniel Guse
7ae5b62fc6 Merge branch 'develop' of git://github.com/phpbb/phpbb3 into ticket/11103 2012-12-12 16:30:50 -06:00
Marc Alexander
7efc37d1f9 [ticket/10954] Modify is_ajax check for consistency
PHPBB3-10954
2012-12-12 19:09:18 +01:00
David King
70aea6fd7c [ticket/11088] Fix the database updater to correctly manipulate the modules
PHPBB3-11088
2012-12-12 12:48:27 -05:00
Marc Alexander
a57c81481d [ticket/10954] Mark topics read without popup
Also added missing handling of locked forums.

PHPBB3-10954
2012-12-12 18:38:17 +01:00
David King
80f68c358f [ticket/11088] Put language pack module move below extension module creation
PHPBB3-11088
2012-12-12 11:40:47 -05:00
David King
30c64f6a01 [ticket/11088] Untested, progress on update script
This should rename Styles category to Customise, move language packs, and add extension management

PHPBB3-11088
2012-12-12 11:40:46 -05:00
David King
72d1a210de [ticket/11088] Fix typo (period instead of comma)
PHPBB3-11088
2012-12-12 11:40:43 -05:00
David King
e58c6536f0 [ticket/11088] Untested progress for update script
PHPBB3-11088
2012-12-12 11:39:17 -05:00
David King
e2aef2bfd1 [ticket/11088] Added missing comma
PHPBB3-11088
2012-12-12 11:39:16 -05:00
David King
f7d9b15a97 [ticket/11088] Removed added space
PHPBB3-11088
2012-12-12 11:39:15 -05:00
David King
4980d8b011 [ticket/11088] Move style, extension and language pack management to customise
Instead of being separated, these related ACP modules are now grouped
intuitively.

PHPBB3-11088
2012-12-12 11:39:14 -05:00
Marc Alexander
7ce009f2e2 [ticket/10954] Mark forums read without popup or page refresh
PHPBB3-10954
2012-12-12 12:46:20 +01:00
Marc Alexander
2f47c99432 [feature/avatars] Add more consistency to codebase
PHPBB3-10018
2012-12-11 21:02:37 +01:00
David King
53c4a328a6 [ticket/11243] Show download all link on all pages of topic with attachments
PHPBB3-11243
2012-12-11 11:42:34 -05:00
Joas Schilling
bd334d318f [ticket/10714] Forgot most important, use container to create $phpbb_log
PHPBB3-10714
2012-12-11 13:59:21 +01:00
Joas Schilling
c7ae790d16 [ticket/10714] Remove type hinting to allow the usage of mocks in tests
PHPBB3-10714
2012-12-11 10:25:38 +01:00
Nathan Guse
61391f648c [ticket/11259] htmlspecialchars($phpbb_admin_path)
PHPBB3-11259
2012-12-10 21:16:08 -06:00
David King
2212294ba3 Merge remote-tracking branch 'p/feature/template-events' into develop
* p/feature/template-events:
  [feature/template-events] Pass arguments in correct order.

Conflicts:
	phpBB/includes/style/style.php
2012-12-10 14:27:18 -05:00
David King
a9db155c28 Merge remote-tracking branch 'p/feature/template-events' into develop
# By Oleg Pudeyev (36) and others
# Via Oleg Pudeyev
* p/feature/template-events: (47 commits)
  [feature/template-events] Pass arguments in correct order.
  [feature/template-events] Order extensions in mock extension manager.
  [feature/template-events] Changes per imkingdavid's review.
  [feature/template-events] Make style names private on template.
  [feature/template-events] Test for event that is defined in parent style only.
  [feature/template-events] Specify style names, add inheritance tests.
  [feature/template-events] Normalize expected directory trees.
  [feature/template-events] Allow dataset to be correctly selectable.
  [feature/template-events] Dataset for template event testing with inheritance.
  [feature/template-events] Use style names array in template filter.
  [feature/template-events] Generate style names array in set_style.
  [feature/template-events] Convert a single style name to array of them.
  [feature/template-events] Chase dependency injection for template context.
  [feature/template-events] Adjust template events test to use the dataset.
  [feature/template-events] Create a dataset for template event tests.
  [feature/template-events] Indentation fix.
  [feature/template-events] Cosmetic changes.
  [feature/template-events] Wording: wrongly -> improperly.
  [feature/template-events] Indentation fix.
  [feature/template-events] Rename template_name to style_name.
  ...
2012-12-10 14:09:10 -05:00
Oleg Pudeyev
a0211ff2eb [feature/template-events] Pass arguments in correct order.
Thank you imkingdavid.

PHPBB3-9550
2012-12-10 14:02:57 -05:00
Oleg Pudeyev
0446886f91 [feature/template-events] Pass arguments in correct order.
Thank you imkingdavid.

PHPBB3-9550
2012-12-10 13:35:15 -05:00
Nathan Guse
30de17f69f [ticket/11259] adm_relative_path -> phpbb_adm_relative_path
We can assume they properly format their config settings, right?

PHPBB3-11259
2012-12-09 19:29:51 -06:00
Nathan Guse
bff76f9ca8 [ticket/11259] Also make adm_relative_path available in the container
PHPBB3-11259
2012-12-09 17:05:12 -06:00
Nathan Guse
6dee253941 [ticket/11259] Make phpbb_admin_path available everywhere
PHPBB3-11259
2012-12-09 17:01:08 -06:00
Joas Schilling
83b8b65016 [ticket/10714] Use dependencies instead of globals
We use a setter for the admin root path, as it is not defined all the time.
Aswell as we added a setter for the table name, so it can still be used
for custom tables.

PHPBB3-10714
2012-12-09 23:47:46 +01:00