Nathan Guse
c911a34b5b
[ticket/11103] Do not prepend notification.(type|method) unless necessary
...
PHPBB3-11103
2012-11-21 16:04:01 -06:00
Marc Alexander
8a01bc1718
[feature/avatars] Use RecursiveDirectoryIterator for gallery avatar
...
RecursiveDirectoryIterator is now used for populating the avatar list
array of the gallery avatar.
PHPBB3-10018
2012-11-21 21:42:42 +01:00
Marc Alexander
24ac039336
[feature/avatars] Get rid of array_keys() in gallery avatar
...
PHPBB3-10018
2012-11-21 20:01:50 +01:00
Marc Alexander
01b313ea26
[feature/avatars] Use isset() instead of in_array()
...
PHPBB3-10018
2012-11-21 19:20:39 +01:00
Marc Alexander
8c782122c1
[feature/avatars] Use in_array() and fix tabbing
...
PHPBB3-10018
2012-11-21 17:24:02 +01:00
Marc Alexander
726d1a16d7
[feature/avatars] Move avatar specific settings to drivers
...
PHPBB3-10018
2012-11-21 17:15:35 +01:00
Marc Alexander
9b61204a17
[feature/avatars] Check if gravatar is within min/max width/height
...
PHPBB3-10018
2012-11-21 16:27:20 +01:00
Marc Alexander
b7b14f9a05
[feature/avatars] Use constant for URL and fix usage of getimagesize
...
We now use a constant for the gravatar URL. Additionally the usage of
getimagesize() was reduced. It should only be run if the user didn't
specify both the width and height of the avatar.
PHPBB3-10018
2012-11-21 16:20:14 +01:00
Nathan Guse
61aa53f91a
Merge branch 'develop' of git://github.com/phpbb/phpbb3 into ticket/11103
...
Conflicts:
phpBB/config/services.yml
phpBB/index.php
2012-11-20 23:19:51 -06:00
Nathan Guse
570c5ad3c0
[ticket/11103] Some comments
...
PHPBB3-11103
2012-11-20 23:12:37 -06:00
Nathan Guse
2afb8b9df8
[ticket/11103] Create user loader class, update for DIC
...
Create a very basic user loader class to handle querying/storing
user data in a centralized location.
Use DIC collection service for notification types/methods.
Cleanup unused dependencies.
Fix some other issues.
PHPBB3-11103
2012-11-20 22:54:16 -06:00
Marc Alexander
858c59279c
[feature/avatars] Use protected instead of private
...
PHPBB3-10018
2012-11-19 23:50:34 +01:00
Igor Wiedler
b453f359ff
Merge remote-tracking branch 'imkingdavid/feature/controller-new' into develop
...
* imkingdavid/feature/controller-new: (67 commits)
[feature/controller] Fix misnamed route for functional test
[feature/controller] Fix comments, check against more general HttpException
[feature/controller] Check for proper status codes from controllers
[feature/controller] Correctly create Symfony object from globals
[feature/controller] Add documentation about input being HTML-escaped
[feature/controller] Create Symfony Request in new function
[feature/controller] Remove unused language strings
[feature/controller] Don't use $user->lang() before container compilation
[feature/controller] Update routing documentation for using query string
[feature/controller] Remove now-unused code
[feature/controller] Remove url rewriting until we use pathinfo in controllers
[feature/controller] Fix functional tests to use query string for controllers
[feature/controller] Allow injecting Symfony Request into controllers
[feature/controller] Use query string, not path info, for controller access
[feature/controller] Fix line endings and permissions, and check responses
[feature/controller] Remove URL rewriting by default
[feature/controller] Add controller functional test with template
[feature/controller] Use warning instead of echo for copy() and unlink()
[feature/controller] Flip method parameters, require $message
[feature/controller] Rename $root_path class property to $phpbb_root_path
...
2012-11-19 22:28:12 +01:00
David King
01ec608593
[feature/controller] Fix comments, check against more general HttpException
...
PHPBB3-10864
2012-11-19 12:55:15 -05:00
David King
f8614bfc84
[feature/controller] Check for proper status codes from controllers
...
PHPBB3-10864
2012-11-19 12:37:20 -05:00
David King
3004350281
[feature/controller] Correctly create Symfony object from globals
...
PHPBB3-10864
2012-11-19 11:47:42 -05:00
Marc Alexander
8d0c667dce
[feature/avatars] Fix the docs and small naming fixes
...
PHPBB3-10018
2012-11-19 00:30:18 +01:00
Marc Alexander
bea6e845d3
[feature/avatars] Use https for gravatar
...
PHPBB3-10018
2012-11-19 00:27:22 +01:00
Marc Alexander
7521c077a9
[feature/avatars] Miscellaenous template fixes
...
PHPBB3-10018
2012-11-18 23:16:37 +01:00
Marc Alexander
c2ba24558f
[feature/avatars] Fix local and upload avatar in the ACP
...
PHPBB3-10018
2012-11-18 23:11:40 +01:00
Marc Alexander
959bc183bf
[feature/avatars] Handle deletion of avatars
...
Previously this wasn't handled correctly if at all.
PHPBB3-10018
2012-11-18 23:09:09 +01:00
David King
e2bf66d065
[feature/controller] Add documentation about input being HTML-escaped
...
PHPBB3-10864
2012-11-18 15:58:47 -05:00
David King
0f4f81b096
[feature/controller] Create Symfony Request in new function
...
PHPBB3-10864
2012-11-18 15:52:35 -05:00
David King
2f50d65648
[feature/controller] Remove unused language strings
...
PHPBB3-10864
2012-11-18 15:51:32 -05:00
David King
60c0a1dd2a
[feature/controller] Don't use $user->lang() before container compilation
...
PHPBB3-10864
2012-11-18 15:51:05 -05:00
Marc Alexander
d8510356d6
[feature/avatars] Add subsilver2 support
...
This implementation might not be perfect though.
PHPBB3-10018
2012-11-18 20:47:29 +01:00
Marc Alexander
1c3b3621db
[feature/avatars] Add missing assign_block_vars() for avatar options
...
This is needed for selecting the gallery avatar while using subsilver2.
PHPBB3-10018
2012-11-18 20:45:51 +01:00
David King
50a96a2a2d
[feature/controller] Update routing documentation for using query string
...
PHPBB3-10864
2012-11-18 13:40:24 -05:00
David King
53caf83233
[feature/controller] Remove now-unused code
...
PHPBB3-10864
2012-11-18 13:35:04 -05:00
David King
09d7367dfc
[feature/controller] Remove url rewriting until we use pathinfo in controllers
...
PHPBB3-10864
2012-11-18 13:32:54 -05:00
Oleg Pudeyev
f4fedfe95b
Merge PR #1098 branch 'igorw/ticket/11213' into develop
...
* igorw/ticket/11213:
[ticket/11213] Add missing global in install_update.php
2012-11-18 10:20:59 -05:00
David King
4d6f6351dd
[feature/controller] Allow injecting Symfony Request into controllers
...
PHPBB3-10864
2012-11-17 18:05:32 -05:00
David King
8913b2c7c4
[feature/controller] Use query string, not path info, for controller access
...
This is hopefully just temporary until we can fix the relative path issue.
PHPBB3-10864
2012-11-17 17:48:20 -05:00
Oleg Pudeyev
47a90f815d
[feature/template-events] Changes per imkingdavid's review.
...
PHPBB3-9550
2012-11-17 16:43:40 -05:00
Oleg Pudeyev
da7d888448
[feature/template-events] Make style names private on template.
...
PHPBB3-9550
2012-11-17 16:43:38 -05:00
Oleg Pudeyev
af47779f51
[feature/template-events] Use style names array in template filter.
...
This provides a straightforward way of iterating over all styles
looking for templates in extensions.
PHPBB3-9550
2012-11-17 16:42:43 -05:00
Oleg Pudeyev
729eeef2bf
[feature/template-events] Generate style names array in set_style.
...
PHPBB3-9550
2012-11-17 16:42:43 -05:00
Oleg Pudeyev
44d6dc4c4c
[feature/template-events] Convert a single style name to array of them.
...
This allows template code to know the entire style hierarchy for
templates being rendered.
PHPBB3-9550
2012-11-17 16:42:40 -05:00
Nathan Guse
0141154ceb
[feature/template-events] Indentation fix.
...
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Oleg Pudeyev
6c7f1f7bde
[feature/template-events] Cosmetic changes.
...
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Nathan Guse
4ed9e4124e
[feature/template-events] Wording: wrongly -> improperly.
...
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Nathan Guse
2fb4006056
[feature/template-events] Indentation fix.
...
PHPBB3-9550
2012-11-17 16:40:00 -05:00
Oleg Pudeyev
9c31a0ffc7
[feature/template-events] Rename template_name to style_name.
...
"Style name" makes a lot more sense and should be in line with
recent style/template changes.
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
09b4cf2f4c
[feature/template-events] Report when templates cannot be compiled.
...
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
4b28b413f2
[feature/template-events] Update EVENT tag documentation.
...
It should now fairly closely reflect what actually happens.
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
faf96a1b40
[feature/template-events] Delete old comments/test code.
...
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
bd63b17d00
[feature/template-events] Move comment to the function docblock.
...
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
1b36fc3a60
[feature/template-events] Handle user access correctly.
...
Pass through $user from template to filter.
Allow $user to be null for standalone usage of the template engine.
PHPBB3-9550
2012-11-17 16:39:59 -05:00
Oleg Pudeyev
45a1219886
[feature/template-events] Always commit suicide for invalid event names.
...
Note: suicide happens for syntactically invalid event names,
e.g. event names containing punctuation.
Event names for which there are no events are silently dropped.
PHPBB3-9550
2012-11-17 16:39:58 -05:00
Oleg Pudeyev
f46f48a2cf
[feature/template-events] Chase template/style renames and changes.
...
PHPBB3-9550
2012-11-17 16:39:58 -05:00