Commit graph

14815 commits

Author SHA1 Message Date
David King
305f41cf1a [feature/controller] Fix misnamed route for functional test
PHPBB3-10864
2012-11-19 13:16:55 -05:00
David King
01ec608593 [feature/controller] Fix comments, check against more general HttpException
PHPBB3-10864
2012-11-19 12:55:15 -05:00
David King
f8614bfc84 [feature/controller] Check for proper status codes from controllers
PHPBB3-10864
2012-11-19 12:37:20 -05:00
David King
3004350281 [feature/controller] Correctly create Symfony object from globals
PHPBB3-10864
2012-11-19 11:47:42 -05:00
Joas Schilling
a7404409a8 [ticket/11219] Add unit test for inserting into a sequence column
PHPBB3-11219
2012-11-19 14:27:26 +01:00
Patrick Webster
41a95d2c64 [ticket/11219] Update sequence values after loading fixtures
If a value is provide for an auto_increment type of column, certain DBMSes
do not update their internal sequencers. If a row is inserted later, it can
be given an ID that is already in use, resulting in an error. The database
test cases now resynchronise the sequencers before the tests are run.

PHPBB3-11219
2012-11-18 20:38:58 -06:00
David King
e2bf66d065 [feature/controller] Add documentation about input being HTML-escaped
PHPBB3-10864
2012-11-18 15:58:47 -05:00
David King
0f4f81b096 [feature/controller] Create Symfony Request in new function
PHPBB3-10864
2012-11-18 15:52:35 -05:00
David King
2f50d65648 [feature/controller] Remove unused language strings
PHPBB3-10864
2012-11-18 15:51:32 -05:00
David King
60c0a1dd2a [feature/controller] Don't use $user->lang() before container compilation
PHPBB3-10864
2012-11-18 15:51:05 -05:00
Oleg Pudeyev
7ec94208c4 [ticket/11202] Fix comment char, use more descriptive comment.
PHPBB3-11202
2012-11-18 14:32:48 -05:00
Oleg Pudeyev
440c66267e [ticket/11202] Add response assertions to file upload functional test.
PHPBB3-11202
2012-11-18 14:15:23 -05:00
David King
50a96a2a2d [feature/controller] Update routing documentation for using query string
PHPBB3-10864
2012-11-18 13:40:24 -05:00
David King
53caf83233 [feature/controller] Remove now-unused code
PHPBB3-10864
2012-11-18 13:35:04 -05:00
David King
09d7367dfc [feature/controller] Remove url rewriting until we use pathinfo in controllers
PHPBB3-10864
2012-11-18 13:32:54 -05:00
David King
7a3d9ed85d [feature/controller] Fix functional tests to use query string for controllers
PHPBB3-10864
2012-11-18 13:11:24 -05:00
Oleg Pudeyev
f4fedfe95b Merge PR #1098 branch 'igorw/ticket/11213' into develop
* igorw/ticket/11213:
  [ticket/11213] Add missing global in install_update.php
2012-11-18 10:20:59 -05:00
David King
4d6f6351dd [feature/controller] Allow injecting Symfony Request into controllers
PHPBB3-10864
2012-11-17 18:05:32 -05:00
David King
8913b2c7c4 [feature/controller] Use query string, not path info, for controller access
This is hopefully just temporary until we can fix the relative path issue.

PHPBB3-10864
2012-11-17 17:48:20 -05:00
Igor Wiedler
b5e069f879 Merge remote-tracking branch 'p/ticket/10933' into develop
* p/ticket/10933:
  [ticket/10933] Prose for get_first_file_location.
  [ticket/10933] Remaining documentation for added functions in resource locator
  [ticket/10933] Update template locator test to use style resource locator.
  [ticket/10933] Dispose of locate function in template class.
  [ticket/10933] Add mutators for template_path to style resource locator.
  [ticket/10933] Delete template_path assignment.
  [ticket/10933] Delete template_path from template class.
  [ticket/10933] Add get_first_template_location.
2012-11-17 19:49:03 +01:00
Oleg Pudeyev
e07db8fb8c Merge PR #1097 branch 'igorw/ticket/11212' into develop
* igorw/ticket/11212:
  [ticket/11212] Cosmetic surgery done right
  [ticket/11212] Cosmetics
  [ticket/11212] Rename get_http_version to phpbb_request_http_version()
  [ticket/11212] Allow dispatcher to be absent during garbage_collection()
  [ticket/11212] Do not rely on $request in send_status_line()
2012-11-17 12:24:15 -05:00
Igor Wiedler
b8cf74217a [ticket/11212] Cosmetic surgery done right
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
1affc35be9 [ticket/11212] Cosmetics
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
b534a7a579 [ticket/11212] Rename get_http_version to phpbb_request_http_version()
PHPBB3-11212
2012-11-17 05:29:49 +01:00
Igor Wiedler
98921e0b87 [ticket/11213] Add missing global in install_update.php
PHPBB3-11213
2012-11-17 05:27:36 +01:00
Igor Wiedler
9cdef7984f [ticket/11212] Allow dispatcher to be absent during garbage_collection()
PHPBB3-11212
2012-11-17 01:17:23 +01:00
Igor Wiedler
5fad4006e1 [ticket/11212] Do not rely on $request in send_status_line()
PHPBB3-11212
2012-11-17 01:15:50 +01:00
David King
4efbb893b7 [feature/controller] Fix line endings and permissions, and check responses
PHPBB3-10864
2012-11-16 17:36:39 -05:00
David King
abf2575bdb [feature/controller] Remove URL rewriting by default
PHPBB3-10864
2012-11-16 17:06:02 -05:00
David King
5b013ddf5c [feature/controller] Add controller functional test with template
PHPBB3-10864
2012-11-16 17:06:01 -05:00
David King
ba1acdca03 [feature/controller] Use warning instead of echo for copy() and unlink()
PHPBB3-10864
2012-11-16 17:06:00 -05:00
David King
1952a4f276 [feature/controller] Flip method parameters, require $message
PHPBB3-10864
2012-11-16 17:06:00 -05:00
David King
d41b1146e8 [feature/controller] Rename $root_path class property to $phpbb_root_path
PHPBB3-10864
2012-11-16 17:05:59 -05:00
David King
c2f352ab35 [feature/controller] Fix param block for controller callable
PHPBB3-10864
2012-11-16 17:05:58 -05:00
David King
0c75d3d7da [feature/controller] Add test for missing argument in controller class
PHPBB3-10864
2012-11-16 17:05:57 -05:00
David King
230897723c [feature/controller] Reword comment for clarification
PHPBB3-10864
2012-11-16 17:05:57 -05:00
David King
e516680859 [feature/controller] Use sizeof() instead of count() as per guidelines
PHPBB3-10864
2012-11-16 17:05:56 -05:00
David King
120267e580 [feature/controller] Correctly access user object
PHPBB3-10864
2012-11-16 17:05:55 -05:00
David King
74bc460493 [feature/controller] Rename improperly named controller exception class
PHPBB3-10864
2012-11-16 17:05:55 -05:00
David King
7691755883 [feature/controller] Adapt functional tests given new controller framework
PHPBB3-10864
2012-11-16 17:05:54 -05:00
David King
c9588572c9 [feature/controller] Add period before $phpEx
PHPBB3-10864
2012-11-16 17:05:53 -05:00
David King
a87a5dd566 [feature/controller] Fix tests
PHPBB3-10864
2012-11-16 17:05:53 -05:00
David King
b2598662af [feature/controller] Clarify working paths after enabling rewriting
PHPBB3-10864
2012-11-16 17:05:52 -05:00
David King
f42b36185c [feature/controller] Better explanation of the Options +FollowSymLinks line
PHPBB3-10864
2012-11-16 17:05:51 -05:00
David King
45b3ab8e81 [feature/controller] Move Response definition into a variable
PHPBB3-10864
2012-11-16 17:05:51 -05:00
David King
235b0194f1 [feature/controller] Update wording in .htaccess documentation comments
PHPBB3-10864
2012-11-16 17:05:50 -05:00
David King
14f44c17ad [feature/controller] phpbb_controller_exception instead of RuntimeException
PHPBB3-10864
2012-11-16 17:05:49 -05:00
David King
d0269629dc [feature/controller] Documentation about Symlinks in .htaccess
PHPBB3-10864
2012-11-16 17:05:49 -05:00
David King
db071d6854 [feature/controller] Fix use of $this in global scope
PHPBB3-10864
2012-11-16 17:05:48 -05:00
David King
91ce6e8b16 [feature/controller] Turn off URL rewriting by default, add comments for usage
PHPBB3-10864
2012-11-16 17:05:47 -05:00