Commit graph

16983 commits

Author SHA1 Message Date
Matt Friedman
b95631b163 [ticket/12104] Remove empty LEFT_JOIN array
PHPBB3-12104
2014-01-09 15:42:25 -08:00
Matt Friedman
f9cef15989 [ticket/12104] Replace shadow topics $sql with $sql_array for better Event handling
PHPBB3-12104
2014-01-09 12:43:33 -08:00
Joas Schilling
3e84fb76a3 Merge remote-tracking branch 'Marc/ticket/11997' into develop
* Marc/ticket/11997: (23 commits)
  [ticket/11997] Use functional test cases that should always work
  [ticket/11997] Fix redirect tests for mod rewrite
  [ticket/11997] Add user's page dir to redirect path and fix unit tests for it
  [ticket/11997] Remove obsolete function get_controller_redirect_url()
  [ticket/11997] Use path_helper in in foo/bar extension for redirect URLs
  [ticket/11997] Add remove_web_root_path() in order to prevent incorrect URLs
  [ticket/11997] Do not check if file or dir we redirect to exist
  [ticket/11997] Modifiy tests after adding path_helper clean_url method
  [ticket/11997] Add clean_url() method to path_helper
  [ticket/11997] Allow redirects to parent folders like previously
  [ticket/11997] Move expected redirect returns to controller and output to HTML
  [ticket/11997] Fix tests for path_helper's get_controller_redirect_url()
  [ticket/11997] Use get_controller_redirect_url() in redirect() function
  [ticket/11997] Add method for controller redirect URLs to path helper
  [ticket/11997] Undo changes to phpbb_own_realpath()
  [ticket/11997] Remove obsolete failover_flag in function redirect()
  [ticket/11997] Add functional test for redirects in controller
  [ticket/11997] Fix missing global
  [ticket/11997] Fix redirects from inside controllers
  [ticket/11997] Use $phpbb_filesystem->clean_path() for proper redirect paths
  ...
2014-01-08 16:17:48 +01:00
Nathan Guse
821f737560 Merge pull request #1890 from prototech/ticket/12034
[ticket/12034] AJAXify notifications popup.
2013-12-30 12:20:22 -08:00
Nathan Guse
b186d31ce6 Merge pull request #1920 from prototech/ticket/12038
[ticket/12038] AJAXify move up/down buttons for various ACP pages.
2013-12-30 11:23:22 -08:00
Cesar G
d76ec60ee1 [ticket/12034] Move similar code in the two callbacks to separate function.
PHPBB3-12034
2013-12-30 11:12:15 -08:00
Cesar G
0c0375df65 [ticket/12034] Add comma to end of array.
PHPBB3-12034
2013-12-30 11:12:15 -08:00
Cesar G
f4b832a27d [ticket/12034] AJAXify notifications popup.
PHPBB3-12034
2013-12-30 11:12:15 -08:00
Cesar G
06262aca54 [ticket/12038] Free query results.
PHPBB3-12038
2013-12-30 11:09:08 -08:00
Nathan Guse
be67124dc7 Merge pull request #1889 from prototech/ticket/11963
[ticket/11963] Remove stale MCP notifications.
2013-12-30 11:04:43 -08:00
Nathan Guse
34c3e74c16 Merge pull request #1913 from prototech/ticket/12055
[ticket/12055] Alternate table row background colors using nth-child rule.
2013-12-30 10:44:30 -08:00
Marc Alexander
4c1569dd8a [ticket/11997] Add user's page dir to redirect path and fix unit tests for it
The user's page directory needs to be added to the redirect URL for proper
redirects outside of the forum root. Fix the unit tests accordingly.

PHPBB3-11997
2013-12-28 00:14:12 +01:00
Marc Alexander
ce2c5213d7 [ticket/11997] Remove obsolete function get_controller_redirect_url()
PHPBB3-11997
2013-12-27 18:41:44 +01:00
Marc Alexander
a304d99b2b [ticket/11997] Add remove_web_root_path() in order to prevent incorrect URLs
Adding a call to this method to the redirect function will make sure that we
do not end up with incorrect URLs after using append_sid().

PHPBB3-11997
2013-12-27 17:50:17 +01:00
Dhruv
db94f80c5b Merge remote-tracking branch 'nickvergessen/ticket/11911' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/11911:
  [ticket/11911] Warn admins when there is no search index for the selected engine
2013-12-27 18:01:48 +05:30
Joas Schilling
bef7bc7900 [ticket/11911] Warn admins when there is no search index for the selected engine
PHPBB3-11911
2013-12-27 13:16:38 +01:00
Marc Alexander
9161816267 [ticket/11997] Do not check if file or dir we redirect to exist
The redirect function will now properly redirect to where we want it to.
It will no longer try to check if the file or directory we redirect to exist.
This will ensure compatibility with the new routes.

PHPBB3-11997
2013-12-27 13:00:22 +01:00
Dhruv
f9c7f0fc19 Merge remote-tracking branch 'nickvergessen/feature/pagination-class' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/feature/pagination-class:
  [ticket/11849] Fix more function calls
  [ticket/11849] Update more MCP calls to pagination class
  [ticket/11849] Update some ACP modules with new pagination
  [ticket/11849] Update rest of the UCP modules
  [ticket/11849] Update UCP notifications and pm folder
  [ticket/11849] Update search and memberlist
  [ticket/11849] Update pagination in viewonline.php
  [ticket/11849] Remove old pagination test
  [ticket/11849] Update pagination code in viewtopic.php
  [ticket/11849] Replace pagination in viewforum.php with class
  [ticket/11849] Add service definition
  [ticket/11849] Remove pagination functions
  [ticket/11849] Test validate_start and on_page
  [ticket/11849] Move pagination code to class
2013-12-25 00:54:07 +05:30
Marc Alexander
d9358c26da [ticket/11997] Add clean_url() method to path_helper
This method will get rid of unnecessary . and .. in URLs.

PHPBB3-11997
2013-12-21 20:08:00 +01:00
Andreas Fischer
02336d9a69 Merge pull request #1940 from prototech/ticket/12079
[ticket/12079] Add default value to $multibyte in request.untrimmed_varible().

* prototech/ticket/12079:
  [ticket/12079] Add default value to $multibyte in request.untrimmed_variable().
2013-12-21 19:24:21 +01:00
Marc Alexander
235d2069e0 [ticket/11997] Allow redirects to parent folders like previously
Redirects to parent folders were possible with the previous redirect function.
This change will allow these redirects again.

PHPBB3-11997
2013-12-21 16:31:20 +01:00
Joas Schilling
558f3cd21c Merge remote-tracking branch 'vsephpbb/ticket/12060' into develop
* vsephpbb/ticket/12060: (37 commits)
  [ticket/12060] A little less verbose cleanup of event docblocks
  [ticket/12060] Further clarifying new event docblocks as much as possible
  [ticket/12060] More fixes to dockblock for acp_bbcodes_modify_create event
  [ticket/12060] Remove whitespaces
  [ticket/12060] Fix docblock for acp_bbcodes_modify_create event
  [ticket/12060] Rename event in message parser to modify_format_display_text_after
  [ticket/12060] Add num_predefined_bbcodes to display_custom_bbcodes_modify_sql
  [ticket/12060] Further clarify/fix a var in acp_bbcodes_modify_create event doc block
  [ticket/12060] Use separate template event for acp user signature posting buttons
  [ticket/12060] Rename event from append to after in acp_bbcodes.html
  [ticket/12060] Correctly label alpha versions in event docblocks
  [ticket/12060] Fix u_action comments in docblocks
  [ticket/12060] Change @since in event docblocks
  [ticket/12060] Update the docblock comments in acp core events
  [ticket/12060] Refactor u_action in the events that use it
  [ticket/12060] Use $sql_ary instead of $sql
  [ticket/12060] Update docblock for core event due to addition of another var
  [ticket/12060] Remove re-tabbing of html from subsilver2 files
  [ticket/12060] Add $update_this_message var to the core event
  [ticket/12060] Adjust last item in array to use a comma instead of closing parenthesis
  ...
2013-12-20 16:11:02 +01:00
Cesar G
cd98dba0b9 [ticket/12079] Add default value to $multibyte in request.untrimmed_variable().
PHPBB3-12079
2013-12-19 19:09:40 -08:00
Joas Schilling
cb8b2bab5f [ticket/11849] Fix more function calls
PHPBB3-11849
2013-12-18 18:39:11 +01:00
Joas Schilling
edd183b53a [ticket/11849] Update more MCP calls to pagination class
PHPBB3-11849
2013-12-18 18:39:01 +01:00
Joas Schilling
8652589469 [ticket/11849] Update some ACP modules with new pagination
PHPBB3-11849
2013-12-18 18:36:47 +01:00
Joas Schilling
e4950ced92 [ticket/11849] Update rest of the UCP modules
PHPBB3-11849
2013-12-18 18:36:08 +01:00
Joas Schilling
a5b55e5ab4 [ticket/11849] Update UCP notifications and pm folder
PHPBB3-11849
2013-12-18 18:35:59 +01:00
Joas Schilling
dfe0526979 [ticket/11849] Update search and memberlist
PHPBB3-11849
2013-12-18 18:35:47 +01:00
Joas Schilling
59a24f6423 [ticket/11849] Update pagination in viewonline.php
PHPBB3-11849
2013-12-18 18:35:40 +01:00
Joas Schilling
4f4512cbac [ticket/11849] Update pagination code in viewtopic.php
PHPBB3-11849
2013-12-18 18:35:25 +01:00
Joas Schilling
725c512468 [ticket/11849] Replace pagination in viewforum.php with class
PHPBB3-11849
2013-12-18 18:35:16 +01:00
Joas Schilling
fcfa1a35cc [ticket/11849] Add service definition
PHPBB3-11849
2013-12-18 18:35:07 +01:00
Joas Schilling
a485184434 [ticket/11849] Remove pagination functions
The functions where changed in 3.1 anyway, so we can just delete them

PHPBB3-11849
2013-12-18 18:34:58 +01:00
Joas Schilling
268afe20f4 [ticket/11849] Move pagination code to class
PHPBB3-11849
2013-12-18 18:34:13 +01:00
Matt Friedman
121f2394ff [ticket/12060] A little less verbose cleanup of event docblocks
PHPBB3-12060
2013-12-17 18:55:59 -08:00
Matt Friedman
4665e3df21 [ticket/12060] Further clarifying new event docblocks as much as possible
PHPBB3-12060
2013-12-16 23:54:55 -08:00
Matt Friedman
01c4235f00 [ticket/12060] More fixes to dockblock for acp_bbcodes_modify_create event
PHPBB3-12060
2013-12-16 15:33:44 -08:00
Matt Friedman
df9e782fa4 [ticket/12060] Remove whitespaces
PHPBB3-12060
2013-12-16 15:31:44 -08:00
Matt Friedman
6b178c758e [ticket/12060] Fix docblock for acp_bbcodes_modify_create event
PHPBB3-12060
2013-12-16 15:31:25 -08:00
Joas Schilling
e3e34add7f Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10023] Make password change notification more noticeable
2013-12-16 10:25:45 +01:00
Joas Schilling
4a73ce0933 Merge remote-tracking branch 'prototech/ticket/12009' into develop
* prototech/ticket/12009:
  [ticket/12009] Prevent user from enabling invalid extension through direct URL
  [ticket/12009] Update functional test to check for invalid extensions.
  [ticket/12009] Fix functional tests.
  [ticket/12009] Move valid extensions in tests to correct dir structure.
  [ticket/12009] Do not allow incorrectly structured extensions to be installed.
2013-12-16 10:18:56 +01:00
Joas Schilling
8da2f349fe Merge remote-tracking branch 'vsephpbb/ticket/12054' into develop
* vsephpbb/ticket/12054:
  [ticket/12054] Re-word event documentation
  [ticket/12054] Reword descriptions and resort events alphabetically
  [ticket/12054] Update index_body_linklist_before/after template events
2013-12-16 10:08:19 +01:00
Matt Friedman
b13f64b5a9 [ticket/12054] Re-word event documentation
PHPBB3-12054
2013-12-14 12:59:52 -08:00
Matt Friedman
f045458679 [ticket/12060] Rename event in message parser to modify_format_display_text_after
PHPBB3-12060
2013-12-13 17:00:06 -08:00
Matt Friedman
a24d2058cd [ticket/12060] Add num_predefined_bbcodes to display_custom_bbcodes_modify_sql
event

PHPBB3-12060
2013-12-13 16:47:38 -08:00
Matt Friedman
aa0c463d0f [ticket/12060] Further clarify/fix a var in acp_bbcodes_modify_create event doc block
PHPBB3-12060
2013-12-13 16:46:12 -08:00
Matt Friedman
31eb759aa4 [ticket/12060] Use separate template event for acp user signature posting buttons
PHPBB3-12060
2013-12-13 13:36:59 -08:00
Matt Friedman
8864c601a2 [ticket/12060] Rename event from append to after in acp_bbcodes.html
PHPBB3-12060
2013-12-13 13:34:58 -08:00
Joas Schilling
a999dbad74 Merge remote-tracking branch 'vsephpbb/ticket/12063' into develop
* vsephpbb/ticket/12063:
  [ticket/12063] Use CSS to replace valign=top
  [ticket/12063] Remove obsolete valign attributes from tr tags
2013-12-13 20:28:22 +01:00